From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E61B9A0524; Wed, 2 Jun 2021 13:05:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 681F24069F; Wed, 2 Jun 2021 13:05:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6807F40689 for ; Wed, 2 Jun 2021 13:05:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622631917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wj0L1AHOq9DVeb4LwY+QB+J3sKYR7wZXZKbLF4PvJI8=; b=cRzrOT27Kfi9n6jT+hyiqhIwCrUUm9uATKHDYWbX1/rSpG4VO2QC+Tmt/21DvcqCo9blmt kjyDQVmlLvnsFlDAxNCGEHGu+PcefzUJ0jF7kaln3GuHXuzCnDTqGeRrBfBxQbx50dht1P cWJBuzggyGgMiQsj0KkN1fexmT341y8= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-SVkL5UUMMh2Px3GcTI7LYQ-1; Wed, 02 Jun 2021 07:05:14 -0400 X-MC-Unique: SVkL5UUMMh2Px3GcTI7LYQ-1 Received: by mail-ua1-f71.google.com with SMTP id s14-20020ab0372e0000b02902532152c190so835964uag.17 for ; Wed, 02 Jun 2021 04:05:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wj0L1AHOq9DVeb4LwY+QB+J3sKYR7wZXZKbLF4PvJI8=; b=kSKxxNPqYKnGNzcDn8HgvgfDZhPjG2UdUxlYzrMdeLkc0igM6m93nbHHbeFyKzB26z tDDQKWlRImRN+SluGmGwzivKEg+5zlPSKkpQOp9Em+K6NZQtcaOKcjD9EabVR5wt3mH1 ZWsU00LpgcZ61T9wqhgcCh2+yGuc5CM9Bq3my7VAJTIyCpR2Ez+o7m+E9MMowRwEruO3 OLYb7WMu1G33AybExyqdgq6Gw+UgY1XQ3imwKovchjgDxLH13t1yL7NKyXS3e2J4ekg5 0TcQ4YbAi3Fofqkp0TjgHSSU9IBgiy0nuozos+iKU49Fnos11wCthJp9OhRBVSs/PXAZ l02Q== X-Gm-Message-State: AOAM531Et0YleAsby6l5jxOdMJdQ3s+KrCtsVEYajSLV9f97IfBXE2Lk 4pF7f//hsYlj9MFe6/+fGHF77j6Eb6PBlsmm7t8wKBoa4Ye06CWU8idk1/bnT7IQXwjP6cxNTso 7w8xUn5HiYHk3WxB2NC0= X-Received: by 2002:a05:6102:2433:: with SMTP id l19mr12342028vsi.5.1622631914465; Wed, 02 Jun 2021 04:05:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh3Swmo2AQH8Z85Dh4aLEmpbhUe+6hAhv4ivOH6YthBv78loziYTYZ/yjaH2XGmiO4yNdQsK/jM0B2aYsK7OE= X-Received: by 2002:a05:6102:2433:: with SMTP id l19mr12341997vsi.5.1622631914259; Wed, 02 Jun 2021 04:05:14 -0700 (PDT) MIME-Version: 1.0 References: <20210602095836.24901-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 2 Jun 2021 13:05:02 +0200 Message-ID: To: Igor Russkikh Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH 0/2] Support compressed firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 2, 2021 at 12:38 PM Igor Russkikh wrote: > We (Marvell QED) already provide packed version of FW in linux-firmware: > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qed > > But thats a custom name, and zlib. Whatever binary blob is available in linux-firmware upstream repo, it ends up compressed on Fedora 34 (and later). # fc33 https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115649&filename=/usr/lib/firmware/qed/qed_init_values-8.10.9.0.bin https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115649&filename=/usr/lib/firmware/qed/qed_init_values_zipped-8.10.10.0.bin # fc34 https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115322&filename=/usr/lib/firmware/qed/qed_init_values-8.10.9.0.bin.xz https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115322&filename=/usr/lib/firmware/qed/qed_init_values_zipped-8.10.10.0.bin.xz # fc35 https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115234&filename=/usr/lib/firmware/qed/qed_init_values-8.10.9.0.bin.xz https://koji.fedoraproject.org/koji/fileinfo?rpmID=26115234&filename=/usr/lib/firmware/qed/qed_init_values_zipped-8.10.10.0.bin.xz Did you try the qede pmd on fc34? > > I'm just wondering if its a good solution to try transparently load .xz variant? The linux kernel (since v5.2, I think) uncompresses this transparently without kernel drivers knowing. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82fd7a8142a10b8eb41313074b3859d82c0857dc > User may not expect that. M.b. through this api, give a driver an option to specify > archive format? Or even autodetect it from content? User should (do ?) not care about firmwares, only drivers do. If not doing transparently, each driver will have to implement (or ask a common helper for) support of compressed blobs. While this issue is common to all drivers. As for autodetecting compression, libarchive can do this, I added only xz support because this is the only supported compression in the Linux kernel loader. -- David Marchand