From: Yunjian Wang <wangyunjian@huawei.com> The 'group_status' has never been used and can be removed. Fixes: 94c0776b1bad ("vfio: support hotplug") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- lib/librte_eal/linux/eal_vfio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c index d26e1649a..289f06650 100644 --- a/lib/librte_eal/linux/eal_vfio.c +++ b/lib/librte_eal/linux/eal_vfio.c @@ -929,9 +929,6 @@ int rte_vfio_release_device(const char *sysfs_base, const char *dev_addr, int vfio_dev_fd) { - struct vfio_group_status group_status = { - .argsz = sizeof(group_status) - }; struct vfio_config *vfio_cfg; int vfio_group_fd; int iommu_group_num; -- 2.23.0
On Sat, May 16, 2020 at 9:59 AM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The 'group_status' has never been used and can be removed.
>
> Fixes: 94c0776b1bad ("vfio: support hotplug")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> lib/librte_eal/linux/eal_vfio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c
> index d26e1649a..289f06650 100644
> --- a/lib/librte_eal/linux/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal_vfio.c
> @@ -929,9 +929,6 @@ int
> rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,
> int vfio_dev_fd)
> {
> - struct vfio_group_status group_status = {
> - .argsz = sizeof(group_status)
> - };
> struct vfio_config *vfio_cfg;
> int vfio_group_fd;
> int iommu_group_num;
> --
> 2.23.0
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
On Mon, Jun 29, 2020 at 11:44 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Sat, May 16, 2020 at 9:59 AM wangyunjian <wangyunjian@huawei.com> wrote:
> >
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > The 'group_status' has never been used and can be removed.
> >
> > Fixes: 94c0776b1bad ("vfio: support hotplug")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand