From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3261F431EE; Tue, 24 Oct 2023 11:50:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 234E3402BE; Tue, 24 Oct 2023 11:50:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C45F240285 for ; Tue, 24 Oct 2023 11:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698141001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7jtbfOK7W0xmCL9hSR8pVdXhwx7GLJ4/b4nn5YfQ64Y=; b=DWg7NSWK2HwhpzK2HWpsc7s9TAYujzCwfNSPCEq3M65bj6k32iQyKa8uf5yeNaD0XtyAdo REg2mFeEWlD3FV4SvN1EFY+SE7PIEfxn86Mz5xwSjGcS+rzR763VPz2JTBJdTgFZ/ctkP6 +nhajetYTvnkBE2GxK/IxXcfNt52Isk= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-EiOTgiXmO8ivSfDrwR6kQg-1; Tue, 24 Oct 2023 05:49:53 -0400 X-MC-Unique: EiOTgiXmO8ivSfDrwR6kQg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c5032ab59eso35969081fa.3 for ; Tue, 24 Oct 2023 02:49:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698140992; x=1698745792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jtbfOK7W0xmCL9hSR8pVdXhwx7GLJ4/b4nn5YfQ64Y=; b=wfKrLITGhjRLseEWrnM4WhXJAaez09AQ8ziUi2Q5B0okmWsHKWCfuCF52CNragqG5p CSa4ZCj2B+L3X2Gq9oWHtr7YtL8oZKYArurp8oXynRi2ETPD4Vnpzs/GfbIOzRC3WhVY 0U1ufZr8G4gjE8aF6P9bK293OJlrdjLdK5ZNkDMxknHFDVkkCUN7msk+KACvoXiTZsZO ikzG922sHCNm1n0Gc7gLjmzyeKiHKmnhZ2O38fX8tsElYdkN3QZx1XXz4Y4w8A3ykwWI XCKx0v55gxXYWv768GD1HHIC+VHGvKQqQxuvsA0iEuxUBpvST2tOB+ozURnbRAJ5/z7S le/w== X-Gm-Message-State: AOJu0Yzqp7050eseA+yz8lBZxRK2uuhi51ku5YGRSfaWx7GVuUjnKZeA 6RyGScUFv+UPNYUC/eRs+aFt8rksnsp1zcWIMksEFO1smlyicygGdpB6U1Dyh0OtCgxPEK1uhJ/ d1S6cw3hi1pBYq3Q5Sys= X-Received: by 2002:a2e:b172:0:b0:2c5:1388:e369 with SMTP id a18-20020a2eb172000000b002c51388e369mr9287717ljm.43.1698140992372; Tue, 24 Oct 2023 02:49:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAvxKj3qC4UFGqSldzQ4hn0WB3tYTnEzGO9K2ehqIjuRJmCZbePe7LIiIlct/5j0efmYPlOVLs3uvAPrgPs54= X-Received: by 2002:a2e:b172:0:b0:2c5:1388:e369 with SMTP id a18-20020a2eb172000000b002c51388e369mr9287698ljm.43.1698140992076; Tue, 24 Oct 2023 02:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20231024091328.11933-1-radu.nicolau@intel.com> In-Reply-To: <20231024091328.11933-1-radu.nicolau@intel.com> From: David Marchand Date: Tue, 24 Oct 2023 11:49:39 +0200 Message-ID: Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition To: Radu Nicolau Cc: Jingjing Wu , Beilei Xing , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 24, 2023 at 11:13=E2=80=AFAM Radu Nicolau wrote: > > IAVF_TX_OFFLOAD_MASK definition contained > RTE_ETH_TX_OFFLOAD_SECURITY instead of > RTE_MBUF_F_TX_SEC_OFFLOAD. > > Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau Something is not clear to me. How was the IPsec inline crypto feature supposed to work with this driver so far? Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have been refused in iavf_prep_pkts. --=20 David Marchand