From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C31BA0525; Fri, 21 Feb 2020 16:24:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A16794C81; Fri, 21 Feb 2020 16:24:45 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id CBA7D34F3 for ; Fri, 21 Feb 2020 16:24:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582298683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LI+NwTE/E52tMEHg+RdRrTKZV9RsEgupfsRNioVglu4=; b=iuafgmmDpFy2K7rXbWe5gUOjDGl8lVMfWiYPsku/Ou4QexgksOUQIrMSDguWNPz7ae6Cxg WbKHxFxOU8I/2ni2FflbH2Qe/LGW/jrn9GQrBdDEzTGaXpmZCxxPkosvgXMpIgEE86nKps Lf//BL8nunQmJnCm8KpwEwn4ymx1RXc= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-1APYbjqTPHqDXcBmda1cHA-1; Fri, 21 Feb 2020 10:24:41 -0500 X-MC-Unique: 1APYbjqTPHqDXcBmda1cHA-1 Received: by mail-vk1-f199.google.com with SMTP id i123so1057334vkg.8 for ; Fri, 21 Feb 2020 07:24:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qDYZiWqxNYuKWwy2hebezN5oBLt8wVaGDeFc6FrJ8TU=; b=J2QkyCSgAhig7UO/xEe5EzFOVc2DcRd89FUfosbXuvShdXhmFdfsIA1p6KE2HIlV3E L+XAFqbiq6ipluxt3Oipx4tVKOFiVkiJqStVO96R7nlWAEp4aLkKraGivWMYj79g696N 48xVYnLzYJHIIUVPafZepiixJ3YnUQjc85FurcDlCkg3ia0TH9x5GQ4H2Sql85EJPN4B ZA1hHUcqkB9xQpgDofLQR2BrCrPDOo3KUULIkGsUrzhr6kbBBzaSHvvofefQHmv3119g M4CUZzdx4kOIjahc+kMOj31qn35dVgR4eWqJMKXfozLeBkciStLOltI5dxbl6D+2+7Ew UTgQ== X-Gm-Message-State: APjAAAXocvoH+Bl+6znYPB5W5hMz+Ct/inz62s/UzSWYJNu4OnHRzoTf w9ojLbSxtHJwxfsbVXYe7Z/cD9Il4ZQL8UD7BgTxayh3eM8w2xuCvOtZK7OWSFDu+bzGB4iZEKk hdkmjhYlKSvUJJWMAJUU= X-Received: by 2002:ab0:7358:: with SMTP id k24mr18754316uap.87.1582298680612; Fri, 21 Feb 2020 07:24:40 -0800 (PST) X-Google-Smtp-Source: APXvYqxooJYxpfkmwU3hE9ouvn5cKWVr68Ioo1lrAgHWa76OaTIkcYrG9Vgzo9k8S1W+lsIOTcCGjqP5HC3pdoS19IM= X-Received: by 2002:ab0:7358:: with SMTP id k24mr18754300uap.87.1582298680287; Fri, 21 Feb 2020 07:24:40 -0800 (PST) MIME-Version: 1.0 References: <20200220195454.2363094-1-ferruh.yigit@intel.com> In-Reply-To: <20200220195454.2363094-1-ferruh.yigit@intel.com> From: David Marchand Date: Fri, 21 Feb 2020 16:24:29 +0100 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Neil Horman , Bruce Richardson , dev , "Kinsella, Ray" , Luca Boccassi , Kevin Traynor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] build: fix experimental library versioning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 20, 2020 at 8:55 PM Ferruh Yigit wrote= : > > The problem occurred when workaround that makes soname two digits > applied. With this change for the ABI version "20.0.1" the experimental > library version become ".so.2001". > After workaround removed in ABI version 21.0, the experimental library > version will become ".so.210". > "2001" is bigger value than "201" although it is a previous version of > the library version, this can break the version comparisons. > > To fix this, introducing a temporary sub level versioning for the > experimental libraries, so that minor version comparison will continue > to work. > > After change experimental libraries will follow below versioning: > > DPDK version ABI version soname library name > ------------ ----------- ------ ------------ > DPDK 19.11 20.0 .so.0.200 .so.0.200 > DPDK 20.02 20.0.1 .so.0.200.1 .so.0.200.1 > DPDK 20.05 20.0.2 .so.0.200.2 .so.0.200.2 > DPDK 20.11 21.0 .so.0.210 .so.0.210 > DPDK 21.02 21.1 .so.0.211 .so.0.211 > > Note: After workaround removed in DPDK 20.11 and soname switch back to > single digit this patch won't work and needs to be updated. > > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility") > > Signed-off-by: Ferruh Yigit The soname change breaks existing applications like testpmd (linked to various experimental libraries). I have the full details if needed in a pastebin (v19.11, master, patch_appl= ied). $ LD_LIBRARY_PATH=3D$HOME/builds/x86_64-native-linux-gcc+shared+kmods/insta= ll/lib $HOME/abi/v19.11/x86_64-native-linux-gcc+shared+kmods/bin/testpmd /home/dmarchan/abi/v19.11/x86_64-native-linux-gcc+shared+kmods/bin/testpmd: error while loading shared libraries: librte_flow_classify.so.0.200: cannot open shared object file: No such file or directory libabigail reports this change as an error, so if it is intended, we need to bypass the check for those libraries. Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable ELF SONAME changed Functions changes summary: 0 Removed, 0 Changed (7 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable SONAME changed from 'librte_flow_classify.so.0.200' to 'librte_flow_classify.so.0.200.1' Error: ABI issue reported for 'abidiff --suppr /home/dmarchan/dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 /home/dmarchan/abi/v19.11/x86_64-native-linux-gcc+shared+kmo= ds/include --headers-dir2 /home/dmarchan/builds/x86_64-native-linux-gcc+shared+kmods/i= nstall/include /home/dmarchan/abi/v19.11/x86_64-native-linux-gcc+shared+kmods/dump/librte_= flow_classify.dump /home/dmarchan/builds/x86_64-native-linux-gcc+shared+kmods/install/dump/lib= rte_flow_classify.dump' --=20 David Marchand