From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC5EBA0524; Thu, 4 Feb 2021 10:01:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77D462405DF; Thu, 4 Feb 2021 10:01:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id EF5F82405DA for ; Thu, 4 Feb 2021 10:01:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612429294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zKnk2sfUzqUetoD0L90lZLsxirALvkBthGHpQ0f4XcQ=; b=RtaNYJzi266WuyaHXv4jqrS7s2WVqwqLwyUCzBc4l3KF07m5zf8VZQHSgoPfFu4R678buV hY413JejFu0ELcJh60qT+B0zeloZ3TLXkfAj2az5JKX4o5c6J8Fez3L/zNSZbMWWy7R8yk Acm1ppix0a5+pthxLigt6jbpMJujEbc= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-GMsTukiuPEi1yP8eW1aafQ-1; Thu, 04 Feb 2021 04:01:31 -0500 X-MC-Unique: GMsTukiuPEi1yP8eW1aafQ-1 Received: by mail-ua1-f69.google.com with SMTP id a33so602869uae.7 for ; Thu, 04 Feb 2021 01:01:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKnk2sfUzqUetoD0L90lZLsxirALvkBthGHpQ0f4XcQ=; b=Tuh/hxws89pCWTlg7T+CvsV7wZejbOC4fjEKdruSi3eDQp9F891/enxGs/30XE1eLC ZoEUIh011PzVnH/8wcm5HrEFjogDg4poUocGlQrwKmlTvSjwXo7Bj7mC4IdnaB1Rl9XP hFDQcfAYD7YdVPbLv1c73p+inBqi3ysTcQj8ZaK/JgfCU6dNUHk4da0zO+onuaoKYx6C /EFZ32ZHAc5wJSXuPmW76nyTIi/bganu5mhSNrtppG++HP0d70Rop9/LhUhGSM5GJuRN cR/s/WKtJqGkbcVDNGcwcxmZsEpCQh1llzG8vO5WliQuMDo+IaYk563fco5ByxsMW3uA hx+Q== X-Gm-Message-State: AOAM530cO1pmdx30N/ijCPFOtfSvX9UoTVKF2w2wIWZQS9NT87hL9+zF DQuVtPgKMZ3CyQ6aAqHATU2RIzZah/gMeiej6IELUOA3jBy7hpzmsuV3UjL/w2xubQLJFFmWa68 IzTHcBxJk4XoXENLo0/k= X-Received: by 2002:ab0:2354:: with SMTP id h20mr307742uao.41.1612429290983; Thu, 04 Feb 2021 01:01:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHHMdABkc0XTTt+5JpbIoXswpdpBL3nv1fR3V21yJG5UtYKihf1G6eC8a2P92qZIZKEODkGXhSSVeD0xiJa68= X-Received: by 2002:ab0:2354:: with SMTP id h20mr307734uao.41.1612429290773; Thu, 04 Feb 2021 01:01:30 -0800 (PST) MIME-Version: 1.0 References: <20210204085209.2716232-1-mk@semihalf.com> In-Reply-To: <20210204085209.2716232-1-mk@semihalf.com> From: David Marchand Date: Thu, 4 Feb 2021 10:01:19 +0100 Message-ID: To: Michal Krawczyk , "Wiles, Keith" Cc: dev , Igor Chauskin , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk wrote: > > DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to > uint32_t. > > Due to define: > lib/common/pg_compat.h:#define udata64 dynfield1[0] > the copy of udata64 was in fact copying only the first 32 bits. I did not look at the pktgen code, but directly accessing mbuf field dynfieldX is likely a bug. pktgen should register a dynfield for its own usage to avoid conflicts with other parts of the dpdk. Example of such a conversion to the new mechanism: https://git.dpdk.org/dpdk/commit/?id=eb8258402b3f -- David Marchand