From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA933A00C4; Thu, 31 Oct 2019 17:18:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 811731C433; Thu, 31 Oct 2019 17:18:58 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 1FF2D1C437 for ; Thu, 31 Oct 2019 17:18:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572538729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0PdNs7ti7p454zCljf4A6F3bvTHWjK7Ca6pP27/buQ=; b=hDUIlYxN9nfZrBmkDxTvf1CRaksp+Iefe/itGiSvAzWtF5rmeIwLAFu9loldt7ZvEbTdsi evvukJjYksrkpa76GIkWLgUJoqNgO5a5zVbyDzD9RikXTFJAiTarTTLiIhrDIubKzfHYRT ONB7G9y11QIlJw+VYfqXzX0X47M6hUs= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-i4rBuRReOKunKDg3BRQXrQ-1; Thu, 31 Oct 2019 12:18:47 -0400 Received: by mail-vs1-f69.google.com with SMTP id b3so1155055vsh.0 for ; Thu, 31 Oct 2019 09:18:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IhPQF3O5HRGb5m/x3CvlKEBFHJZEOkfJRQrqiAze7kk=; b=tPSQv4C417SpNhEF94yXUOLI8iiLyrbk5r1mfOGlz5uxpBLgy2FJLDJxbLeKU8z+uR 8xkCxW+kBslRN4KsuuuFxVtoe20napR7rYCFb7oDQRm0FLvDEcpH9qfrpQmqDlp00g9r oCjdTTfrwAbGFzW9WqFG2M8PnnLl6MP0pNhs1JIJ7HOFM06y6JRY2rSPvUG5PXq8DQ+4 aWqUBnjX9Df7NHrFkyb6P7qO3awHfBFLXmlXbG3ZsNjPPzYKPkZk+PEXZACXJYGhOQiB aFm78xGNl9E77x1yV5X5JnT9SD8Oj5odIoZpILSChnftETTUTICMQGuCqlCehRJ7pliK gS3A== X-Gm-Message-State: APjAAAUnkknwZeetPmoJSbqRWpSEdO5CHr9cJ3Uz0bGUdIROEFIew3S5 KVvIxj3tKiurS9bEbaoGX0Rl+c8i4SgAiCrU1kCei0lnWf60MXFA6ii4OYV/nnJMHfV5qXq0VeX gNXWLNCE39HG7UkOR6ag= X-Received: by 2002:ab0:189a:: with SMTP id t26mr3330694uag.87.1572538727180; Thu, 31 Oct 2019 09:18:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPjavHzP2CAA07L9OkHOdRH0KQAHkTkhlHN9Wuw+XyDTUdau8H+lySw+ZaeLjbpx5yNPvY+DlGjuDh/IC+7OI= X-Received: by 2002:ab0:189a:: with SMTP id t26mr3330670uag.87.1572538726752; Thu, 31 Oct 2019 09:18:46 -0700 (PDT) MIME-Version: 1.0 References: <20191004111106.30267-1-nipun.gupta@nxp.com> <20191031124835.29927-1-nipun.gupta@nxp.com> In-Reply-To: <20191031124835.29927-1-nipun.gupta@nxp.com> From: David Marchand Date: Thu, 31 Oct 2019 17:18:35 +0100 Message-ID: To: Nipun Gupta Cc: dev , Thomas Monjalon , Hemant Agrawal , Sachin Saxena X-MC-Unique: i4rBuRReOKunKDg3BRQXrQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 31, 2019 at 2:04 PM Nipun Gupta wrote: > > This patch disables the 1588 timer support by default on DPAA2 > platform due to the performance impact. > By default it is disabled in the common/base, so remove the entry config/common_base > from DPAA2. > > Signed-off-by: Nipun Gupta > --- > > Changes in v2: > - Change only the 1588 timestamp option in DPAA2 and do not touch > the CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA option. > > config/defconfig_arm64-dpaa2-linuxapp-gcc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig= _arm64-dpaa2-linuxapp-gcc > index 5c7eddd5e..b2ccbec0c 100644 > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > @@ -15,8 +15,8 @@ CONFIG_RTE_CACHE_LINE_SIZE=3D64 > > CONFIG_RTE_PKTMBUF_HEADROOM=3D128 > > -# Enable IEEE1588, Keep it disable by default > -CONFIG_RTE_LIBRTE_IEEE1588=3Dy > +# Disable IEEE1588 by default > +CONFIG_RTE_LIBRTE_IEEE1588=3Dn Removed this block when applying, since, as the commitlog mentioned, it is disabled by default. > > # Doesn't support NUMA > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dn > -- > 2.17.1 > Reviewed-by: David Marchand Applied, thanks. -- David Marchand