From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C1F5A00E6 for ; Wed, 7 Aug 2019 14:01:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 165572BF1; Wed, 7 Aug 2019 14:01:13 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 09CE12BAE for ; Wed, 7 Aug 2019 14:01:12 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id o2so34933294uae.10 for ; Wed, 07 Aug 2019 05:01:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=47vEw7Ha4jbLqNxLZD+yWmEjOIAb3oZwpviyNedzxjs=; b=mT8LGByWdZYYPgPad8m83dm00KInDAlR48//JVJ9UzZ/ClpNNX4MnZWJ6Gr3Ib8xtB AKPrNuKo0ra2flHxEvcmXFi8ZOkNZsPKf/c6aqEL+W0WUoIvWbiAQNZTSr4Qs7qeEdrf YQdSwCNQdTfTZUx+I+l2c66A+MHQlhUkCaESYoEnlfk75Jbv4GJGgVG+x9SRJGQYSBAP WYZMy5pZiOBm6LPyIaQtD4d1/SIwbPhSoBQ+eWuNMy+7qgDn3o6T2zrJy5cALpMByuYw sTv0/P1shD2uuqqB/dffbQ4R1iDJoNkxg9nGEuNYXMPnXvLdtxMQfnuJJYEk7LKIz/ZC mDFQ== X-Gm-Message-State: APjAAAV4z4YNBWtNvNly+lEs95mOsfrtT5k1K7rubrc3PU7NqDfxpevx ioWuSp5trebC32y5S5QpT3rorl1JJ3qWIIdoa5A7sQ== X-Google-Smtp-Source: APXvYqxyXOcVU7JOy+tvp7+genpCXf9qWt+3S6Q+qc0L51Ii4Q3Kd2/uqMaUiqZiwKYn1tupjNkY3VG/9YUSlEcAH2A= X-Received: by 2002:ab0:45e3:: with SMTP id u90mr5640847uau.126.1565179271309; Wed, 07 Aug 2019 05:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20190807101204.21614-1-g.singh@nxp.com> In-Reply-To: <20190807101204.21614-1-g.singh@nxp.com> From: David Marchand Date: Wed, 7 Aug 2019 14:00:59 +0200 Message-ID: To: Gagandeep Singh Cc: dev , Thomas Monjalon , "Burakov, Anatoly" , Olivier Matz , Andrew Rybchenko , Nipun Gupta Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 7, 2019 at 12:26 PM Gagandeep Singh wrote: > > DPDK currently is supporting maximum 3 hugepage, > sizes whereas system can support more than this e.g. > 64K, 2M, 32M and 1G. You can mention ARM platform here, and that this issue starts with kernel 5.2 (and I would try to mention this in the title as well). This is better than an annotation that will be lost. > Having these four hugepage sizes available to use by DPDK, > which is valid in case of '--in-memory' EAL option or > using 4 separate mount points for each hugepage size; > hugepage_info_init() API reports an error. Can you describe what is the impact from a user point of view rather than mentioning this internal function? > This change increases the maximum supported mount points > to 4. I suppose this fix does the trick for you. However, we are in internal structures and I can't think of an impact on datapath. So we might as well use dynamic allocations rather than just enlarge this array. Did you consider this? -- David Marchand