From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F1245BD6; Fri, 25 Oct 2024 15:25:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 221204027E; Fri, 25 Oct 2024 15:25:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5FAB24021F for ; Fri, 25 Oct 2024 15:25:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729862714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3O0r1BVpCooT4z9sqTQa1Q7uR1de7mwJZUavZ/kxMU=; b=I0NC3d1XKQVQ0jaZ6ksx9ckd5R8rhtGzOuopxuVnkcG/wpeU09UeW7YHcANG4ei6ki1Nn0 LTwqNE4sZ3OEV+tN9EIHeyp6ddUifB5+SCIsNzlCKoVk0MC2M4kXsI+C3129OCfh7VROiE WP5lrCTzI6pWQwMtDDa+cTAYrfQjy8c= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-uk89T8eNMEOh_QsCorhu4w-1; Fri, 25 Oct 2024 09:25:09 -0400 X-MC-Unique: uk89T8eNMEOh_QsCorhu4w-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb5cdaba8aso21997521fa.1 for ; Fri, 25 Oct 2024 06:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729862706; x=1730467506; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r3O0r1BVpCooT4z9sqTQa1Q7uR1de7mwJZUavZ/kxMU=; b=v6FWhEVlOpyKhm2wzkVRK68gBCN8pP+lTTbrvmFNUJY/pzs0p3BvIG7SdudPuWbpaW cERlTyA8U7CzoG4et4vLMn5IQdif9pPlzMmFScQM9qrp1PlPblaO3qm0qdUUvJl8Nmeh e+TBuGLTSSQD6wy9MPMtWTEN0jQ/wjuYezk4x2xJ2ILqxLEzdsYebD3XnntIFmAnMWCq GnpsxZf4PI73D+scO1n3SB0duHBqo5LB+YLxYSKm1800lGUKl2yP/Zbv3YNC0ToC3qdS ws+olM5eFDx8OrUtZ5t8eYHySCY9ZK1lsTih9si5O05R9O1SkcdiEzeN+B8qEo+bWbP3 UY6w== X-Gm-Message-State: AOJu0Yy18P7QB9GMByYi8Zk3moy+JltmbFOnGEb5svb7Cj8fY2vqMG7I OQz5yGAZw09A1OtP8fOThFhMP3STBcecNEsnzYXqOMP8LcUqBl2VOu9InH4GwFxNVUBoiWzoIYj jIYHLgJUtW6JBu8XsldoLaJxg4cOnKvBm4fXfMMKZ9bj/ZM3dcIHlutQJcXZ1nQrOAM1wP3Kbn7 J+YmthKtftTCp+8rjNRwB4vr1tQg== X-Received: by 2002:a2e:6119:0:b0:2fc:9674:60b5 with SMTP id 38308e7fff4ca-2fc9d3497fdmr64494251fa.25.1729862706316; Fri, 25 Oct 2024 06:25:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJFVKIfG3YjQGN2ifz9CRT/SjIkOeX2vtlf58zwkiXhNpH86F5G31jsU0lhwwJrJx+0cZwlMAaeLyd6gZW2kQ= X-Received: by 2002:a2e:6119:0:b0:2fc:9674:60b5 with SMTP id 38308e7fff4ca-2fc9d3497fdmr64493991fa.25.1729862705939; Fri, 25 Oct 2024 06:25:05 -0700 (PDT) MIME-Version: 1.0 References: <20241017142214.1669370-1-bruce.richardson@intel.com> In-Reply-To: <20241017142214.1669370-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 25 Oct 2024 15:24:55 +0200 Message-ID: Subject: Re: [PATCH 0/6] Reduce scope address-of-packed-member warning To: dev@dpdk.org Cc: Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 17, 2024 at 4:22=E2=80=AFPM Bruce Richardson wrote: > > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of packed data should be generally avoided. > > This patchset initially applies some fixes for cases where we are > unnecessarily causing the warning to trigger. Thereafter the 6th patch > removes the global enabling of the warning and replaces it with more > selective disabling for drivers and for a couple of other components > which have not yet been fixed. > > Bruce Richardson (6): > ip_frag: remove use of unaligned variable > efd: remove unnecessary packed attributes > bus/ifpga: remove packed attribute > pipeline: remove packed attribute > net: add smaller IPv4 cksum function for simple cases > build: limit scope of packed member warning disabling > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > app/test-pmd/icmpecho.c | 23 +---------- > app/test-pmd/txonly.c | 22 +---------- > app/test/packet_burst_generator.c | 49 +----------------------- > app/test/test_reassembly_perf.c | 29 +------------- > config/meson.build | 1 - > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > drivers/meson.build | 9 +++-- > examples/ipsec-secgw/meson.build | 6 +++ > lib/efd/rte_efd.c | 4 +- > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > lib/net/rte_ip.h | 33 ++++++++++++++++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/meson.build | 5 ++- > 14 files changed, 60 insertions(+), 154 deletions(-) Recheck-request: rebase=3Dmain,iol-unit-amd64-testing,iol-unit-arm64-testin= g --=20 David Marchand