From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4138D45AE1; Tue, 8 Oct 2024 10:38:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C1E24021F; Tue, 8 Oct 2024 10:38:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 611F04021E for ; Tue, 8 Oct 2024 10:38:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728376706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+JCBj+X4RzHgMZnWYLqtmN+qexAssKIVk5739rbRTA=; b=G+N/MFROnR5bw27BQebg08bDhTjNw/iyCaDPB4MRPEx24mWex80kUYOjiT+2GF1lpajpKv tFYpCsS1RU4k9edu2zNBc45etOMr8z1Ic4LJmfyu9yHBKNSf4U14JE31nVVx09/QRIh7bs xgRvQ81EPkajEEQcUapfAd/MS4ZR9jc= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-XYzQRs9LNTORRFtu2_-dyQ-1; Tue, 08 Oct 2024 04:38:25 -0400 X-MC-Unique: XYzQRs9LNTORRFtu2_-dyQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5398b6cf250so4749584e87.2 for ; Tue, 08 Oct 2024 01:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728376704; x=1728981504; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+JCBj+X4RzHgMZnWYLqtmN+qexAssKIVk5739rbRTA=; b=R4uQuJxx9vc5AkHcTBgeKgb/Jx4FxIkuey0M8QzsiukkD6hR1ACaRKhGqDTD4ShSAh NYpgZoesfur1Og8p55XybvYypAZFuYzUouXsHSSdWXwN/Q/NLdJOncxssiT+ye9udekt RqwwKVGRNYJOTUiSHy/KfDTnAM53kZYdgD8md9HEdg52b/E5ooU+q943i3vF7pFJN1lT 4HWn4YOpcXJ9pQvSz9hOtzFXPU/bFmGCsccwpVgZ0+vzvOwmYXahb4VIkLV0dgMW/Tzh nTPUJ69dV1xBoGC3gUcg2h/bn0162iCs20wz1TxmM0+zBRi9OhUiAyE1y9b/WAHqe41U WqBw== X-Gm-Message-State: AOJu0YzXodony45fTKREUv3JNX3yxrdO7//1PC15gP69YqBG7jVH4cPE 9uvO7Y3GV4c5cBsMW3WG6G8/jOC3OJ3v6Fx0BRJErETEP65Oi0JVXeReuHAevyJWtliz7VUt4av EngdX1vVzgoQHD2LFlobqd8in6LSUX7wRftaEOhEGK0/1E5Q0GCnZvmR1SrJvJo2HZwL7o+eu+Y OLTbmEy9Dtjtqu4uc= X-Received: by 2002:a05:6512:68a:b0:539:8d2c:c01a with SMTP id 2adb3069b0e04-539ab87daf5mr11504662e87.29.1728376704322; Tue, 08 Oct 2024 01:38:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCFflNOVLv89ekB4V3MQDvnIm4N3BDwC1nl3UXyGdGwYPaacQFn0yt9HH/582Xf6jfGsWscvWuHC/vFUn3hhQ= X-Received: by 2002:a05:6512:68a:b0:539:8d2c:c01a with SMTP id 2adb3069b0e04-539ab87daf5mr11504630e87.29.1728376703907; Tue, 08 Oct 2024 01:38:23 -0700 (PDT) MIME-Version: 1.0 References: <20240904135939.329324-1-bruce.richardson@intel.com> <20240906161244.1663967-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Tue, 8 Oct 2024 10:38:12 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds To: Bruce Richardson Cc: dev@dpdk.org, Robin Jarry X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 19, 2024 at 10:02=E2=80=AFAM Bruce Richardson wrote: > > I was then surprised to read the result: > > ... > > 2024-09-19T07:22:12.6485260Z Checking for size of "void *" : 8 > > 2024-09-19T07:22:12.6485592Z Checking for size of "void *" : 8 > > ... > > > > > > *scratch* *scratch* > > So I retested the series locally on my f39 (the series seemed ok so > > far) but I downgraded meson to 0.53.2 (which is the version forced in > > GHA) and now I observe the same issue. > > > > I suspect something changed in the cross file handling in more recent > > meson versions. > > Likely, the c_args=3D or [build-in options] part is not read. > > > > Am I doing something wrong? > > > From the docs on cross-files [1], it appears that significant changes to > the cross-file handling was done in 0.56 release. That may be the cause. > I'll have to try some testing myself. > > Overall, I think we haven't increased our minimum meson version in some > time. Maybe it's time to consider doing so in this release or the next on= e? > Need to look through release notes to see how far forward to jump to see > what extra features might be useful for us to leverage. Just a note that I think it is safer to wait for the upgrade to meson 0.57 before merging this series. If this upgrade does not happen in this release, I'll merge at least the first patches but keep the old way of testing 32 bits in the devtools script. Ok for you? --=20 David Marchand