From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 031A042BA9; Fri, 26 May 2023 10:47:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD9F440DDA; Fri, 26 May 2023 10:47:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1678640A89 for ; Fri, 26 May 2023 10:47:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685090832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fM8lweYRGT1WTiagrv+Uga0ZqFtccRdW41EbrkB5GQ=; b=NAE7nGSwE7fbMsHmBKWAFtcInNJg4I8zgETrv5vQKWsmXCBQiNan52SQzEcTk3A2Y4afp/ 0H38CgNPrOR3mqN6lICraS/8LU6ejEoGhWzwQLNA8LeUDApeJZVYueRdlmj1koOMlfS1vI 6tO8kB7X1WM53Z4nVnVX7zzD8vodIrs= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-7Qj2zLPANUqPwGaliDofFA-1; Fri, 26 May 2023 04:47:11 -0400 X-MC-Unique: 7Qj2zLPANUqPwGaliDofFA-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2553f20d57fso846242a91.1 for ; Fri, 26 May 2023 01:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685090830; x=1687682830; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3fM8lweYRGT1WTiagrv+Uga0ZqFtccRdW41EbrkB5GQ=; b=ihGOk4ltPNeBwR6ihZuwswgT10hUkoZB0SKUQQ8ex7Zz3qmH7BMQnvFdxoYLzN9+vN 3S8o4zaR67oXx0am3x/t2YnYQHY/Ym+8OcMtKW/S2S+dVmkqTeHJSFiyqIRvXNtIrgTD AJmLW+plz+VO+88jqtRbBJ4gEDX+k7S6o8h4RUTowZb77IPK1s6/XS6eFLTgfeMe8s67 t3ve7Fi25QTM2X3yJhTHXiE4DdtenB7Gg1MGXzc7shN8sTKlE5DJZSWeL/gdgfh9h4UE pQzREPGl+mOJuW0l/IZCF7vb/T/S5ydTy6KT/jA5bA1pJU99JxFq1fhU103/A7FeJYjj iyZA== X-Gm-Message-State: AC+VfDwHbewmyf5MpBdoARYAzrJt5j5R7kRscs9ySW/QzDUJrp3dSMtT ffblzeP0wtpwYgCZST1C6fIvZkXqBorDSKe5oAZWTi2woNWNuFBdl8Z5E+DXAofaySAVbIDGfqQ W1W/iT0qgtzjDBeT+mQ0= X-Received: by 2002:a17:90b:1281:b0:255:2daa:4796 with SMTP id fw1-20020a17090b128100b002552daa4796mr1436639pjb.44.1685090830311; Fri, 26 May 2023 01:47:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GW5KpSaKo/DMoSxbhs9JVsNbJ/WqIQ1ZMXKaBqHVDSJyPBF8qPU6Hvjb78N9/uH8FDSiJm0l9wWTudUj39zE= X-Received: by 2002:a17:90b:1281:b0:255:2daa:4796 with SMTP id fw1-20020a17090b128100b002552daa4796mr1436629pjb.44.1685090830044; Fri, 26 May 2023 01:47:10 -0700 (PDT) MIME-Version: 1.0 References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-5-maxime.coquelin@redhat.com> In-Reply-To: <20230525162551.70359-5-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 26 May 2023 10:46:59 +0200 Message-ID: Subject: Re: [PATCH v3 04/28] vhost: add helper of IOTLB entries coredump To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 25, 2023 at 6:26=E2=80=AFPM Maxime Coquelin wrote: > @@ -149,8 +177,8 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net *= dev, struct vhost_virtqueue > rte_rwlock_write_lock(&vq->iotlb_lock); > > RTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) { > - mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, = false, > - hua_to_alignment(dev->mem, (void *)(uintptr_t)nod= e->uaddr)); > + vhost_user_iotlb_set_dump(dev, node); vhost_user_iotlb_clear_dump ? > + > TAILQ_REMOVE(&vq->iotlb_list, node, next); > vhost_user_iotlb_pool_put(vq, node); > } --=20 David Marchand