From: David Marchand <david.marchand@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "Ma, WenwuX" <wenwux.ma@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues
Date: Fri, 15 Oct 2021 10:52:14 +0200 [thread overview]
Message-ID: <CAJFAV8wS3TxBAZOQH2RozshoSZuTmKiN+z93U4des4PqRoLQ+A@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB4063C958F0BFC5679F20A8789CD69@MN2PR11MB4063.namprd11.prod.outlook.com>
On Fri, Sep 10, 2021 at 5:17 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> > if NIC’s max queues > the default number of 128,
> > so, we changed the default value from 128 to 512.
> >
>
> I'd say it's not cool to still hard-code the MAX_QUEUES so that only 'some' NICs
> can work with the example. The app should have a way to check this kind of info
+1...
> before init/start. But as I would like to see at some point, this example will
> be removed and all our tests go to testpmd. Let's not waste too much effort on
> this example.
And +1, this example is a mess.
--
David Marchand
next prev parent reply other threads:[~2021-10-15 8:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 13:52 Wenwu Ma
2021-09-10 2:12 ` Jiang, Cheng1
2021-09-10 3:17 ` Xia, Chenbo
2021-09-13 15:49 ` Maxime Coquelin
2021-10-15 7:30 ` Maxime Coquelin
2021-10-15 8:52 ` David Marchand [this message]
2021-10-15 16:48 ` [dpdk-dev] [PATCH v3] " Wenwu Ma
2021-10-21 11:29 ` Maxime Coquelin
2021-10-21 12:34 ` Maxime Coquelin
2021-10-21 17:10 ` Ferruh Yigit
2021-11-03 14:17 ` [dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost Wenwu Ma
2021-11-03 4:58 ` Xia, Chenbo
2021-11-03 8:07 ` Maxime Coquelin
2021-10-15 20:01 ` [dpdk-dev] [PATCH v2] examples/vhost: change the default value of NIC's max queues Wenwu Ma
2021-10-15 8:21 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wS3TxBAZOQH2RozshoSZuTmKiN+z93U4des4PqRoLQ+A@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=wenwux.ma@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).