From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14268A04B3; Fri, 8 Nov 2019 12:11:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EB901C06A; Fri, 8 Nov 2019 12:11:37 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 922561C039 for ; Fri, 8 Nov 2019 12:11:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573211496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kqg+Y/kM24dnxpe6OvkntSzAd5cMYgEGjh5ZB/ZGXlI=; b=E52soeeTaIPY4ZqIW8La8x/b1OOtWqfUTruDDkZ6e5mBgfSVwLZGBj8cs/+9e5mPjVidP7 yu0sPGru5DW8Q2tOsUUauw81AoD41s0MnoiN5nSgvOqAGNkU1ebYH/zLoc6GJTa+ahsC0f UsHPFvsYT3IYkitE7F9PnRW+erwocmA= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-anJd43w5PW6fAp3zMnnF4g-1; Fri, 08 Nov 2019 06:11:34 -0500 Received: by mail-vs1-f72.google.com with SMTP id e18so923324vsp.8 for ; Fri, 08 Nov 2019 03:11:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N8CcbDPd9Jo7U87Y1eeXuUuoHswbngxBcv4FfbAX0d0=; b=TrG0UDuoPxdeZMYk4EBIpODoeYGFZOmMBYwqE+ozGaGt3X9N75aQWTyKoZH6KJQfUC 4Win+U8KWwJGTHcankzIztpsVWXro+qFC3MA5NDiDaCMtLVVd8a4Mz6DpLmb9LVJmR5L ELv+Ashd4gjU0dUDsW8xTjzPM+DTHB6dniiwP1tXco8s5noE0MzKi03k1SCM9ny3H6mz kvfZIZJ6zZ3A7Muts4rUfrvA5/7sKF3CtppB6CWMJn3vTusztMvj35l8jKDBgK6YVuJT QFbUuwXtD4VZarCRtlDEOaWMbysQZmd/Ya71zAGo6h2fDA4HXTFWgi923aqnCITIw9Pr M6XQ== X-Gm-Message-State: APjAAAUBsqA03XdfX2oD7CHcVPyLBz7AgkLjnEAzMS9Pp1VftMheNom3 0f/ehIxmxKanGnmDXAUeeE3CIZd2S/ZEMlPx4don+Z+OT97UFN/pz168dO5g3WP8D2mQ9d0FxGh WYaqpMrYaYr/3GpV6IaA= X-Received: by 2002:a67:7d95:: with SMTP id y143mr7717725vsc.39.1573211493967; Fri, 08 Nov 2019 03:11:33 -0800 (PST) X-Google-Smtp-Source: APXvYqxZ+YphssNgtpiszSw/cEMa4/elAFoDzyTe1RENg54/V6IMI2jeDapGl6iPSDtAcNrA4bRiec9V9LUzG31Wa1o= X-Received: by 2002:a67:7d95:: with SMTP id y143mr7717697vsc.39.1573211493573; Fri, 08 Nov 2019 03:11:33 -0800 (PST) MIME-Version: 1.0 References: <20191108102135.7249-1-kkanas@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 8 Nov 2019 12:11:22 +0100 Message-ID: To: Krzysztof Kanas , Bruce Richardson Cc: dev , "Yigit, Ferruh" X-MC-Unique: anJd43w5PW6fAp3zMnnF4g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 8, 2019 at 12:05 PM David Marchand wrote: > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutf= f. > > Rest I will address here. > > > > > > > > > + const char *procdir =3D "/proc/self/fd/"; > > > > > > self is a Linux thing. > > > This won't work on FreeBSD. > > > > IMHO original code didn't worked on FreeBSD as well. > > I have created function to adress in third patch > > Indeed... > > Well, wait. > Why do we need to close those file descriptors? > FreeBSD has been like this for quite some time. > > Can't we just remove this code? > Maybe someone from Intel has an idea of why it was like this? Great... /* get file for config (fd is always 3) */ snprintf(path, sizeof(path), "/proc/self/fd/%d", 3); And this only applies to linux (getting the current file prefix). --=20 David Marchand