From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3F59A0C53; Wed, 3 Nov 2021 11:29:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81FDB41134; Wed, 3 Nov 2021 11:29:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 584F5410E5 for ; Wed, 3 Nov 2021 11:29:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635935385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kIU9yhsiKGmGeaUzgvYqm4XISi2RQdCmf3qI8MSkygM=; b=PNc2fooy2t4VY0qnUeKfgiFvVU3BKPYK6ccFol4IXsSV90e/PxvQ8hdk6qy6njNYssym/N YaZf0FgnqQSYoAe0mdhVWeK7yx2JF2+MGkThpjxpt9zC9FU9UYVo8KCWLrEs+jZcPSamZg xXgDfB0sJxS0qSxoJPNvfLBHCc1akGU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Bf_zn-PyNzOiOU3b_Cx9xw-1; Wed, 03 Nov 2021 06:29:42 -0400 X-MC-Unique: Bf_zn-PyNzOiOU3b_Cx9xw-1 Received: by mail-lj1-f199.google.com with SMTP id n17-20020a2e8791000000b0021896c29706so310636lji.12 for ; Wed, 03 Nov 2021 03:29:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kIU9yhsiKGmGeaUzgvYqm4XISi2RQdCmf3qI8MSkygM=; b=CM66i7TgOszytSSlDxPJdI25Ghl8WNIs8xVlRh4NZ1UbiVHf8lMvX+FKshJHIpCjWM TaZq4OIrmGZJuSUtMc6SZWipTLADtFCobvXR3s+RDEOLIlKtjSp4nGvqk/7EqD3UYnw1 AikIIKJ+RGssqrHyeSDB2NZ+nUy2tf6O4d/b7ZgQmU/g+Ar82b8u1HDPbVHZnwtGMAjM g4tsaoiFdfP7y/xFo+LJEyO3kMCwzlyX+OrssYXy11P4shLDhoPe1dbAo0cwZ19IoqGc jhBBdoIt27y+rzV79G/+iHniyhyQEUz6dt05PlQNSnwuiFqu7kgCJX61tMfPgDUd7ew1 fcKA== X-Gm-Message-State: AOAM530EPkk5/09zbPR6rFyj8ekBtgrEAhCCH+dwcB71a03DM90xf/A5 Mt16gDP/ihSOyQx1bbaiR4iwMt4uDEnhDXNl70hNBX/nlsua1njWEwQeK3nJ87McgV16e/Y6lGP 6+MX7Z8feRRbqvd0bT6k= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr40193126lfu.575.1635935381147; Wed, 03 Nov 2021 03:29:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTDq6eBcTpMQt71oQo8C4f19tgXx3hdchaKdoeQftcucZoSwn0MK0ztO6uliTmQe/AeLyXmM4wNtvUSPYoRSE= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr40193112lfu.575.1635935380964; Wed, 03 Nov 2021 03:29:40 -0700 (PDT) MIME-Version: 1.0 References: <20210922122920.34759-1-david.hunt@intel.com> <20210923110213.21350-1-david.hunt@intel.com> <20210923110213.21350-2-david.hunt@intel.com> <386dde71-4d62-f48e-fef8-d24dae6244ea@intel.com> In-Reply-To: <386dde71-4d62-f48e-fef8-d24dae6244ea@intel.com> From: David Marchand Date: Wed, 3 Nov 2021 11:29:29 +0100 Message-ID: To: David Hunt Cc: dev , Bruce Richardson , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask too long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 3, 2021 at 11:27 AM David Hunt wrote: > > >> for (; i >= 0; i--) > >> - if (coremask[i] != '0') > >> + if (coremask[i] != '0') { > >> + RTE_LOG(ERR, EAL, "invalid characters in coremask: [%s]\n", > >> + coremask_orig); > > Nit: capital letter. > > > Many other instances of 'invalid' in this file, will I change them all > to "Invalid", or just this one? Let's be consistent for additions of this patch. Thanks. -- David Marchand