From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, linglix.chen@intel.com, yux.jiang@intel.com
Subject: Re: [PATCH v2] app/test: fix PMD perf test on devices with no socket ID
Date: Mon, 24 Oct 2022 13:37:26 +0200 [thread overview]
Message-ID: <CAJFAV8wSU8nDR=4zzqgxjL1nz17-nxhgbTF-8uVDeJZ2nW3CPQ@mail.gmail.com> (raw)
In-Reply-To: <20221024071214.20980-1-olivier.matz@6wind.com>
On Mon, Oct 24, 2022 at 9:12 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> If the socket ID of a device is unknown, rte_eth_dev_socket_id(portid)
> now returns -1 instead of 0 since commit 7dcd73e37965 ("drivers/bus: set
> device NUMA node to unknown by default").
>
> This change breaks the pmd_perf test on environment where the device
> socket ID is unknown. The test fails with the following error, because
> it does not find a lcore on socket -1:
>
> > No avail lcore to run test
>
> Take the new behavior in account in the pmd_perf test: in this
> environment, the test can now run on any lcore, and not only those from
> socket 0 (this was the old behavior).
>
> Bugzilla ID: 1105
> Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
From the bugzilla comments:
Tested-by: Lingli Chen <linglix.chen@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-10-24 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 8:31 [PATCH] " Olivier Matz
2022-10-24 7:12 ` [PATCH v2] " Olivier Matz
2022-10-24 11:37 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wSU8nDR=4zzqgxjL1nz17-nxhgbTF-8uVDeJZ2nW3CPQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=linglix.chen@intel.com \
--cc=olivier.matz@6wind.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).