* [dpdk-dev] [PATCH] test/lpm: reset total time
@ 2019-10-01 5:23 Honnappa Nagarahalli
2019-10-01 5:32 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
0 siblings, 1 reply; 4+ messages in thread
From: Honnappa Nagarahalli @ 2019-10-01 5:23 UTC (permalink / raw)
To: bruce.richardson, vladimir.medvedkin; +Cc: dev, honnappa.nagarahalli, stable
total_time needs to be reset to measure the cycles for delete API.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Change-Id: I446e4724a9fe2f8ac2cb8f5cc167998d9fc33df8
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_lpm_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index a9f02d983..9fa02f9df 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -937,7 +937,7 @@ test_lpm_perf(void)
(double)total_time / ((double)ITERATIONS * BATCH_SIZE),
(count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
- /* Delete */
+ /* Measure Delete */
status = 0;
begin = rte_rdtsc();
@@ -947,7 +947,7 @@ test_lpm_perf(void)
large_route_table[i].depth);
}
- total_time += rte_rdtsc() - begin;
+ total_time = rte_rdtsc() - begin;
printf("Average LPM Delete: %g cycles\n",
(double)total_time / NUM_ROUTE_ENTRIES);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] test/lpm: reset total time
2019-10-01 5:23 [dpdk-dev] [PATCH] test/lpm: reset total time Honnappa Nagarahalli
@ 2019-10-01 5:32 ` Honnappa Nagarahalli
2019-10-04 11:14 ` Medvedkin, Vladimir
0 siblings, 1 reply; 4+ messages in thread
From: Honnappa Nagarahalli @ 2019-10-01 5:32 UTC (permalink / raw)
To: bruce.richardson, vladimir.medvedkin
Cc: dev, honnappa.nagarahalli, ruifeng.wang, nd, stable
total_time needs to be reset to measure the cycles for delete API.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
v2 - Corrected checkpatch issue
app/test/test_lpm_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index a9f02d983..9fa02f9df 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -937,7 +937,7 @@ test_lpm_perf(void)
(double)total_time / ((double)ITERATIONS * BATCH_SIZE),
(count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
- /* Delete */
+ /* Measure Delete */
status = 0;
begin = rte_rdtsc();
@@ -947,7 +947,7 @@ test_lpm_perf(void)
large_route_table[i].depth);
}
- total_time += rte_rdtsc() - begin;
+ total_time = rte_rdtsc() - begin;
printf("Average LPM Delete: %g cycles\n",
(double)total_time / NUM_ROUTE_ENTRIES);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] test/lpm: reset total time
2019-10-01 5:32 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
@ 2019-10-04 11:14 ` Medvedkin, Vladimir
2019-10-24 8:06 ` [dpdk-dev] [dpdk-stable] " David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Medvedkin, Vladimir @ 2019-10-04 11:14 UTC (permalink / raw)
To: Honnappa Nagarahalli, bruce.richardson; +Cc: dev, ruifeng.wang, nd, stable
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Tested-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 01/10/2019 06:32, Honnappa Nagarahalli wrote:
> total_time needs to be reset to measure the cycles for delete API.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> v2 - Corrected checkpatch issue
>
> app/test/test_lpm_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
> index a9f02d983..9fa02f9df 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -937,7 +937,7 @@ test_lpm_perf(void)
> (double)total_time / ((double)ITERATIONS * BATCH_SIZE),
> (count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
>
> - /* Delete */
> + /* Measure Delete */
> status = 0;
> begin = rte_rdtsc();
>
> @@ -947,7 +947,7 @@ test_lpm_perf(void)
> large_route_table[i].depth);
> }
>
> - total_time += rte_rdtsc() - begin;
> + total_time = rte_rdtsc() - begin;
>
> printf("Average LPM Delete: %g cycles\n",
> (double)total_time / NUM_ROUTE_ENTRIES);
--
Regards,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] test/lpm: reset total time
2019-10-04 11:14 ` Medvedkin, Vladimir
@ 2019-10-24 8:06 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2019-10-24 8:06 UTC (permalink / raw)
To: Medvedkin, Vladimir
Cc: Honnappa Nagarahalli, Bruce Richardson, dev,
Ruifeng Wang (Arm Technology China),
nd, dpdk stable
> On 01/10/2019 06:32, Honnappa Nagarahalli wrote:
> > total_time needs to be reset to measure the cycles for delete API.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Tested-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-24 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 5:23 [dpdk-dev] [PATCH] test/lpm: reset total time Honnappa Nagarahalli
2019-10-01 5:32 ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
2019-10-04 11:14 ` Medvedkin, Vladimir
2019-10-24 8:06 ` [dpdk-dev] [dpdk-stable] " David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).