From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA7945CB3; Fri, 8 Nov 2024 15:39:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AB22433DA; Fri, 8 Nov 2024 15:39:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 132DA4025C for ; Fri, 8 Nov 2024 15:39:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731076762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVWiiolKraPaLU7aeu5WNdJ0UaYh1SwC09O6rKTlL+U=; b=AffE9JYoaByBnkhN73qkIHZbfYffssDvKD0tlNOmIrvilWgneaaOEkZxc/SAErP+JFK7Ba +MyW/UOMuoWRPupNwTk2H7wHFqYgJUI9sWmaQg9roW1g1RQZxGapHi7BIlY9polXZD9BQ+ 1rVSlMFWgFS2tiXfrGbe0jpSfBoaUks= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-u1sVuT7UMnug3RClVpbvxA-1; Fri, 08 Nov 2024 09:39:21 -0500 X-MC-Unique: u1sVuT7UMnug3RClVpbvxA-1 X-Mimecast-MFC-AGG-ID: u1sVuT7UMnug3RClVpbvxA Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539e03bfd4aso1548364e87.1 for ; Fri, 08 Nov 2024 06:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731076760; x=1731681560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVWiiolKraPaLU7aeu5WNdJ0UaYh1SwC09O6rKTlL+U=; b=n89IphejEqynkl71Gr2hbCTWGBHxg0xP9ND5VxOjwr1lcMgfEWLnuycVbbQnQhbMSS QFXKJBexnWWgo88ry7pl2apC51f6STF1gp0YA5jG604bH472BhSNaoIVothMmap6q8BS 5c2GGx7fO3sa4sKzrh82IMAkvTofyrrbais8lRkDb7+NpmCLd2v2Zphn99MhgXqrlomY k5YgvBt0gQE+8gSKi2ekxosPG0tMPjEq63bJSJ35qDZ8UGMD0Is+Q9C7MCS0v6f+Lurr iNxTcHfWB7XOxdO3hevgNNKpFqa1O88kn/wl0nBs2HSNSGIoIjRjtVabj8pd4r75YYam ggcw== X-Gm-Message-State: AOJu0YyGIySeoMIQ2vGRPKJI24v40RkIZV+ahNZal6eBI2xPQP83EzZq xRen8QCAWWs9iKYgM/jPR1//5URq1FeoqGb0de/oypi/LkJ/9uHnxZbe3HJzwrPIYjZW5zUOPD2 RoZbdD0nXtXIn0uerFAYAYSsztA1QZW/0iSwly1bAhg55t1sIiASFdNtfwq6oAefgzWViKJ8N+M +B1rVmBnxXcltDiW0= X-Received: by 2002:a05:651c:b0f:b0:2fb:61d9:d72b with SMTP id 38308e7fff4ca-2ff20152500mr15359901fa.1.1731076759821; Fri, 08 Nov 2024 06:39:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpwJhfkLWOQhBvyK3yrJbdAOTtbkpq8QTLgKPcUIoFsarOBKzJZ6mxogw77UmORjmNWBz001Zs9jHZLJ1YkuQ= X-Received: by 2002:a05:651c:b0f:b0:2fb:61d9:d72b with SMTP id 38308e7fff4ca-2ff20152500mr15359751fa.1.1731076759432; Fri, 08 Nov 2024 06:39:19 -0800 (PST) MIME-Version: 1.0 References: <20231113104550.2138654-1-haijie1@huawei.com> <20241108110404.18317-1-haijie1@huawei.com> In-Reply-To: <20241108110404.18317-1-haijie1@huawei.com> From: David Marchand Date: Fri, 8 Nov 2024 15:39:08 +0100 Message-ID: Subject: Re: [PATCH v5 00/25] To: Jie Hai Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, lihuisong@huawei.com, fengchengwen@huawei.com, huangdengdui@huawei.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dZbmkPWdF7FXn6PgnUwNUhiWqLaR4cmMYBelFDg8S9g_1731076760 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 8, 2024 at 12:15=E2=80=AFPM Jie Hai wrote: > > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. > > This patchset replaces strtok with strtok_r in app, example, lib > and drivers. And adds check for use of strtok in checkpatches.sh. > > -- > v5: > 1. remove CC stable for some patch. > 2. replace strtok for all files. In case you did not notice, including rte_os_shim.h in examples breaks compilation. Too late for taking in rc2, I may consider in rc3 if the series is fixed by then. Thanks. --=20 David Marchand