From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 659C043D06; Wed, 20 Mar 2024 18:41:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5724940ED3; Wed, 20 Mar 2024 18:41:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D2F440A6F for ; Wed, 20 Mar 2024 18:41:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710956507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zs6NtFZCDaHbOZDLS5rkBMzAKH9JxChfYrdYl9j18AA=; b=UYjtnW2drnHp7TjOco1gTKPmxJMeDNL68Kl5rezFRLKxI7/YvIphtxnwJlafHK5WWqo5fI 1bnbtEwwY0KWt7pQyf2h0Tr3CmmOKS002E5OA3IqIIGCMVld3JZcGjlBkkgagFQcKo5gd/ oNYipO4oYFHeNACr6LqSUqkg0S3ihgk= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-BKGa-mbcOY6qvVqGGEivFg-1; Wed, 20 Mar 2024 13:41:43 -0400 X-MC-Unique: BKGa-mbcOY6qvVqGGEivFg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5158b914065so115955e87.1 for ; Wed, 20 Mar 2024 10:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710956502; x=1711561302; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zs6NtFZCDaHbOZDLS5rkBMzAKH9JxChfYrdYl9j18AA=; b=R5JzZctBr78zb6ASb8/pf2vSXG5Zd9Gmt7vNkPj5D4n0uJvETrfWVfriNT8+PimZkG OjCwonGYXCgQ9/N6H9AIHETuxK/y7uvoqVSwGlVcfbPbJ/OceiyAXQpq4eYDtIoparJH 4CA9iRDMnevjRmKHUkiOSTQN6S+t/6ugfACQ2yVuKdXcGMlzZLOzhxZrNVFWp+Q3xWSp jIE07IrkDIXECbEcilH9ViyRLHP4mF1hG+CrUcSuKseqYY6S2VAxoFZP5FcQOBdERld5 S931hdP9RIZ2wGQCrU8403gVHYhwWOoKnWyGhXwuXKjjahXfW2NDl8GSjKjlwlokWvmk vLIA== X-Gm-Message-State: AOJu0Ywk+aO/0JXAfDTfZ7Sk1HpqnVj26kruYDxqeSV+JdIa1xgrAQcU jNAJ0/F6iWCpP1hkJ7RVYrgxVQTgy1R+2MAANrQHUsvF8t2LJRiWFbQvpUaCo6Wfc4QHL9sfyEN eFBDvjC9K34OizDGijSH66//Po/5lTwDEgt9/ipWJ/51PJudJ2e1dvb+y0KTbZEkDXmkz4IovBD gTLJ2wahPwL3V/B7s= X-Received: by 2002:a19:ca04:0:b0:513:d640:ff15 with SMTP id a4-20020a19ca04000000b00513d640ff15mr4211514lfg.28.1710956502176; Wed, 20 Mar 2024 10:41:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuMd0NgLw5aRuckmYNKTUQf3HsXoXySvUqGkyhdxgYIO9yzUy9uVZILIuxVOg1V53VXR1tSEpgzmXNsUGMi0E= X-Received: by 2002:a19:ca04:0:b0:513:d640:ff15 with SMTP id a4-20020a19ca04000000b00513d640ff15mr4211501lfg.28.1710956501871; Wed, 20 Mar 2024 10:41:41 -0700 (PDT) MIME-Version: 1.0 References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 20 Mar 2024 18:41:30 +0100 Message-ID: Subject: Re: [PATCH 00/83] move alignment attribute on types To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Akhil Goyal , Jerin Jacob Kollanukkaran , =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Wed, Mar 20, 2024 at 4:38=E2=80=AFPM Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > and variables is not compatible with MSVC. There is only a single > location accepted by both toolchains. > > After having established this as the conventional standard for lib/* > this series is intended to convert the remainder of the source tree to > use the same location for __rte_aligned(a) and alignas(a) for > consistency. The series looks good to me. We may have some misses because of drivers wrapping in their own stuff, but I am not sure those are fixable (this touches some base drivers..) drivers/common/cnxk/roc_platform.h:#define __plt_aligned __rte_align= ed drivers/common/dpaax/compat.h:#define ____cacheline_aligned __rte_aligned(L1_CACHE_BYTES) drivers/common/cnxk/roc_platform.h:#define __plt_cache_aligned __rte_cache_aligned drivers/net/ena/base/ena_plat_dpdk.h:#define ____cacheline_aligned __rte_cache_aligned drivers/net/gve/base/gve_osdep.h:#define ____cacheline_aligned __rte_cache_aligned I also noticed memif: drivers/net/memif/memif.h:typedef struct __rte_packed __rte_aligned(128) --=20 David Marchand