From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CC8AA0562; Fri, 3 Apr 2020 10:18:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81D781C0D4; Fri, 3 Apr 2020 10:18:17 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 67C621C0D1 for ; Fri, 3 Apr 2020 10:18:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585901895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo0iQ7ZjXs3E7mb+uboJM+8Hl/4SeUqFSrv+Ftnhkc=; b=da+LRVCaN8uNkiISIEOKSU3h5CkfK0i8elYcad+gRtnhX/FFmU/dLbAwTyOLuv2Kfm7HaS +027BO2f9Aq2/jb7B7LJy1cpDG8p+xJCrkymakIOVWgNIsc3q/Mw/JZnPdtg7vbm1HnySU m5S8m0LM8AQJbi+tabNg97AaYVongoQ= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-Sd_3BD--Ova6abAcRMDxHQ-1; Fri, 03 Apr 2020 04:18:14 -0400 X-MC-Unique: Sd_3BD--Ova6abAcRMDxHQ-1 Received: by mail-ua1-f70.google.com with SMTP id 16so2386938uag.13 for ; Fri, 03 Apr 2020 01:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1z2RrotIKTZms/0ENNnT+cYDptZ5taAexqbv+G3WQ4=; b=m7pNDobDS6v4qfhgq2tHcFoC0Gmmr47k8bpuFL63ylDV1CnOyqlokG45PPyiwbgHG3 rdZgszDDwA7g9Cww1FsXJQq/PkG2+hCD8PfaBml0tH8mhDp7NmYpS7ohUVOY69nN9DB/ d7yGHePmNhd6qAedKECIPGc/gDLNwGcCpBc+2iyl4YvJugP68zIHLwjBPdurK+Zewz7O f+Y99JyIRj1giANqhkCqpZI+nuBBbVAJb94shpTrIKlT2rxVXwVlcR6gCN/dZLaD47ZQ mzD93fRlVC98cIzLQefvKNFrAhu/Djw7RbQ/5FQ3F87kE9Hv95TcbykOvGKKpWx6RF6Y uNZA== X-Gm-Message-State: AGi0Pub8mddHRKnapDr0yz7FK+cyTICbQ7G/cfsoIpmywE4napljfEcF /LOx7EcnlYHivNn+2OpFn/uoC2A8dU0mYiGyQhQ+w+sA5u2RAcCfENvY8bveqbpoKmziVt70wwG FjNlzAXaqi0dFlQ0szdQ= X-Received: by 2002:a05:6102:3d4:: with SMTP id n20mr5463847vsq.39.1585901893583; Fri, 03 Apr 2020 01:18:13 -0700 (PDT) X-Google-Smtp-Source: APiQypI53iz/dDPbneSRTaqyJ+UcBNaBU1q3CDVD+VRRq9Gm9VZkuBbAhAQL7p8YyvjNABZaPAvOt9xoGYmTTfJvXCs= X-Received: by 2002:a05:6102:3d4:: with SMTP id n20mr5463835vsq.39.1585901893265; Fri, 03 Apr 2020 01:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20200402183253.866-1-jerinjacobk@gmail.com> In-Reply-To: From: David Marchand Date: Fri, 3 Apr 2020 10:18:02 +0200 Message-ID: To: Pavan Nikhilesh Bhagavatula , Bruce Richardson Cc: Jerin Jacob , Thomas Monjalon , Ferruh Yigit , dev , Neil Horman X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula wrote: > > > wrote: > >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob > >wrote: > >> - You can still find traces in meson files. > >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE > >> '^((app|drivers|lib)/meson.build|examples/)' > >> app/test/meson.build > >> drivers/net/e1000/base/meson.build > >> drivers/net/enic/meson.build > >> drivers/net/i40e/base/meson.build > >> drivers/net/i40e/meson.build > >> drivers/net/ixgbe/base/meson.build > >> drivers/net/octeontx/base/meson.build > >> drivers/net/qede/base/meson.build > >> drivers/net/sfc/base/meson.build > >> drivers/net/thunderx/base/meson.build > >> lib/librte_mempool/meson.build > > > >Sorry, those drivers passing directly the cflag were special cases. > > Yup. Mostly base static libs. Actually, how about something like this in drivers/meson.build ? Bruce, do you see something wrong with this ? on top of Pavan patch: diff --git a/drivers/meson.build b/drivers/meson.build index 987e616ae7..4d8f842ab8 100644 --- a/drivers/meson.build +++ b/drivers/meson.build @@ -20,7 +20,7 @@ dpdk_driver_classes =3D ['common', disabled_drivers =3D run_command(list_dir_globs, get_option('disable_drive= rs'), ).stdout().split() -default_cflags =3D machine_args +default_cflags =3D machine_args + ['-DALLOW_EXPERIMENTAL_API'] if cc.has_argument('-Wno-format-truncation') default_cflags +=3D '-Wno-format-truncation' endif @@ -105,7 +105,6 @@ foreach class:dpdk_driver_classes dpdk_conf.set(config_flag_fmt.format(fmt_name.to_upper()),1) lib_name =3D driver_name_fmt.format(fmt_name) - cflags +=3D '-DALLOW_EXPERIMENTAL_API' dpdk_extra_ldflags +=3D pkgconfig_extra_libs # generate pmdinfo sources by building a temporary Since the base drivers make use of "cflags", it works afaics. > > >This just leaves lib/librte_mempool/meson.build to clean. > > I will clean it up in v3. Along with modifying title and updating doc. > > Doc to be updated are coding styles and release notes right? > Let me know if anything else need to be added to the list. lgtm, thanks. --=20 David Marchand