From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 933A8A04DE; Fri, 30 Oct 2020 16:33:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BD88C9B6; Fri, 30 Oct 2020 16:33:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 3B154C9AC for ; Fri, 30 Oct 2020 16:33:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604072015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2nyzc4j3MGpTJVinLvmWK4OlhONn5zbUIHbV4rWzP1c=; b=at9+aNysVZXFrZVrVZrd365xPVD5FzB1NMBJsjYQA8POj8PcO3eqbthNTJWvFg4YJV5oOZ BNH2VYfveKtB9skAGxKXx0g7af4yedRrqYnY0+xBCFlaMHtkgihz7Nf0F8xukEk4XupSDZ 06GlAJX7DwLHY0XP3pEThcFfekFNSEE= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-t4CNggRfMGWIn9jM_vQVVw-1; Fri, 30 Oct 2020 11:33:28 -0400 X-MC-Unique: t4CNggRfMGWIn9jM_vQVVw-1 Received: by mail-vk1-f200.google.com with SMTP id p199so1734968vkp.23 for ; Fri, 30 Oct 2020 08:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2nyzc4j3MGpTJVinLvmWK4OlhONn5zbUIHbV4rWzP1c=; b=PW/AbyXdXVZEmSuOOYk7woYaW64X5faBc5/VQagKYEXV5pcQM+m8giucPu2fi90GEt H/MfwjDZBr2Cviw/to+K2AQsWEFO+Afvn36apBOqFWICJ9xUBfvZtquI1wzTRi5GcoFn JnfSx1VtavFcxhWgN3WA92aPb2wUodOfSpHKWR/7kpyPEyWi7iOe0fl2IZaZIvwKYYPE DZoX3v0hqRMiBMbOpXr8TCvkd1Hl3Efr8BECWmYSVeLzerWVxgUoIGmoDTqgFtWjX6N2 FeIV1pewQ2LrBQTIO7Mm+gWSxtJO1J3y3xuiDaF/r8/M+D2ReZg+YIMaKr6acUoRR928 be8w== X-Gm-Message-State: AOAM532rycFRKgRBOCn4dhTcOP75pzxyqR/BVEZR8RIAnXdlsonbMDcR FD9DkzsrwlfKeyKFvgxz9VMMc2AWxy/bR4Wofkw6gYDlNbHktOim6BxafJAiUpuvosA+WWaWgb7 4Xzb7TYpZL0kP1CEepXw= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr7915708vsa.27.1604072006599; Fri, 30 Oct 2020 08:33:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjQ5HpHXqS+MFXZ8cyIvgBpjPv9kMUWFYpiHqMWpHUwFk/rowA99SbgxZm33MeHIHKrNdiwnE0534obflpg5E= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr7915681vsa.27.1604072006348; Fri, 30 Oct 2020 08:33:26 -0700 (PDT) MIME-Version: 1.0 References: <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <1604051021-26699-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Fri, 30 Oct 2020 16:33:15 +0100 Message-ID: To: "McDaniel, Timothy" Cc: Jerin Jacob , dpdk-dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 4:25 PM McDaniel, Timothy wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Friday, October 30, 2020 9:22 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Carrillo, Erik G ; Eads, > > Gage ; Van Haaren, Harry > > ; Jerin Jacob ; Thomas > > Monjalon > > Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD > > > > On Fri, Oct 30, 2020 at 3:19 PM Timothy McDaniel > > wrote: > > > > > > > > Timothy McDaniel (23): > > > event/dlb2: add documentation and meson build infrastructure > > > event/dlb2: add dynamic logging > > > event/dlb2: add private data structures and constants > > > event/dlb2: add definitions shared with LKM or shared code > > > event/dlb2: add inline functions > > > event/dlb2: add eventdev probe > > > > There is build error with clang and static build here. > > Please send the next version with fix. > > > > meson -Dexamples=3Dl3fwd --buildtype=3Ddebugoptimized --werror > > --default-library=3Dstatic /export/dpdk-next-eventdev/devtools/.. > > ./build-clang-static > > The Meson build system > > Version: 0.55.3 > > Source dir: /export/dpdk-next-eventdev > > Build dir: /export/dpdk-next-eventdev/build-clang-static > > Build type: native build > > Program cat found: YES > > Using 'PKG_CONFIG_PATH' from environment with value: '' > > Using 'PKG_CONFIG_PATH' from environment with value: '' > > Project name: DPDK > > Project version: 20.11.0-rc1 > > Using 'CC' from environment with value: 'ccache clang' > > Using 'CFLAGS' from environment with value: '' > > Using 'LDFLAGS' from environment with value: '' > > Using 'CPPFLAGS' from environment with value: '' > > Using 'CC' from environment with value: 'ccache clang' > > Using 'CFLAGS' from environment with value: '' > > Using 'LDFLAGS' from environment with value: '' > > Using 'CPPFLAGS' from environment with value: '' > > C compiler for the host machine: ccache clang (clang 10.0.1 "clang > > version 10.0.1 ") > > C linker for the host machine: clang ld.bfd 2.35.1 > > Host machine cpu family: x86_64 > > Host machine cpu: x86_64 > > Program pkg-config found: YES > > Program gen-pmdinfo-cfile.sh found: YES > > Program list-dir-globs.py found: YES > > Program check-symbols.sh found: YES > > Program options-ibverbs-static.sh found: YES > > Program binutils-avx512-check.sh found: YES > > Program python3 found: YES (/usr/bin/python) > > > > > > > > ccache clang -Idrivers/libtmp_rte_event_dlb2.a.p -Idrivers > > -I../drivers -Idrivers/event/dlb2 -I../drivers/event/dlb2 > > -Ilib/librte_eventdev -I../lib/librte_eventdev -I. -I.. -Iconfig > > -I../config -Ilib/librte_eal/include -I../lib/librte_eal/i > > nclude -Ilib/librte_eal/linux/include > > -I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include > > -I../lib/librte_eal/x86/include -Ilib/librte_eal/common > > -I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal > > -Ilib/librte_kvargs > > -I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics > > -Ilib/librte_telemetry -I../lib/librte_telemetry -Ilib/librte_ring > > -I../lib/librte_ring -Ilib/librte_ethdev -I../lib/librte_ethdev > > -Ilib/librte_net -I../lib/librte_net -Il > > ib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool > > -I../lib/librte_mempool -Ilib/librte_meter -I../lib/librte_meter > > -Ilib/librte_hash -I../lib/librte_hash -Ilib/librte_rcu > > -I../lib/librte_rcu -Ilib/librte_timer -I../lib/librte_timer - > > Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_pci > > -I../lib/librte_pci -Idrivers/bus/pci -I../drivers/bus/pci > > -I../drivers/bus/pci/linux -Xclang -fcolor-diagnostics -pipe > > -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 > > -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated > > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef - > > Wwrite-strings -Wno-address-of-packed-member > > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative > > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ > > drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_main.c.o -MF > > drivers/l > > ibtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_main.c.o.d -o > > drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_main.c.o -c > > ../drivers/event/dlb2/pf/dlb2_main.c > > In file included from ../drivers/event/dlb2/pf/dlb2_main.c:22: > > ../drivers/event/dlb2/pf/../dlb2_inline_fns.h:41:2: error: use of > > unknown builtin '__builtin_ia32_movntdq' > > [-Wimplicit-function-declaration] > > __builtin_ia32_movntdq((__v2di *)pp_addr, (__v2di)src_data0); > > ^ > > ../drivers/event/dlb2/pf/../dlb2_inline_fns.h:41:2: note: did you mean > > '__builtin_ia32_movntq'? > > /usr/lib/clang/10.0.1/include/xmmintrin.h:2122:3: note: > > '__builtin_ia32_movntq' declared here > > __builtin_ia32_movntq(__p, __a); > > > > [2010/2491] Compiling C object > > drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_pf.c.o > > FAILED: drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_pf.c.o > > ccache clang -Idrivers/libtmp_rte_event_dlb2.a.p -Idrivers > > -I../drivers -Idrivers/event/dlb2 -I../drivers/event/dlb2 > > -Ilib/librte_eventdev -I../lib/librte_eventdev -I. -I.. -Iconfig > > -I../config -Ilib/librte_eal/include -I../lib/librte_eal/i > > nclude -Ilib/librte_eal/linux/include > > -I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include > > -I../lib/librte_eal/x86/include -Ilib/librte_eal/common > > -I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal > > -Ilib/librte_kvargs > > -I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics > > -Ilib/librte_telemetry -I../lib/librte_telemetry -Ilib/librte_ring > > -I../lib/librte_ring -Ilib/librte_ethdev -I../lib/librte_ethdev > > -Ilib/librte_net -I../lib/librte_net -Il > > ib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool > > -I../lib/librte_mempool -Ilib/librte_meter -I../lib/librte_meter > > -Ilib/librte_hash -I../lib/librte_hash -Ilib/librte_rcu > > -I../lib/librte_rcu -Ilib/librte_timer -I../lib/librte_timer - > > Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_pci > > -I../lib/librte_pci -Idrivers/bus/pci -I../drivers/bus/pci > > -I../drivers/bus/pci/linux -Xclang -fcolor-diagnostics -pipe > > -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 > > -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated > > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef - > > Wwrite-strings -Wno-address-of-packed-member > > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative > > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ > > drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_pf.c.o -MF > > drivers/lib > > tmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_pf.c.o.d -o > > drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_pf_dlb2_pf.c.o -c > > ../drivers/event/dlb2/pf/dlb2_pf.c > > In file included from ../drivers/event/dlb2/pf/dlb2_pf.c:35: > > ../drivers/event/dlb2/pf/../dlb2_inline_fns.h:41:2: error: use of > > unknown builtin '__builtin_ia32_movntdq' > > [-Wimplicit-function-declaration] > > __builtin_ia32_movntdq((__v2di *)pp_addr, (__v2di)src_data0); > > Not sure why this builds for me, but I do not see this error. Reproduced the same error on fc31. $ clang --version clang version 9.0.1 (Fedora 9.0.1-2.fc31) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin $ ./devtools/test-meson-builds.sh ... FAILED: drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2.c.o ccache clang -Idrivers/a715181@@tmp_rte_event_dlb2@sta -Idrivers -I../../dpdk/drivers -Idrivers/event/dlb2 -I../../dpdk/drivers/event/dlb2 -Ilib/librte_eventdev -I../../dpdk/lib/librte_eventdev -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -Ilib/librte_ring -I../../dpdk/lib/librte_ring -Ilib/librte_ethdev -I../../dpdk/lib/librte_ethdev -Ilib/librte_net -I../../dpdk/lib/librte_net -Ilib/librte_mbuf -I../../dpdk/lib/librte_mbuf -Ilib/librte_mempool -I../../dpdk/lib/librte_mempool -Ilib/librte_meter -I../../dpdk/lib/librte_meter -Ilib/librte_hash -I../../dpdk/lib/librte_hash -Ilib/librte_rcu -I../../dpdk/lib/librte_rcu -Ilib/librte_timer -I../../dpdk/lib/librte_timer -Ilib/librte_cryptodev -I../../dpdk/lib/librte_cryptodev -Ilib/librte_pci -I../../dpdk/lib/librte_pci -Idrivers/bus/pci -I../../dpdk/drivers/bus/pci -I../../dpdk/drivers/bus/pci/linux -I/home/dmarchan/intel-ipsec-mb/install/include -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2.c.o' -MF 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2.c.o.d' -o 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2.c.o' -c ../../dpdk/drivers/event/dlb2/dlb2.c In file included from ../../dpdk/drivers/event/dlb2/dlb2.c:35: ../../dpdk/drivers/event/dlb2/dlb2_inline_fns.h:41:2: error: use of unknown builtin '__builtin_ia32_movntdq' [-Wimplicit-function-declaration] __builtin_ia32_movntdq((__v2di *)pp_addr, (__v2di)src_data0); ^ ../../dpdk/drivers/event/dlb2/dlb2_inline_fns.h:41:2: note: did you mean '__builtin_ia32_movntq'? /usr/lib64/clang/9.0.1/include/xmmintrin.h:2122:3: note: '__builtin_ia32_movntq' declared here __builtin_ia32_movntq(__p, __a); ^ 1 error generated. FAILED: drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2_selftest.c.= o ccache clang -Idrivers/a715181@@tmp_rte_event_dlb2@sta -Idrivers -I../../dpdk/drivers -Idrivers/event/dlb2 -I../../dpdk/drivers/event/dlb2 -Ilib/librte_eventdev -I../../dpdk/lib/librte_eventdev -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -Ilib/librte_ring -I../../dpdk/lib/librte_ring -Ilib/librte_ethdev -I../../dpdk/lib/librte_ethdev -Ilib/librte_net -I../../dpdk/lib/librte_net -Ilib/librte_mbuf -I../../dpdk/lib/librte_mbuf -Ilib/librte_mempool -I../../dpdk/lib/librte_mempool -Ilib/librte_meter -I../../dpdk/lib/librte_meter -Ilib/librte_hash -I../../dpdk/lib/librte_hash -Ilib/librte_rcu -I../../dpdk/lib/librte_rcu -Ilib/librte_timer -I../../dpdk/lib/librte_timer -Ilib/librte_cryptodev -I../../dpdk/lib/librte_cryptodev -Ilib/librte_pci -I../../dpdk/lib/librte_pci -Idrivers/bus/pci -I../../dpdk/drivers/bus/pci -I../../dpdk/drivers/bus/pci/linux -I/home/dmarchan/intel-ipsec-mb/install/include -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2_selftest.c.o' -MF 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2_selftest.c.o.d= ' -o 'drivers/a715181@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2_selftest.c.o' -c ../../dpdk/drivers/event/dlb2/dlb2_selftest.c ../../dpdk/drivers/event/dlb2/dlb2_selftest.c:139:1: error: unused function 'create_ordered_qids' [-Werror,-Wunused-function] create_ordered_qids(struct test *t, int num_qids) ^ ../../dpdk/drivers/event/dlb2/dlb2_selftest.c:145:1: error: unused function 'create_unordered_qids' [-Werror,-Wunused-function] create_unordered_qids(struct test *t, int num_qids) ^ ../../dpdk/drivers/event/dlb2/dlb2_selftest.c:151:1: error: unused function 'create_directed_qids' [-Werror,-Wunused-function] create_directed_qids(struct test *t, int num_qids, const uint8_t ports[]) ^ 3 errors generated. I also see a different issue with RHEL 7 gcc: Found ninja-1.7.2 at /usr/bin/ninja-build [1908/2413] Compiling C object 'drivers/drivers@@tmp_rte_event_dlb2@sta/event_dlb2_dlb2.c.o'. ../drivers/event/dlb2/dlb2.c: In function =E2=80=98dlb2_hw_create_ldb_port= =E2=80=99: ../drivers/event/dlb2/dlb2.c:1091:9: warning: missing braces around initializer [-Wmissing-braces] struct dlb2_create_ldb_port_args cfg =3D {0}; ^ ../drivers/event/dlb2/dlb2.c:1091:9: warning: (near initialization for =E2=80=98cfg.response=E2=80=99) [-Wmissing-braces] ../drivers/event/dlb2/dlb2.c: In function =E2=80=98dlb2_hw_create_dir_port= =E2=80=99: ../drivers/event/dlb2/dlb2.c:1263:9: warning: missing braces around initializer [-Wmissing-braces] struct dlb2_create_dir_port_args cfg =3D {0}; ^ ../drivers/event/dlb2/dlb2.c:1263:9: warning: (near initialization for =E2=80=98cfg.response=E2=80=99) [-Wmissing-braces] --=20 David Marchand