From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09AC143070; Tue, 15 Aug 2023 15:21:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2B6241611; Tue, 15 Aug 2023 15:21:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5CBD740F17 for ; Tue, 15 Aug 2023 15:21:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692105698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y3DgGa0GepNg5swaTxXKyy40lNWu9cQwsOlKENGlY2I=; b=SemGla17e3DUbmHiWDMHCUZF3RMKRzAdt3fzc8kUY4dB+HNj48u+qbB8zY7XJ3qvrQtkGs EYF2Ok81szywta55JPeDr3AQEBjGO6MG8i4+WrGCVPR8ITeivo+ZVrtXqY4uyIhIJFSi8x aAj8KNye4BCzSVlOmJnJnDIhp8/d32k= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-Ffw9izERNyKuMbpczIwWoQ-1; Tue, 15 Aug 2023 09:21:37 -0400 X-MC-Unique: Ffw9izERNyKuMbpczIwWoQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4f3932e595dso5331915e87.1 for ; Tue, 15 Aug 2023 06:21:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692105696; x=1692710496; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y3DgGa0GepNg5swaTxXKyy40lNWu9cQwsOlKENGlY2I=; b=RMA+gmqTUMdD7fXAOsQeDi2rAZqOkWNDhOhyN56EB3dgISFa6+eG9yZWZvWt9yVSvd I9EOKnC4ug0NCppcu8bzYdPjsvTdxSEsX1Pcb0ZbZH35eYjMaPH/gWuYOvQT1uvF/VBL fWQAuK71TA49wAdU2eS6EblLHBcayixGKxrnawTtDse2OE5Ti1XGK2zy0vqcjIGYXWMI 2raD+kNwJ6ZGYPkj+DKtcEbaF4Z/R4V2dhYqH5eiI8sgyjCQyD2fmAWsjJffT1dmOvJH BQrYuPLkE/FZ3Z7IAFsqZC6hF4v4uc2wbVs5/WbDZU7JNqSCnMpCBDzlhMDP/HVqrZoN qA/w== X-Gm-Message-State: AOJu0Yw1p//yQGfVNSbSjXU2kKJT3ZcJduovJ0iavvlS5MH/OGp1JfWs OW+oZb7U3oJW33i9Gxf7rbUwwMjFb0wM5eGIpb5A2CkVrH0SypDq+ahsPphvPj1eG3jE/HiXWMx 2jXTHDIeMQqD7vVH/NSc= X-Received: by 2002:a05:6512:3090:b0:4fd:fadb:e6e4 with SMTP id z16-20020a056512309000b004fdfadbe6e4mr9879328lfd.69.1692105695857; Tue, 15 Aug 2023 06:21:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+k8FfPI5UMAlDaP1aJ3W8TVmC7rizs3HMEl5rbUCNa7WukaUNa34Z0nyem/5pd+pw2dU8NRxTTu//Q31NYd8= X-Received: by 2002:a05:6512:3090:b0:4fd:fadb:e6e4 with SMTP id z16-20020a056512309000b004fdfadbe6e4mr9879312lfd.69.1692105695533; Tue, 15 Aug 2023 06:21:35 -0700 (PDT) MIME-Version: 1.0 References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 15 Aug 2023 15:21:23 +0200 Message-ID: Subject: Re: [PATCH v4 4/4] build: enable MSVC specific compiler options To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Fri, Aug 11, 2023 at 8:24=E2=80=AFPM Tyler Retzlaff wrote: > > * Enable optional use of C11 atomics support. > * Enable use of C23 typeof operator. > * Explicitly force intrinsics when building with MSVC. > * Disable MSVC C runtime checks. > > Signed-off-by: Tyler Retzlaff > --- > config/meson.build | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/config/meson.build b/config/meson.build > index 821a1c3..839057a 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -27,6 +27,14 @@ dpdk_conf.set('RTE_EXEC_ENV_' + exec_env.to_upper(), 1= ) > is_ms_compiler =3D is_windows and (cc.get_id() =3D=3D 'msvc') > is_ms_linker =3D is_windows and (cc.get_id() =3D=3D 'clang' or is_ms_com= piler) > > +# MS compiler (except x86) does not support inline assembly One last (hopefully) small question, what does this comment apply to? Forced use of intrinsics? > +if is_ms_compiler > + dpdk_conf.set('_CRT_SECURE_NO_WARNINGS', 1) > + dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > + add_project_arguments('/experimental:c11atomics', language: 'c') > + add_project_arguments('/d1experimental:typeof', language: 'c') > +endif > + > # set the major version, which might be used by drivers and libraries > # depending on the configuration options > pver =3D meson.project_version().split('.') > -- > 1.8.3.1 > --=20 David Marchand