From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DA1AA034C; Thu, 28 Apr 2022 14:13:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 328D34281B; Thu, 28 Apr 2022 14:13:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5642142819 for ; Thu, 28 Apr 2022 14:13:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651147984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=30Q06whOwFtqSbOP1jVr1aPL2XMVwvXxkP2FZTtyyAk=; b=Pr6j6CudT61WZWEptJj7mb2HIe++2rVzFGSju384GaeKEPtDxWTCzgkWwQUlgqh04x6Gux KDZxXVh3o2cL46ZSn52w482pOODh7MMlNhzUBhNG1+q6iyIiIyzlSU6OmcjCMaqnM8DpCL ManFBSqJT5ZINdWrQ0UbWG4zAtlKfDw= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-138-_2Bbg4zlOv6BQeAl3kpA2A-1; Thu, 28 Apr 2022 08:13:03 -0400 X-MC-Unique: _2Bbg4zlOv6BQeAl3kpA2A-1 Received: by mail-lj1-f198.google.com with SMTP id d5-20020a05651c088500b0024db8b6a445so1769851ljq.11 for ; Thu, 28 Apr 2022 05:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30Q06whOwFtqSbOP1jVr1aPL2XMVwvXxkP2FZTtyyAk=; b=N2UVXyvgezWwisXv9Pxy0hMStg2dE+SrnRZmExm/bI2fZE0XsoLvAMWBsZC14IIMWu RaIwPMbqyMYBk00xkgxUTpR9Go1knyWn/00/nUW+TmfO5iXJGImtkQ4WxCUKOJifXkqt uuwa1LoSDYVmFnS5Y/8G5opQ6xjVGb4yAf8bdIJu5yAfgAT32MXU1jRjWF8ACvpWEeyh A1NCKMzOXiBP0y60UcZCktabx8lzkr86d+TCVQ0FjZkiDvAUOpjrvOx4R/PXKGf7KbL7 n62SBtnAsoA2VMXduSt/guiZ+cQZDFyjdzdobLsSLWDQAs2eCNhRlRWx7kzeO2LoGCTg pZ7Q== X-Gm-Message-State: AOAM531HnzndTclR2v3RrQS5N3oKKYHVsVA9y5/wdstSrjDyasg1H8Nh vWcE8sz2Ke3EXAxkjMw3NWBcpWEpGwMc3HRVMfEf2XzcqFbu4gvN/LIrUTA/4BklfQd8/TP7UyF aPOZ+JSacRyMN9IqrmLA= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr23812406lfu.575.1651147981801; Thu, 28 Apr 2022 05:13:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/XfvPiqKlZ+30WQHtZimABcizUNUVuiYVFAI3TEWYlhLyL4Xf0e7CUAdTDMiKnsXRD1Cr0fD/9guwQ7cdx38= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr23812397lfu.575.1651147981616; Thu, 28 Apr 2022 05:13:01 -0700 (PDT) MIME-Version: 1.0 References: <20220324145343.24485-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 28 Apr 2022 14:12:50 +0200 Message-ID: Subject: Re: [PATCH] ci: run more checks in private repositories To: Aaron Conole , Thomas Monjalon Cc: dev , Michael Santana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 25, 2022 at 3:32 PM Aaron Conole wrote: > David Marchand writes: > > > Though devtools/checkpatches.sh is run as part of our CI, some other > > (not well known) checks could help when run in private repositories > > before submitting to the mailing list and even when run from the > > ovsrobot. > > > > Most of them require a git history or checked sources to run. > > And I can't guarantee there won't be false positives. > > > > Add a new job just for those checks so that it won't block compilation > > tests in other jobs. > > > > Signed-off-by: David Marchand > > --- > > Looks good to me. The extra fetches shouldn't take too long (since we > refresh main branch weekly to the robot repository). The checks look > good - and since it's part of the same build workflow, it will be > reported in the same place (and hopefully in a readable form). Thanks for the review. Thomas expressed a concern that the check-git-log.sh script has too many false positives. I will respin removing this check. -- David Marchand