From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02FDEA0C43; Tue, 19 Oct 2021 11:52:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B78040683; Tue, 19 Oct 2021 11:52:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 548F94003E for ; Tue, 19 Oct 2021 11:52:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634637166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=obvjYWxyFgz6pVLVY/qL+sAhyxigLAYtORnimFjwq7M=; b=XqZqHGpt+DcLnspE9b4pT6NeZBb9+9A52cPvpvOjMKhM8jGS2F5ZTHJ5F4ZH5/JnkkOxQU IrVRVmwnIVfguBhn8wej7zg4YW9H4goaF43RKy6IM/Mbm3XNj1QD4XBLVvZtYqKJZdUDW8 P+zYJVc/fdLSJ3JkWetpjxDwD8MGc0k= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-FmWE-_lEPQ-rL26klmpOUw-1; Tue, 19 Oct 2021 05:52:45 -0400 X-MC-Unique: FmWE-_lEPQ-rL26klmpOUw-1 Received: by mail-lj1-f199.google.com with SMTP id w9-20020a2e9989000000b00210af61ebbdso689809lji.2 for ; Tue, 19 Oct 2021 02:52:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=obvjYWxyFgz6pVLVY/qL+sAhyxigLAYtORnimFjwq7M=; b=jZluAxVGcL/2IbFwnXgjYerafzwkI7FG1r9hN5F8nuVEuPwr32yVu1gAigur9GXpkr Pk6YKVVPIxIFGmuMqi2B/AqqEYP8HxJyyeqpJM/9YkaXg1qewImbcDSE8p8f22aXY5rD oL69toYhkH1uVPJLn7Il9+PLtbK5egdQdlbHQ9t1lMxuA0OYwIOZ7101cwkAlkTyFDHN pQ3kz1aLU32O9MAb9znqtfTWlkjlzILmFDCFdjzFBgUpMOQqbZJDYtjEhU5g/zLzE18t gSzfz+T/N9waTI7MbT7eqA8ULAXNTpnu4gaUSi50HldXm5MWDSzWYRhJfO2XUUHqo6W8 1p+g== X-Gm-Message-State: AOAM533DM3Hea2tTiB4tgnwdCguqUGblV2k7xoXCdQIP1KivILZGcojb CjK0LJH0Y1Xw9CqDEtQeJ/qBOwS/WHYcLlM+TOzgUbRzLaJjaxBJ/kifh6SNm6ziq4nTGdWOJr9 ZEACD0Uu2J3W8qZzsfwo= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr5161524lfe.217.1634637163672; Tue, 19 Oct 2021 02:52:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxK/sJLD+evsR02p7w4mXdMzZQU/oINZXfJveZwO0hl+3GqAZEpf0sePm9gnl/Sio0QtNytyBO/0ft5JYRGc8k= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr5161515lfe.217.1634637163482; Tue, 19 Oct 2021 02:52:43 -0700 (PDT) MIME-Version: 1.0 References: <20211018170136.5189-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 19 Oct 2021 11:52:32 +0200 Message-ID: To: Bruce Richardson Cc: dev , Aaron Conole , Brandon Lo Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test: rely on EAL detection for core list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 7:53 PM Bruce Richardson wrote: > > On Mon, Oct 18, 2021 at 07:01:36PM +0200, David Marchand wrote: > > Cores count has a direct impact on the time needed to complete unit > > tests. > > > > Currently, the core list used for unit test is enforced to "all cores on > > the system" with no way for (CI) users to adapt it. > > On the other hand, EAL default behavior (when no -c/-l option gets passed) > > is to start threads on as many cores available in the process cpu > > affinity. > > > > Remove logic from meson: users can then select where to run the tests by > > either running meson with a custom cpu affinity (using taskset/cpuset > > depending on OS) or by passing a --test-args option to meson. > > > > Example: > > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > > > Signed-off-by: David Marchand > > --- > > I wanted to post this as a RFC, but now, I wonder if all CI test RFC > > patches, so sending as a normal patch. > > > > --- > I really like this idea! Patch looks good other than it needs some doc > changes. Wdyt of: diff --git a/doc/guides/prog_guide/meson_ut.rst b/doc/guides/prog_guide/meson_ut.rst index fff88655dd..d35e0577c8 100644 --- a/doc/guides/prog_guide/meson_ut.rst +++ b/doc/guides/prog_guide/meson_ut.rst @@ -47,9 +47,15 @@ Arguments of ``test()`` that can be provided in meson.build are as below: * ``is_parallel`` is used to run test case either in parallel or non-parallel mode. * ``timeout`` is used to specify the timeout of test case. -* ``args`` is used to specify test specific parameters. +* ``args`` is used to specify test specific parameters (see note below). * ``env`` is used to specify test specific environment parameters. +Note: the content of meson ``--test-args`` option and the content of ``args`` +are appended when invoking the DPDK test binary. +Because of this, it is recommended not to set any default coremask or memory +configuration in per test ``args`` and rather let users select what best fits +their environment. If a test can't run, then it should be skipped, as described +below. Dealing with skipped test cases ------------------------------- -- David Marchand