From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C675CA046B
	for <public@inbox.dpdk.org>; Wed, 26 Jun 2019 14:04:05 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 90CA52BE5;
	Wed, 26 Jun 2019 14:04:01 +0200 (CEST)
Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com
 [209.85.221.196]) by dpdk.org (Postfix) with ESMTP id 4ABD5DED
 for <dev@dpdk.org>; Wed, 26 Jun 2019 14:03:59 +0200 (CEST)
Received: by mail-vk1-f196.google.com with SMTP id f68so366648vkf.5
 for <dev@dpdk.org>; Wed, 26 Jun 2019 05:03:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=57tRD/mEe5PLup4dwX5nvZAktmPfAryMVSanMfS7z44=;
 b=RaNzo99T1m6qevM4n9xvjH2sxY3GwatWUjOU7Wy0eQMhIpzQ2aMt8LYnMS4Q4D0wiq
 1/oIkZe1NlOxlb5hxCYcp7e3LwbaR3AibT8MI+OCRzCSAyrzcQodqKP1PlIBf4Lm8kjF
 2wVPvsWFfxHeXrDE8MmqIDH5fT3CXmmDsSHPgFPNmcpE6Y140UX0V9HfXpRiYoGNV4j/
 mNKCC0nLU6WQ7KNF8p0PrcCTcqsO1sK4PKJuk/5J4aR196qnnI5kjPXvJuWjWxN/snyM
 q4LIp13l3L72hagCv/AoHvwPTQ0Ai750ftoqE3XCE+l6XwXLQcMyBLOm+Qv1BTxrCSpw
 xniw==
X-Gm-Message-State: APjAAAWoiqtDPO8DwcEyF6Jml/iWDmOifBzBHzYkJqt0ctb3CAS1bl9R
 a9Jln4xs280xPjzeVdXxG+B0VzRiuJ5ol/xTYSLLew==
X-Google-Smtp-Source: APXvYqzyQ/C5vheYMfpea7VnBNtNg9YrrhEccRu9bXLQTzinWzFYIIlRbsMMpIRqM+TH/KaFqXT0MrWj0hGMiIdFP3I=
X-Received: by 2002:a1f:144:: with SMTP id 65mr995891vkb.53.1561550638540;
 Wed, 26 Jun 2019 05:03:58 -0700 (PDT)
MIME-Version: 1.0
References: <f4c041a147e3b6b29d70e056653fd3c163e1d4ce.1561477829.git.anatoly.burakov@intel.com>
In-Reply-To: <f4c041a147e3b6b29d70e056653fd3c163e1d4ce.1561477829.git.anatoly.burakov@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 26 Jun 2019 14:03:47 +0200
Message-ID: <CAJFAV8wUdaqBBOZd3-EOXdiFVgDUcVos29vSBmegvmsmWuUjSw@mail.gmail.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, 
 dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/freebsd: fix missing
 write to internal config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov <anatoly.burakov@intel.com>
wrote:

> When init is complete, EAL is supposed to update internal config
> to indicate that initialization is complete. Add missing write.
>
> Fixes: a99c96e96ad3 ("eal: add internal flag of init completed")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  lib/librte_eal/freebsd/eal/eal.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index 4eaa53195..8c399c799 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -566,6 +566,8 @@ rte_eal_mcfg_complete(void)
>         /* ALL shared mem_config related INIT DONE */
>         if (rte_config.process_type == RTE_PROC_PRIMARY)
>                 rte_config.mem_config->magic = RTE_MAGIC;
> +
> +       internal_config.init_complete = 1;
>  }
>
>  /* return non-zero if hugepages are enabled. */
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand