From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 349F8A04B5; Mon, 11 Jan 2021 09:52:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF1B1140CBA; Mon, 11 Jan 2021 09:52:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 2DF2A140CB8 for ; Mon, 11 Jan 2021 09:52:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610355174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wh6VEPm+1XZIK1UVik1tfg7pQK5tgbja+Vm/EyQ8bbM=; b=itAK6WmffGNIZ7l/2H5yNh1GewTe6j0h/ALoM5CFoR3ghxaQXaZZGLQdffu7lHp55UiLs+ 1oex1G2fmIJDGDG81MZbqkTVBUa1wiwuLqzULi5ildykRE1c9tVfgO8PDl/wACZjfIc4Cx CMak3sayXBbqqaXFuHVVJuTl5f7mg6k= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-ZyaIQf8zPsyXgvtF3uhpjw-1; Mon, 11 Jan 2021 03:52:53 -0500 X-MC-Unique: ZyaIQf8zPsyXgvtF3uhpjw-1 Received: by mail-vs1-f69.google.com with SMTP id p14so4340735vsf.8 for ; Mon, 11 Jan 2021 00:52:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wh6VEPm+1XZIK1UVik1tfg7pQK5tgbja+Vm/EyQ8bbM=; b=K0C19XnFEstpIJp2AWVbZQrl/nT8suAYQoT+L05aF3OKLcjdaeBmcI4XO47+rbkR/R 4z2rOlNg9xIncku65LRmJVPe+cfS/+MpzwUPNauC6lPVPpLHvyQbMmY1wRpCka6C58E3 Mud5FIW2+BIOKGByN/g73BFzv+Nt2GOzzw3wWPloZLdWY5ILC84KwKNC74jDqrjvernt opcz3UwBU6kXsAeTxI5AzizzgUyUE1xBr+RuDIF3TdqUh36eZc68G8WWeFfFQTyCgVTu ritdV0LD9/zDyGpRUrOolKmT6Q4nUYehtiEfD0CstWJiyRpEzsUIFguohQzZz+YFwdhI aYUg== X-Gm-Message-State: AOAM5301bXLqG8rbYYgOXfDfnr+Ym+NrswfgzWwcYqFK0N4GoCF+9M9e HaWaqDbheYNXXq0+TIRMXGygXuhzJUxn0Mz4c0yS+CmUdGMYT4J/pCNQSYVjXU74v5KHqhURttc MA+uX0pyMc52Nus8q5Xg= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr11247750uan.53.1610355172735; Mon, 11 Jan 2021 00:52:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCykWHBKuZ1l3H80BFDrasIEnmC7Gs6KX/I17LGPi4nN19cKspFZ2+vEvGJ5Wnt+Sw31sTK447zEtcjEhKELY= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr11247730uan.53.1610355172508; Mon, 11 Jan 2021 00:52:52 -0800 (PST) MIME-Version: 1.0 References: <1604315406-27669-1-git-send-email-liang.j.ma@intel.com> In-Reply-To: From: David Marchand Date: Mon, 11 Jan 2021 09:52:41 +0100 Message-ID: To: "Burakov, Anatoly" Cc: dev , Thomas Monjalon , "Ananyev, Konstantin" , Gage Eads , Timothy McDaniel , David Hunt , Bruce Richardson , chris.macnamara@intel.com, Ray Kinsella , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 00/11] Add PMD power management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 11, 2021 at 9:44 AM David Marchand wrote: > > On Fri, Jan 8, 2021 at 5:42 PM Burakov, Anatoly > wrote: > > Why does aarch64 build fail there? The functions in question are in the > > version map file, but the build complains that they aren't. > > From what I can see, this series puts rte_power_* symbols in a .h. > So it will be seen as symbols exported by any library including such a header. > > The check then complains about this as it sees exported symbols > unknown of the library version.map. Quick fix: diff --git a/lib/librte_eal/arm/include/rte_power_intrinsics.h b/lib/librte_eal/arm/include/rte_power_intrinsics.h index 39e49cc45b..9e498e9ebf 100644 --- a/lib/librte_eal/arm/include/rte_power_intrinsics.h +++ b/lib/librte_eal/arm/include/rte_power_intrinsics.h @@ -13,35 +13,6 @@ extern "C" { #include "generic/rte_power_intrinsics.h" -/** - * This function is not supported on ARM. - */ -void -rte_power_monitor(const struct rte_power_monitor_cond *pmc, - const uint64_t tsc_timestamp) -{ - RTE_SET_USED(pmc); - RTE_SET_USED(tsc_timestamp); -} - -/** - * This function is not supported on ARM. - */ -void -rte_power_pause(const uint64_t tsc_timestamp) -{ - RTE_SET_USED(tsc_timestamp); -} - -/** - * This function is not supported on ARM. - */ -void -rte_power_monitor_wakeup(const unsigned int lcore_id) -{ - RTE_SET_USED(lcore_id); -} - #ifdef __cplusplus } #endif diff --git a/lib/librte_eal/arm/meson.build b/lib/librte_eal/arm/meson.build index d62875ebae..6ec53ea03a 100644 --- a/lib/librte_eal/arm/meson.build +++ b/lib/librte_eal/arm/meson.build @@ -7,4 +7,5 @@ sources += files( 'rte_cpuflags.c', 'rte_cycles.c', 'rte_hypervisor.c', + 'rte_power_intrinsics.c', ) diff --git a/lib/librte_eal/arm/rte_power_intrinsics.c b/lib/librte_eal/arm/rte_power_intrinsics.c new file mode 100644 index 0000000000..998f9898ad --- /dev/null +++ b/lib/librte_eal/arm/rte_power_intrinsics.c @@ -0,0 +1,31 @@ +#include +#include + +/** + * This function is not supported on ARM. + */ +void +rte_power_monitor(const struct rte_power_monitor_cond *pmc, + const uint64_t tsc_timestamp) +{ + RTE_SET_USED(pmc); + RTE_SET_USED(tsc_timestamp); +} + +/** + * This function is not supported on ARM. + */ +void +rte_power_pause(const uint64_t tsc_timestamp) +{ + RTE_SET_USED(tsc_timestamp); +} + +/** + * This function is not supported on ARM. + */ +void +rte_power_monitor_wakeup(const unsigned int lcore_id) +{ + RTE_SET_USED(lcore_id); +} HTH. -- David Marchand