From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ABACA00BE; Mon, 27 Apr 2020 15:40:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1193C1D444; Mon, 27 Apr 2020 15:40:46 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 65B181D424 for ; Mon, 27 Apr 2020 15:40:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587994844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7aCyPgKsMHLVBsMtB7KPGM9z8oF5Xb0Of8TDdbVjMI=; b=ZCcNleGermJYDFE+55U1Cti205s449eLaqYEQtnIDwK5mZnffPJ4GygjGR2njiQxtieRr3 X/O50EBffu/KX05BO01FOjF7ylmUCsf6zzpWJebZeeAsDqkkq5y/P9mXRGidtRFAGLrnqZ npEB5WKf5sXlHh8hwRVLH3ShnbkegAY= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-s_n_9hDwMPeB7vUIgdga_A-1; Mon, 27 Apr 2020 09:40:42 -0400 X-MC-Unique: s_n_9hDwMPeB7vUIgdga_A-1 Received: by mail-vk1-f198.google.com with SMTP id s81so595583vkb.16 for ; Mon, 27 Apr 2020 06:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VudPcVa/c3HgId019CGidtQ1CYQZfbXEhTw1BpmDeIs=; b=r0bxzsF2G0I2pWO08lKca3vVvTT6gMY4nCqOcRb7Bm+PcVja+PsRjjhSP5TxbsxvWz Eg4K40AN5IK7V0IsQ0bWr7dxNvO9TXlQTmbEkyzOHZ6CPwUtAvQFJYR83bC/i4pIxH+O 1h93IiKOZVPkTYK29e+iHCB6+8K/1q5QzG8jRC0F6HNZTDW7c6YYdczBj8Nl7bzgdATu TzzXY0DGbzMu5MS62nOorjKLZkUw17s4DEr64B+9kKRxY+Pagr/WoxRDEzdatrPB4DoL mLqWgzc0ppxLzqFaG7s80QUjO1ULDF9+hloKdVJqj558JWUEbk3sfl6RWZi34inxS40+ pa1A== X-Gm-Message-State: AGi0PuYQmR1qqKDA1MSrkRB873rjJsHzRXRDCNt54MaAhwQSahTSi01I zciT0edu+uAjoPAWKaroxlw5UtV9+05gA2SZVf4jzJ59pH4tpaFuIT6E3ulJ6GYv6vXj7blm1cY 6sO6wTS+BGOhgIBEmfLI= X-Received: by 2002:a67:d817:: with SMTP id e23mr12499712vsj.39.1587994841858; Mon, 27 Apr 2020 06:40:41 -0700 (PDT) X-Google-Smtp-Source: APiQypKzD2HQ/q4GOGqRgkCB4gF1yvY/PjjAeeWDGofZHCZsGuZv8ZLJW/qVPZjJ904Cq/tUjecVYe3ZAg9jsgP8El8= X-Received: by 2002:a67:d817:: with SMTP id e23mr12499689vsj.39.1587994841629; Mon, 27 Apr 2020 06:40:41 -0700 (PDT) MIME-Version: 1.0 References: <20200427132341.27681-1-david.marchand@redhat.com> <20200427132341.27681-4-david.marchand@redhat.com> <20200427133413.GA1848@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: David Marchand Date: Mon, 27 Apr 2020 15:40:30 +0200 Message-ID: To: Andrew Rybchenko Cc: Bruce Richardson , dev , Ori Kam , Thomas Monjalon , Ferruh Yigit , Xiao Zhang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on 64-bit value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 3:39 PM Andrew Rybchenko wrote: > > On 4/27/20 4:34 PM, Bruce Richardson wrote: > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote: > >> Building OVS with dpdk, sparse complains about 64-bit constant being > >> passed as a normal integer that can't fit it: > >> error: constant 0xffffffffffffffff is so big it is unsigned long > >> > >> Fixes: ecbc8570131d ("ethdev: add PFCP header to flow API") > >> > >> Signed-off-by: David Marchand > >> --- > >> lib/librte_ethdev/rte_flow.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow= .h > >> index 132b44edc6..1fb94f35e8 100644 > >> --- a/lib/librte_ethdev/rte_flow.h > >> +++ b/lib/librte_ethdev/rte_flow.h > >> @@ -1534,7 +1534,7 @@ struct rte_flow_item_pfcp { > >> #ifndef __cplusplus > >> static const struct rte_flow_item_pfcp rte_flow_item_pfcp_mask =3D { > >> .s_field =3D 0x01, > >> - .seid =3D RTE_BE64(0xffffffffffffffff), > >> + .seid =3D RTE_BE64(UINT64_C(0xffffffffffffffff)), > > Rather than cast, why not put "ULL" at the end. > > It is not a cast as far as I can see, it is exactly ULL (or UL): > /usr/include/stdint.h > # if __WORDSIZE =3D=3D 64 > # define UINT64_C(c) c ## UL > # else > # define UINT64_C(c) c ## ULL > # endif Yes. --=20 David Marchand