From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D57845B13; Fri, 11 Oct 2024 16:51:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 128574028B; Fri, 11 Oct 2024 16:51:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D37F4025F for ; Fri, 11 Oct 2024 16:51:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728658261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OxQkN+bvSb1FksxJ6sOGgTGDq4exXLfSSiCxI1QytDI=; b=ah15BX7EHCG7yILBYVDnAkKL0/JH6Sc7YYL+P+gDiOtkvROZLcM1oWdlYL0rLOF9E8XXV5 EYu66owqprdhlg5DbUUF5Mqwe6RTZbAY63JkwYHTQl0Ww28+gD1/vb17WEUQ9xmAJJvdAQ igtxsBj7XsJhoViMRsc0AYSgupLCaf0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-HqoygMclPeqM-jCBppW0Xw-1; Fri, 11 Oct 2024 10:51:00 -0400 X-MC-Unique: HqoygMclPeqM-jCBppW0Xw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5398cd108bcso1609223e87.1 for ; Fri, 11 Oct 2024 07:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728658259; x=1729263059; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OxQkN+bvSb1FksxJ6sOGgTGDq4exXLfSSiCxI1QytDI=; b=lDrJbjWayh19G8mv5CGKVlH5bQwdCrovyHilk/QGlKblE7imIjNdlZTumenJqLeym+ dHgcuVQVJSa+or4EmqZlLJDKnw0LSJkoI14LYmeBwwvXxYW1UTUGpOk5qba5celVZWWJ sW/B+9C13BudmBTdqVubX0uohjnHmUxfj5oJzqDSNEussDHrOwAns+RtEndMfnkQv/Iy YSLzRwgog+chLW5dz07BPeTR/K0pK8BLKiIf1WOe0rffncHRa9p5Lr1iSWjOfD/jWUzh BnD8TEbMIvu1XoCBjhz6Ntq3l017+a8csF/kZjT63UVvFYgHzM4c5uY/+b/zychXPjmz B9fQ== X-Gm-Message-State: AOJu0Yy4ND0Cn1tEXxFUiXlX7LL82Q3kw0ucX57VBLNfRUih1LNExtcU IRz0bBROUSHUZfoczFN0VmlD7BiWaEDJcpiIf52m9si2+u9UKA93u2+SQmMbJzIIH7kiqMuf3Ef 3F0mwe0YS6k/NFT41NdezI6lendqOT1YOHjyMnwVWS1q5M8SoMqcdMoNTuNi2J0pNj+b4RooFY/ vGV9JI7zfsXFGtsq0= X-Received: by 2002:a05:6512:2307:b0:539:964c:16b4 with SMTP id 2adb3069b0e04-539da5ae44emr1519162e87.58.1728658258913; Fri, 11 Oct 2024 07:50:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCO59bcCeCpbhLnyUNOq1iZDY+SXkd5qPieW9svIIiLUFP0ehZuF53U4cj9bEajRGnn7g564R15Q0ELYKRsWI= X-Received: by 2002:a05:6512:2307:b0:539:964c:16b4 with SMTP id 2adb3069b0e04-539da5ae44emr1519145e87.58.1728658258531; Fri, 11 Oct 2024 07:50:58 -0700 (PDT) MIME-Version: 1.0 References: <20240905162018.74301-1-stephen@networkplumber.org> In-Reply-To: From: David Marchand Date: Fri, 11 Oct 2024 16:50:47 +0200 Message-ID: Subject: Re: [PATCH] eal: increase max file descriptor for secondary process device To: Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Chengwen Feng , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 11:51=E2=80=AFAM David Marchand wrote: > > On Thu, Sep 5, 2024 at 6:22=E2=80=AFPM Stephen Hemminger > wrote: > > > > The TAP and XDP driver both are limited to only 8 queues when > > because of the small limit imposed by EAL. Increase the limit > > now since this release allows changing ABI. > > > > Signed-off-by: Stephen Hemminger > > Applied, thanks. I suspect this triggered some coverity hiccup: *** CID 445386: Memory - illegal accesses (OVERRUN) /drivers/net/tap/rte_eth_tap.c : 2401 in tap_mp_sync_queues() 2395 TAP_LOG(ERR, "Number of rx/tx queues %u exceeds max number of fds %u", 2396 dev->data->nb_rx_queues, RTE_MP_MAX_FD_NUM)= ; 2397 return -1; 2398 } 2399 2400 for (queue =3D 0; queue < dev->data->nb_rx_queues; queue++)= { >>> CID 445386: Memory - illegal accesses (OVERRUN) >>> Overrunning array "process_private->fds" of 16 4-byte elements at e= lement index 252 (byte offset 1011) using index "queue" (which evaluates to= 252). 2401 reply.fds[reply.num_fds++] =3D process_private->fds[queue]; 2402 reply_param->q_count++; 2403 } 2404 2405 /* Send reply */ 2406 strlcpy(reply.name, request->name, sizeof(reply.name)); Can you have a look? Thanks. --=20 David Marchand