From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9272A0352; Thu, 14 May 2020 15:31:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC859493D; Thu, 14 May 2020 15:31:25 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id CA4C7323C for ; Thu, 14 May 2020 15:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589463083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=he5rw6Ejkwc+xnsKlfOcCAdulML0n3yBbEcV3+roRuw=; b=hZ8RiSUkdpYPq9wIh/xiM2hX+mYul/3yCBGN9+Os+rqE0Jhum9bbf/vv5xdNkyBSh8Ojkl v1GwZSH/A3AEqjuDhZaCYAJh+Qjcl7E5IAAXmC09ZLKLjMl0yiTbIxNvO3VEF5hIMxu5vD VuIqDiccS/Dnpb4HkhMoJPpkcLC2MNw= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-4GNomxfXO96Lrj0AZMW_Cw-1; Thu, 14 May 2020 09:31:21 -0400 X-MC-Unique: 4GNomxfXO96Lrj0AZMW_Cw-1 Received: by mail-vk1-f198.google.com with SMTP id x128so1302160vkd.9 for ; Thu, 14 May 2020 06:31:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=he5rw6Ejkwc+xnsKlfOcCAdulML0n3yBbEcV3+roRuw=; b=Ui+gCFzGKWzSPWa0Mo+HVMr6L4MB/QWTvdF920SyNPqkXCN3LDz+OJH9Ry1IkKmbg/ 4IGp+VHmJTQYZNsFzXSAoj3gnHmUrJOIQEy6yaQIApgawZ2n4EU53O0MT9/eF/IgGQGk f5HHLBo0xBBx1fQEnSHXTU6sJhOuVmmInpn/+6ppesUXTZZsuReKbqtEUkVbW3rsMjhz vJt8qfTAwMsXJnTVOu16WR1piiOmsD1URcXzTiJpze5XBZjjrOH377Y5f1itaCFylJ4A SuIBUJ2evrIDjH0/Cb3r1/v1NrGGXwPiQCnL7h1BNgNwqVMzRHNNFt7p48MFCFG9OT3Y TWFg== X-Gm-Message-State: AOAM532a0+0Ma2+P1/ufHkB1jnQ9zEyxAiRoPmBH4CeY1c4d+oY9GHle 04KzDw59L7skP0x9J1wusU5FytanlnSoViRJtu6C7e4AVYMMY32lp59YwrUrgyM88ryDc0PjFSz Cp4NR1j/N7OrTStPcndo= X-Received: by 2002:a1f:2e16:: with SMTP id u22mr3383943vku.12.1589463080603; Thu, 14 May 2020 06:31:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm5CISVNfSmaUuDgNnrNDN5aFROwN0zpdHfRyMYcFNBwSb30fczSQfxjT1ZVEUut5OpQZFGMezzPy/aDUltKM= X-Received: by 2002:a1f:2e16:: with SMTP id u22mr3383918vku.12.1589463080351; Thu, 14 May 2020 06:31:20 -0700 (PDT) MIME-Version: 1.0 References: <20200512140100.26803-1-hemant.agrawal@nxp.com> <20200513132745.9006-1-hemant.agrawal@nxp.com> <20200513132745.9006-2-hemant.agrawal@nxp.com> <63aee4d4-db63-de05-2ff1-5f9ae748da80@ashroe.eu> <22cd532f-8b25-df37-29b0-daad10381def@ashroe.eu> <313184ad-539c-5f18-3a19-7939fbd3d730@ashroe.eu> In-Reply-To: From: David Marchand Date: Thu, 14 May 2020 15:31:09 +0200 Message-ID: To: "Hemant Agrawal (OSS)" , Ray Kinsella Cc: "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) wrote: > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > I removed the filename_exp and introduced function based name= > Now the issue is the following warning > SONAME changed from 'librte_pmd_dpaa2.so.20.0' to 'librte_pmd_dpaa2.so.0.200.2' > > The primary reason is that now pmd_dpaa2 has no symbol left for 20.0 section. > Following is not helping. > [suppress_file] > soname_regexp = ^librte_pmd_dpaa2 > so, it seems for now, the filename_exp is the only option That's interesting. Because I wondered about this point when reviewing __rte_internal. For components providing only internal symbols like components providing only experimental symbols, the build framework will select a soname with .0.200.x. Here, your dpaa2 driver was seen as a stable library so far. Moving everything to internal changes this and the build framework changes the soname to non stable. You could keep an empty DPDK_20.0 block to avoid this and the soname will be kept as is. -- David Marchand