From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBC80A0093; Tue, 23 Aug 2022 10:42:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CED1040DDA; Tue, 23 Aug 2022 10:42:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 94F18400D6 for ; Tue, 23 Aug 2022 10:42:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661244133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I+nQjLzJG4cupy4ikWMwzrvLuVS4VHk2tq8rM5Kgxds=; b=ftNhHqMnLvcURpKiv9Q3+lTl4PCamRX7kLUa7/aS1RHn44OC/QjIpj1HT0HUzQgPNz9Arw awSaMUt+3i0xQiFxRjUxyQU9sY4gLG//hu3sORFkieMlUrmzocI4En4j2k8+AKNscxqLEH SwKfmERwITrstx3muWXOkw1srfkWq1w= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-315-IIP8XzBRObKuBvV9Oye37g-1; Tue, 23 Aug 2022 04:42:11 -0400 X-MC-Unique: IIP8XzBRObKuBvV9Oye37g-1 Received: by mail-lf1-f72.google.com with SMTP id w17-20020ac25991000000b00492b09753c2so4128068lfn.5 for ; Tue, 23 Aug 2022 01:42:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=I+nQjLzJG4cupy4ikWMwzrvLuVS4VHk2tq8rM5Kgxds=; b=Q8+2do+Ow6HaAayjhrYBjpt1fFn4JQjSQ+zc/5aevymNZd8pfsGzVDB6jQwKjh9et2 qR55hPp5QCT5OlEbwE5nJFmdCFLl3HS6iLc8z+gscU/UHUuYgDqjXqyJJHWUh5ZYo5oL +NvSavj8cZ3B+7eTCS0uWk/IlXIGi9ckfWCRWIOauKIlPwuUr7a2GRf5g12ajMeIg2oh hhYNCF4KXTOvnCW0rtJM6yiyRbP1P6OIsISkBbMcgo/nRZ4HCBwNWHsTIdusSaUZQwQJ CyGoQhf2mcwUoyaBv8+Zl8ygeDGRq44OnV41cgBpa/KgfDMf0OVtvEzCJmLftPcRJltB v2Iw== X-Gm-Message-State: ACgBeo1N57C/HzqYgsJ7DrKl9AEzYGTs1moNHuB6sWGFyGMzTdUUpNXi 9YkiGafLhnKXcyDr9mMH40IGQ2GSFX/fAUhaJmO1Eum/mi742lSzmuwpsKmPdirFOfB4xl5NLPB QaoTz+whD3bNpIcF9oYs= X-Received: by 2002:ac2:4bc1:0:b0:48b:2ac7:bd67 with SMTP id o1-20020ac24bc1000000b0048b2ac7bd67mr8226237lfq.499.1661244130332; Tue, 23 Aug 2022 01:42:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR7xgNy1vlCE05rM71WPOrMg+UP6HrRWxQNdWN95SH5+VFKUtRoLmVbebtNYAIngvHDu6P530ZbNYWP2cqrFxgg= X-Received: by 2002:ac2:4bc1:0:b0:48b:2ac7:bd67 with SMTP id o1-20020ac24bc1000000b0048b2ac7bd67mr8226229lfq.499.1661244130132; Tue, 23 Aug 2022 01:42:10 -0700 (PDT) MIME-Version: 1.0 References: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 23 Aug 2022 10:41:59 +0200 Message-ID: Subject: Re: [PATCH 00/10] ethdev: cleanup deprecated defines To: Andrew Rybchenko Cc: Thomas Monjalon , Ferruh Yigit , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko wrote: > > Remove deprecated because of invalid namespace defines. > > Andrew Rybchenko (10): > ethdev: remove deprecated link speed and duplex defines > ethdev: remove deprecated Rx and Tx multi-queue mode defines > ethdev: remove deprecated defines for RSS configuration > ethdev: remove deprecated Rx and Tx offload defines > ethdev: remove deprecated DCB and VMDq defines > ethdev: remove deprecated tunnel type defines > ethdev: remove deprecated flow control defines > ethdev: remove deprecated VLAN offload configuration defines > ethdev: remove deprecated maximum Rx MAC addresses define > ethdev: remove deprecated metadata dynamic fields defines > Same comment as for the mbuf flags patch, we have a cocci script to do the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci We can reference it in the release notes. I suspect the RN will grow quite big for 22.11. Can we perhaps have a single entry for ethdev, listing all the different defines in a sublist? (and looking again at the other cleanups, this last comment applies to the mempool series too). I sent some comments, but otherwise, the series lgtm and you can add my ack. Thanks Andrew! -- David Marchand