From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3791CA00C5; Wed, 16 Feb 2022 10:42:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA040410FF; Wed, 16 Feb 2022 10:41:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0FDA7410FB for ; Wed, 16 Feb 2022 10:41:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645004517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ggMQgcx+3MLGaT+D+kkj9G54zE/LC9rFR6UR2VW4SMc=; b=a91HIM83Cfqltua96qxRFqE4gajTYQU4aHOJg9PO663pxGFYWWS1gRWuw0PmbnOou/VYet 5fD+t/g1/5NC2I8k3GmsjZJ9ssr0WbLOkmDiY0rB5peOJhUeKpavrvln11i9owYWT8z304 bJJhaZ0tvtFckLoIFulC3LkZ/0AWx2U= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-g8CUPWzWP66FSRgwEezh2g-1; Wed, 16 Feb 2022 04:41:56 -0500 X-MC-Unique: g8CUPWzWP66FSRgwEezh2g-1 Received: by mail-lj1-f200.google.com with SMTP id v1-20020a2e9601000000b002446a7310a1so721821ljh.3 for ; Wed, 16 Feb 2022 01:41:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ggMQgcx+3MLGaT+D+kkj9G54zE/LC9rFR6UR2VW4SMc=; b=QnxXXYaKBbZXXJph+hiOE9WqGQTZsWrL+hmeKSWZsdnkgOsbTLzMgoJqPcLOxxUN4I jmOJycVDeba3dfGr4JNiGNNwPBEnpJWooElhgHSZftKCGNge45BWvRpLAOnIvihGKmpR ZqUPFW1J86JZ5MsBPLtc3T+WuuXsE+jwVaCz1jHXK5v2TJ+cVEVrlx5fdl+gFM3lCLH2 SEkXEIivI8m0SICkTDYoMIOxnwqe0dg+EXf8CCsyfuM744Vpo8WeyzqIn4yKJmfrcWTg 41b9j/Fh+NlZabeLMg9hy/Z7/ATtI/T0185abJcLFptK94V6AxOE8VcFn8qxe9D00q7T XK4A== X-Gm-Message-State: AOAM532c7H0oQVyzs46dvMcZDr+7r4d3Q8j9yTq5Pp9rHW0hYMQ1KAkJ yBWnnqCuPkVSsZkHZcUFwzc5oRZ6yvkmWeDPssJNt9Wl6ELS1KVD5OMokOIFs3nQlTiKUQkSmCm ZsAZZGy7EvUxeyORxgww= X-Received: by 2002:ac2:522f:0:b0:442:bf9b:4249 with SMTP id i15-20020ac2522f000000b00442bf9b4249mr1446784lfl.484.1645004514691; Wed, 16 Feb 2022 01:41:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+xWUxzDWZUyFTAYe9KChY5F94+qAcVfIJQZA58AiYRn3Sxx4wTpzNcdD56n5K0jqdzIPcpdpL6pRbw0bjYEU= X-Received: by 2002:ac2:522f:0:b0:442:bf9b:4249 with SMTP id i15-20020ac2522f000000b00442bf9b4249mr1446771lfl.484.1645004514496; Wed, 16 Feb 2022 01:41:54 -0800 (PST) MIME-Version: 1.0 References: <20220215101853.919735-1-robinx.zhang@intel.com> <1696182.K4a6FZZPjd@thomas> In-Reply-To: From: David Marchand Date: Wed, 16 Feb 2022 10:41:43 +0100 Message-ID: Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM To: Bruce Richardson Cc: Thomas Monjalon , "Zhang, RobinX" , "Yigit, Ferruh" , dev , "Zhang, Qi Z" , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , "Guo, Junfeng" , "Yang, SteveX" , Ciara Power Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson wrote: > > > I see that we have other telemetry callbacks for stats, link status > > > which might already have the issue. > > > > You mean there is no lock protection? > > Neither in the API, nor in telemetry? > > > For reporting out stats or link status, I'm not sure a lock should ever be > needed since both are just read-only operations. Therefore, I don't believe > we have a general issue here. Ok, if you are sure about this for all drivers for stats and link status, you can discard my comment. -- David Marchand