From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A32EE4611A; Fri, 24 Jan 2025 09:32:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8345840E5A; Fri, 24 Jan 2025 09:32:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3D83E402E9 for ; Fri, 24 Jan 2025 09:32:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737707564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xr+89HauMH+2surZ10hi080DfrW0XJ4nAcN+eCyCgi8=; b=gOKrtdvWsgLiGyVksD5LLulMtH1P95MGhgpe2fJwlbudKw9wY8ZVbLGkDTuuV65S7+FbR5 xwhtLnPjO2beUiJtt84oI7Qpjou5Igc1h1cnxEF/j0uMPVRF2cOcG413g2TdZGur4VE0ah V+Bvbh3+hTp8Amo9R0yeleWRnzPKt/8= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-FfhRnmNHPLCvCvJOfqy_Jg-1; Fri, 24 Jan 2025 03:32:41 -0500 X-MC-Unique: FfhRnmNHPLCvCvJOfqy_Jg-1 X-Mimecast-MFC-AGG-ID: FfhRnmNHPLCvCvJOfqy_Jg Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5424a89c885so940338e87.0 for ; Fri, 24 Jan 2025 00:32:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737707559; x=1738312359; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xr+89HauMH+2surZ10hi080DfrW0XJ4nAcN+eCyCgi8=; b=JAF0vsoBPYRkYhyVxT7reB1Q10ClvKdXSl8iy/DuLNonesNmRXk4jrGfFAGUP0BGMR NeDdwFY9d6IalYsaj5LkHiCd+h84g/3dn6CXLV3IhhS0cjFfj3Azr+bRd1HUxYkKVD+P fa6n9D8zx3lVVtDxCCWWq+bS40u4RrFwcn3j3htdWmcVqT0UWKLFd5Cou3i+qcSrRdbJ lYl6naGbIOZZf7Mk+8+rr7cLcgS9YVV7ZjFXvqbHIL+eAmVbkGKW32PlJQd1MGBwT9Ja e41GVH0OJ7USnrZtLh98bbl/Xb4UWeyVB++h6z5mvtwNuanrQA0Bb8AIZ8o7GlTUlvIK aKXw== X-Gm-Message-State: AOJu0YzBx7q4xY4vBxFvOD0y/qZLq0eiKmCX+R15O+xgTQzvFyDmHdV5 dGJLEY164A6oo4Aq0wwQSd2z2CVTcyopXdBotyl3X/9LpvcggiNQjs+ESmJkBTptLoVcr5slNDS w2G7SYBQTLS/J0+3btm5QAzXSuMS2wgOFkyFMyoNm0H+2cq5TlrZvppJh2QmQSfQNPpg2P+oQtS 3ms/YuhSRdOnvGTwk= X-Gm-Gg: ASbGncu4fgA08SYV2a6igyWx8pWysYgyDuKbIolRa/+/znuSebd/zwwUEnA1Pml+Ca6 33KLlkJ6ULoZA0+RUtwJ+hqC6/6lVIXVGttoWE9naoCtn+XCrn25Q4g== X-Received: by 2002:a05:6512:4808:b0:540:22e0:1f80 with SMTP id 2adb3069b0e04-5439c229158mr9077105e87.20.1737707559514; Fri, 24 Jan 2025 00:32:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPO3stmRcC4a4PGcAiAyx0rwOfp2ttq7WRAPwj5gpxFUt3oMvY0fcNrX2p96fW3nqTBakt3Er3rFqIk3B69Mc= X-Received: by 2002:a05:6512:4808:b0:540:22e0:1f80 with SMTP id 2adb3069b0e04-5439c229158mr9077083e87.20.1737707559099; Fri, 24 Jan 2025 00:32:39 -0800 (PST) MIME-Version: 1.0 References: <20241122125418.2857301-1-bruce.richardson@intel.com> <2297034.HovnAMPojK@thomas> In-Reply-To: <2297034.HovnAMPojK@thomas> From: David Marchand Date: Fri, 24 Jan 2025 09:32:25 +0100 X-Gm-Features: AWEUYZlz8Uzee1xWNSO4pB2EVMdCJrjweaKYEgUhX1K2c5UM7Qz_Sd5Vhgmib1w Message-ID: Subject: Re: [PATCH v5 01/25] net: move intel drivers to intel subdirectory To: Thomas Monjalon , Bruce Richardson Cc: dev@dpdk.org, Konstantin Ananyev , David Christensen , Wathsala Vithanage , Praveen Shetty , Ian Stokes , Vladimir Medvedkin , Anatoly Burakov , Jingjing Wu , Rosen Xu , Robin Jarry X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ls-03rZ94rghLy6o8BuoetikdR4y3HFq8yCXo-qa4Hc_1737707560 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 5:02=E2=80=AFPM Thomas Monjalon wrote: > > 23/01/2025 15:35, Bruce Richardson: > > On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote: > > > On the check-git-log.sh update, we will have many warnings with curre= nt update. > > > > > > Wrong headline prefix: > > > net/intel/common: add pkt reassembly fn for intel drivers > > > net/intel/common: provide common Tx entry structures > > > net/intel/common: add Tx mbuf ring replenish fn > > > net/intel: align Tx queue struct field names > > > net/intel: add prefix for driver-specific structs > > > net/intel/common: merge ice and i40e Tx queue struct > > > net/iavf: use common Tx queue structure > > > net/ixgbe: use common Tx queue structure > > > net/intel/common: pack Tx queue structure > > > net/intel/common: add post-Tx buffer free function > > > net/intel/common: add Tx buffer free fn for AVX-512 > > > net/iavf: use common Tx free fn for AVX-512 > > > net/ice: move Tx queue mbuf cleanup fn to common > > > net/iavf: use common Tx queue mbuf cleanup fn > > > net/ice: use vector SW ring for all vector paths > > > net/intel/common: remove unneeded code > > > net/intel/common: create common mbuf initializer fn > > > net/intel/common: extract common Rx vector criteria > > > > > > Invalid patch(es) found - checked 25 patches > > > > > > I tried to tweak this a bit, with the following heuristic: > > > * if touching only net/intel/common, accept net/intel/common: > > > * if touching multiple drivers under net/intel, then accept net/intel= : > > > as prefix, > > > * if touching some net/intel/$drv (and optionnally net/intel/common), > > > accept net/$drv, > > > > > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > > > index b2da013f6c..41c290f0ca 100755 > > > --- a/devtools/check-git-log.sh > > > +++ b/devtools/check-git-log.sh > > > @@ -79,11 +79,18 @@ bad=3D$(for commit in $commits ; do > > > [ -z "$(echo "$files" | grep -v '^\(drivers\|doc\|config\)/')= " ] || > > > continue > > > drv=3D$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 = | sort -u) > > > - # for drivers/net/intel/* use 2nd and 4th fields not 2nd and = 3rd > > > if [ "$drv" =3D "net/intel" ] ; then > > > - drv=3D$(echo "$files" | grep '^drivers/' | cut -d "/"= -f > > > 2,4 | sort -u) > > > + drvgrp=3D"net/intel" > > > + drv=3D$(echo "$files" | grep '^drivers/' | grep -v > > > '^drivers/net/intel/common' | > > > + cut -d "/" -f 2,4 | sort -u) > > > + if [ $(echo "$drv" | wc -l) -eq 0 ] ; then > > > + drv=3D'net/intel/common:' > > > + elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > > + drv=3D'net/intel:' > > > + fi > > > + else > > > + drvgrp=3D$(echo "$drv" | cut -d "/" -f 1 | uniq) > > > fi > > > - drvgrp=3D$(echo "$drv" | cut -d "/" -f 1 | uniq) > > > if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then > > > echo "$headline" | grep -v '^drivers:' > > > elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > > > > > Which then complains on patches in this series that touch many driver= s > > > (but have net/intel/common: as prefix where I would suggest net/intel= : > > > instead). > > > > > > > I tend to disagree with this suggestion. I think that a prefix can be v= alid > > so long as the prefix matches at least one component in the patch. For= example, > > for the first patch in the set, I think net/intel/common is a better pr= efix > > than just "net/intel". I don't massively object to your suggestion, I j= ust > > prefer patches identify the most relevant component, if possible, rathe= r > > than generalities. > > Saying net/intel means the same thing as net/intel/common to me. > Why do we care whether the change is in common or multiple drivers? > At the end it impacts multiple Intel drivers. > The goal of the prefix is to quickly catch the scope of the change impact= . > > One more argument: net/intel is shorter :) True that any change on net/intel/common will affect many drivers. Whatever is decided, I just want the check to be less prone to false positi= ves. With current series, output is a bit too vocal to me. --=20 David Marchand