DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com
Subject: Re: [PATCH 0/4] Virtio-user queues setup fixes
Date: Wed, 27 Mar 2024 11:04:01 +0100	[thread overview]
Message-ID: <CAJFAV8wYfWEObpi7jHMecNDNHdQ3dGG8X=JdLmsw1MKqYziPUA@mail.gmail.com> (raw)
In-Reply-To: <20240327094032.2400951-1-maxime.coquelin@redhat.com>

Hello Maxime,

On Wed, Mar 27, 2024 at 10:40 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This series aims at fixing several issues found in
> Virtio-user PMD related to queues setup and cleanup.
>
> It has been tested with Vhost-vDPA backend using Nvidia
> Cx6-Dx vDPA VF.
>
> First patch in the series renames the queues iterator
> helper, so it is not a fix. But I would suggest to have it
> backported to ease backporting of the fixes.
>
> Maxime Coquelin (4):
>   net/virtio: rename Virtio-user queue iterator
>   net/virtio: use iterator to destroy Virtio-user queues
>   net/virtio: fix shadow control queue notification init
>   net/virtio: fix shadow control queue allocation
>
>  .../net/virtio/virtio_user/virtio_user_dev.c  | 132 +++++++++---------
>  1 file changed, 67 insertions(+), 65 deletions(-)

I would prefix those titles with net/virtio-user: as was done in the past.
This will show the changes only affect virtio-user.

For patch 2, it is better to highlight the functional change/fix in
the title, so something like:
net/virtio-user: fix control queue destruction

With this fixed, you can add on the series:
Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


      parent reply	other threads:[~2024-03-27 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  9:40 Maxime Coquelin
2024-03-27  9:40 ` [PATCH 1/4] net/virtio: rename Virtio-user queue iterator Maxime Coquelin
2024-03-27  9:40 ` [PATCH 2/4] net/virtio: use iterator to destroy Virtio-user queues Maxime Coquelin
2024-03-27  9:40 ` [PATCH 3/4] net/virtio: fix shadow control queue notification init Maxime Coquelin
2024-03-27  9:40 ` [PATCH 4/4] net/virtio: fix shadow control queue allocation Maxime Coquelin
2024-03-27 10:04 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8wYfWEObpi7jHMecNDNHdQ3dGG8X=JdLmsw1MKqYziPUA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).