From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 525B0A0C49; Wed, 16 Jun 2021 10:35:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 439D14069C; Wed, 16 Jun 2021 10:35:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 08A0440140 for ; Wed, 16 Jun 2021 10:34:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623832498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=03KMBQk3HqturwjEFKKYD+CWpvdZUx4S5zSeO9Jhjq8=; b=fmgQ00zXq0vyXASidLz0Gpptk4YdPAfgVoSREEbr+XmlQI7nGDly1ZVwwZNFDpud3ZDgqt SbxqfaBhHDG06LPGrwUndcWOTpbI1Hv4LUrytNLazUzHlheB6j2nWIIaKnoRTyEd5NlJ0J rtO58/gkvXXIMGzvU38nyYHlg2NJgdc= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-VlcB5KETO-uhdvD2fp7lFA-1; Wed, 16 Jun 2021 04:34:57 -0400 X-MC-Unique: VlcB5KETO-uhdvD2fp7lFA-1 Received: by mail-vk1-f200.google.com with SMTP id o26-20020a056122179ab02902433e1c5c83so455232vkf.12 for ; Wed, 16 Jun 2021 01:34:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=03KMBQk3HqturwjEFKKYD+CWpvdZUx4S5zSeO9Jhjq8=; b=nT1zI5aanCkCdkHV2TbnAWKEsCxq3p9iueMeiaTnXrVrw0FY6vH83gsPAIBixRWG6m NifP8nhIB7g8m+F+ivFEGaniU4I4yNo48xqjV6KSqMSY7WwrjNkDRAuFhRytapu2/d8N IeOBh1aJsH9scNDXNrNEbUlVtHJwF8icIp7bSVwAagHsix4aGD+XdX+GtFN2u8zcLWn3 Vqe/SIT3MEfs4vNbdaoInywRmB5Bm0xK86O82XI6x6NGAvZBJs15xHQVtJ55eZa/+fEa 1/ohlKUyftg0WBiI1sdYX/Vq6/NgSAsTE9+m3kJMHhKtfYPD+42zRsb5rScDit5LOPic Y/Og== X-Gm-Message-State: AOAM530YMLyyQKwddOlk3/BdH7N739LcLNjZxioQnJFvZANfS6/oigzd 0mZxBN0P5cS4H3CCcO+SlapDvaDCnmaUqEgmAA6xkYj5KaHxyCD6/9q1rkWusenLxn/zTY7mmn1 VFn1d7kDfJAjpD8r9oxo= X-Received: by 2002:a05:6102:243c:: with SMTP id l28mr9534268vsi.27.1623832496769; Wed, 16 Jun 2021 01:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgTw+N6nTq5jnSJwoaNzww8yMRHmjEoqiIEX/NJSPsIiWRqPskgngrA1t0yKjERKxb6K9ALDQ34xZdeyUrQYM= X-Received: by 2002:a05:6102:243c:: with SMTP id l28mr9534251vsi.27.1623832496591; Wed, 16 Jun 2021 01:34:56 -0700 (PDT) MIME-Version: 1.0 References: <20210614091213.3953-1-david.marchand@redhat.com> In-Reply-To: <20210614091213.3953-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 16 Jun 2021 10:34:45 +0200 Message-ID: To: dev , Anatoly Burakov Cc: Owen Hilyard , dpdk stable , Qi Zhang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ipc: stop mp control thread on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 14, 2021 at 11:13 AM David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > mp_fd to -1 leaving the rte_mp_handle control thread running. > This control thread can spew warnings on reading on an invalid fd. > > To handle this situation, sets mp_fd to -1 to signal the control thread > it should exit, but since this thread might be sleeping on the socket, > cancel the thread too. > > Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup") > Cc: stable@dpdk.org > Reported-by: Owen Hilyard > Signed-off-by: David Marchand Anatoly, review please. -- David Marchand