From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67A22A00C4; Tue, 26 Apr 2022 09:41:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0135F40E78; Tue, 26 Apr 2022 09:41:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 588E740691 for ; Tue, 26 Apr 2022 09:41:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650958882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zULjgCFkXVIdF+mO2z4prwJUntkSQ2vtByVcs9G3g+s=; b=RC9lnfVL2+OjHWMVvv6ZNneu+Qw4JkDfwNXpc8X8EurrPEoyrdK4IBMm4iYkiSJy9oiDP0 Ow/rasYLZOPHsJ7UPOvETEwc9ayqX/953XzmRl1g51c9NPkWSoMiXL1HZnkcDyOtlXqT6R AFipBGD9nLnuhgK4pwh/xBULl6nLgGk= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-552-UcsXdBuHOvWg1mytIPBDuA-1; Tue, 26 Apr 2022 03:41:21 -0400 X-MC-Unique: UcsXdBuHOvWg1mytIPBDuA-1 Received: by mail-lj1-f197.google.com with SMTP id d5-20020a05651c088500b0024db8b6a445so4312188ljq.11 for ; Tue, 26 Apr 2022 00:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zULjgCFkXVIdF+mO2z4prwJUntkSQ2vtByVcs9G3g+s=; b=m/gWE3LBfPb81w8NwG5SLcjKCMLKdKod3CPJuMw1b0ilvFjRKTxhjdKISaG9p6W5T0 tBD2K7bCdL6bap6AeX454/69eV29i2nni4YvTX738rcOmpPNH1CpIi+qpEkzsquEP9vB lRCtN8bKEvsidXsg0twbQZ3DpdYhPBFwaTgsTOhWUnmgnNhcjQPe84kDZy6Anq+J5uWb icuQcbVbyX1F1Y/yZWsqlWrapY9Ak4mfvc6UzwxuUIc739YCI9+f2SdGyVcH78q2DKGE QjLaoxYrl9WBriYzz6XXctjc4d7r6CCGiAcbR+cnavE6Rm8m5KQHOafFAi/nTmYCKRx/ p58g== X-Gm-Message-State: AOAM5333/+yF0E9TLkdxgJZBI0rgDNZH6G5YZUZeujeZ5DgWF/SoEFe5 t4cosurh/aold/hEhOVYavV1PSR4QFJpWpQHypve6EtFb0WVEFTpS72EpxXgiIV/7LHRGpgsuFE MocLSa8LZ8GfXPL8ObEk= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr13470375ljb.477.1650958879990; Tue, 26 Apr 2022 00:41:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtNA81/2hJ95CwZmRplA3r7jBPTu46xzCOVKZE357MyKMs1vjeo7JomahNg9LP2/mKy9OoZZ/4zKNPgAwma7I= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr13470366ljb.477.1650958879781; Tue, 26 Apr 2022 00:41:19 -0700 (PDT) MIME-Version: 1.0 References: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com> <1647933155-30745-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1647933155-30745-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 26 Apr 2022 09:41:08 +0200 Message-ID: Subject: Re: [PATCH v2] test/bpf: skip test if libpcap is unavailable To: Tyler Retzlaff Cc: dev , Stephen Hemminger , "Burakov, Anatoly" , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 22, 2022 at 8:12 AM Tyler Retzlaff wrote: > > test_bpf_convert is being conditionally registered depending on the > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > test to run. > > when the UT runs test_bpf_convert test-dpdk can't find the registration > and assumes the DPDK_TEST environment variable hasn't been defined > resulting in test-dpdk dropping to interactive mode and subsequently > waiting for the remainder of the UT fast-test timeout period before > reporting the test as having timed out. > > * unconditionally register test_bpf_convert > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the > test is skipped similar to that done with the test_bpf test. > > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") > Cc: stable@dpdk.org > > Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger Acked-by: Konstantin Ananyev Applied, thanks. -- David Marchand