From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF443A09FF; Thu, 7 Jan 2021 09:02:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 564C6140EC5; Thu, 7 Jan 2021 09:02:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 39D71140EC0 for ; Thu, 7 Jan 2021 09:02:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610006523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NW3wAEod9zUUVA1N4wAEMUfZhnRiHIweJUksEzCGqD8=; b=MiA4oopfCYxg+VWKOfKRNP3v+fHo31g7xSOz2nEjGznKeCGKNRwXBm2NrZisOKhBB83Pfv znQelDy4nudSQasbPe8w1g5e3YzKqpunfkw9f4FV4L3yQHBSs5O807hTPQHe3MzDX3zaHo VeVbPUFkBFaD9eylLbqFYDURDMyxJ6M= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-M3vrCZksPeyjlraEBhDY9w-1; Thu, 07 Jan 2021 03:02:00 -0500 X-MC-Unique: M3vrCZksPeyjlraEBhDY9w-1 Received: by mail-vk1-f200.google.com with SMTP id 84so3107372vkx.1 for ; Thu, 07 Jan 2021 00:02:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NW3wAEod9zUUVA1N4wAEMUfZhnRiHIweJUksEzCGqD8=; b=mVh5w6aaHfcUn77ftXMt8kXY6mhLeyc/o/pqDeRp5znefo4F1L5Vnl5eqXySPzTPwB RVhDInaIYUJSUnjjzJhYRpU7VJ2STHj8mhGY7pNgNAaPx7kLAfczQAKAorG3HOcB1lG9 nQOjwrRWxmMUmc3M0mwybdVaylf+uoAi/A6NfGnN4z/1IlS9zxAeoTWsYRfGTrruvZcO UNEZLRDx5Pb5ndzHgRBiJrQ4/Faa/Zv7P0/gOJ4HFOSdLLTmWoJYt67MAk0XCOMug+er Zod77zZZZh0n+fiwMZ2aNfQcliewkQLqiLhSGe4MHSdAlt4YmdY7ZXxQuFaXWKpxV23G T7hw== X-Gm-Message-State: AOAM5302AoqXfBruWi+De0i2LdOzHTW65wZgap7JG9gY6B53MCXsyF9E slCcUlvqGSzEAqKloZW59qM8Fy2nHw2+v9ZBh8um3/JKXdEIt8slDC14qqt9gUfqU4HsX54CcRm u8C4CU4o33wtYC7vZGZk= X-Received: by 2002:a67:6781:: with SMTP id b123mr6390923vsc.10.1610006520407; Thu, 07 Jan 2021 00:02:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxK7gZPV90g8IBC5glgsfWFVL7mF7VAOcNV1bc4Cy6xbV4mtzbkYO2O07SsFs+2Ftt5gBsjtTKmhfAZNK4Y9I0= X-Received: by 2002:a67:6781:: with SMTP id b123mr6390911vsc.10.1610006520211; Thu, 07 Jan 2021 00:02:00 -0800 (PST) MIME-Version: 1.0 References: <20201229194144.17824-1-ashish.sadanandan@gmail.com> <20201229121008.3644fed4@hermes.local> <20210106132132.GK2631@platinum> In-Reply-To: From: David Marchand Date: Thu, 7 Jan 2021 09:01:49 +0100 Message-ID: To: Ashish Sadanandan Cc: Olivier Matz , Stephen Hemminger , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan wrote: > > Hi Olivier, > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz wrote: > > > > Hi Ashish, > > > > Yes, it should reference the patch that introduced the issue. In this case, > > it should be: > > > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > > > Can you please also change the title to start with "fix", for > > instance like this: > > > > mbuf: fix inclusion from c++ > > > > You can also add "Cc: stable@dpdk.org" in the commit log. > > > > Some documentation can be found in doc/guides/contributing/patches.rst > > Thanks for the pointers. I've made the changes above. However I don't > know if I'm using the message ID for --in-reply-to correctly, since I > seem to be creating a new thread each time. You can get the message ID in various places. I usually take the info from patchwork and update the previous patch state to Superseded at the same time. So in your case, the v1 patch was: http://patchwork.dpdk.org/patch/85878/ Message ID: 20201229194144.17824-1-ashish.sadanandan@gmail.com So for the v2: git send-email --to dev@dpdk.org --cc-cmd ./devtools/get-maintainer.sh --cc XXX --in-reply-to '20201229194144.17824-1-ashish.sadanandan@gmail.com' v2-*.patch -- David Marchand