From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CEC2A0583; Thu, 19 Mar 2020 16:40:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 703D2F94; Thu, 19 Mar 2020 16:40:42 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id DA1EECF3 for <dev@dpdk.org>; Thu, 19 Mar 2020 16:40:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584632440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2JUvVWl/au4eOMTX7KNOxKnGngSpPvIJHCQhkmXqShM=; b=EXp35TYmGpISSK0y3CzxlQTNnt/64Hm+pFNhGQp5rKQv74ZR8zAhdNo+TjcRxQBp7OQrmW MBlaRN7Qn0NBaY0VVqCIIC9AhV2AabcehQs+AXYH6hF/bOpKRlWQeETU23SZ+g1w1Uj1t4 0FS9NifGhACGfqn3PGBTie0prc460Fs= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-8kXZBxJAOHOKJl9_OrjXUQ-1; Thu, 19 Mar 2020 11:40:36 -0400 X-MC-Unique: 8kXZBxJAOHOKJl9_OrjXUQ-1 Received: by mail-vk1-f200.google.com with SMTP id b136so939427vkf.20 for <dev@dpdk.org>; Thu, 19 Mar 2020 08:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FTKRQ6kzMO53XizWpATHZ+0Vmk8Banj4xDHCO9XTjVg=; b=O8g8k3PUWgMhaRVv9q0ywwcGiIeQ5GAs8gTW0Q1uBn56Zy2+WonvLOcEXTqE6gw8Dx u6jkvSdJsGVm/ohDdSj5g4cBb2bZ8RYIFk45IU7fW/8WditWl2dx9f2wvoStrsyz6ncl +mXv0NIxA5e1RWaIAJc40HKtoVyOXJpEKE4p4ldrWSKycKYzffKeU+AXyAcfA92ZV4jD Z07DwGsOTHTeoQ5N4jEJJ2HFbuZvJ095wQN5wvSC/P2Jppr1kgfHBGt3V3KN6zxlQVE3 w5skQjLfb3pJyLtdxMaHEfO34zUEmkMGbjYjBKaP7zYZAq9SBJ/SMEg7vvcYAZuVxMcc Nu7w== X-Gm-Message-State: ANhLgQ1/usCO3zhHTNHjGKL/n0UKuakmSTlvJmtU6VGpi1LANumGtwJi 4wHppeLeVPaL7tF/NE/QUsEyuFbNulOxvNg6WOf4B6kZd3oc1I96fT+TVDMia5YukiKHd4RPm1v z1KiFUqybcNpcELZi2tk= X-Received: by 2002:ab0:77c8:: with SMTP id y8mr2161390uar.126.1584632434758; Thu, 19 Mar 2020 08:40:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsFwrUthElqyl5oGXhztiFD/ItbEYfyheTidKALM/KqkcWYK2yonh0jzpH8o6kKmCtxWCGcWEctoNj25QeQ8iQ= X-Received: by 2002:ab0:77c8:: with SMTP id y8mr2161371uar.126.1584632434332; Thu, 19 Mar 2020 08:40:34 -0700 (PDT) MIME-Version: 1.0 References: <20200319082859.7162-1-david.marchand@redhat.com> <60947579.3F2A3RajZp@xps> In-Reply-To: <60947579.3F2A3RajZp@xps> From: David Marchand <david.marchand@redhat.com> Date: Thu, 19 Mar 2020 16:40:22 +0100 Message-ID: <CAJFAV8w_8K3rjnSXjqGQ1KYWzeu3uZXXMsdKoyLvUWJxsUa2xg@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] doc: prefer https when pointing to dpdk.org X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon <thomas@monjalon.net> wrot= e: > > 19/03/2020 09:28, David Marchand: > > for file in $(git grep -l http://.*dpdk.org doc/); do > > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > > done > > > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > --- > > + # links must prefer https over http > > + awk -v FOLDERS=3D'doc' \ > > + -v EXPRESSIONS=3D'http://.*dpdk.org' \ > > + -v RET_ON_FAIL=3D1 \ > > + -v MESSAGE=3D'Using non https link to dpdk.org' \ > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.aw= k \ > > + "$1" || res=3D1 > > Interesting policy. > When no authentication is required, I was trying to use simple http, > in the hope of making access faster. > What is the benefit of https for documentation? Avoid man-in-the-middle? People probably don't notice the little extra time required to load a page via https. Trying to go to dpdk.org with simple http: gets you redirected to https:. Then you browse down to the documentation with https, and finally you find some links in https. This is odd, but not a problem, I agree. All in all, I prefer a simple policy that works in most cases rather than this rule that we must be aware of when reviewing doc patches. --=20 David Marchand