From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D3A8A0540; Thu, 16 Jul 2020 21:12:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 266F72C4F; Thu, 16 Jul 2020 21:12:29 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id CA0762C2B for ; Thu, 16 Jul 2020 21:12:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594926747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/cyLsoWHvn6CePEvn1b0oxF79KSXMDiSixuNEoK3gw=; b=dU9O78fKWRpOqoWoxya8UBPWXw8Li+Ge80+kvZ2solvNYePfOsBecYWTFmrAa1WnyEzNmC f1sCh5lLDABC+tiUdtwhyuHI+FD8hxkGCXm0DTJw81UI5i7uOdbJ8/W0xZXhGYr91sIZVd 9GGV2h/UsVStd9/UkzEJfCyyGiEbk+Q= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-B3uFGxtiMQqxvTxqnooKgA-1; Thu, 16 Jul 2020 15:12:11 -0400 X-MC-Unique: B3uFGxtiMQqxvTxqnooKgA-1 Received: by mail-vk1-f198.google.com with SMTP id l8so2428727vkm.10 for ; Thu, 16 Jul 2020 12:12:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/cyLsoWHvn6CePEvn1b0oxF79KSXMDiSixuNEoK3gw=; b=R3EcEq2e8wlhIdcRQKci8TAGhgrnUXg5cNmhEEpNRMNDEa+Oa57WdyHWmvcpquz+eL s2cgYKGp+kfJg4n9W3cskURHdgGtoliPIWB69KenPVrdgOPTNpmr0RwgUsLjEWc2EpNG /JcaEIwKxUvgK2+FCuY+iBzPdkCc5m2nMN7Bi6AYH3NN94QIYLetmMk9dAFCudMfXHUs j6oOkN1bwNEY2WdQn8q3zmvOQMw7FOHoygZbZy2N4ogd6FirmNcX4OrABwt5Eq7gHFf5 6bisnXbK6Vx892d14MnGRLGjU2eus/uaO0aUlYOcKSOStVbFzEalwXDdHSSIeJkHCSxU r4zg== X-Gm-Message-State: AOAM530CcicaMoLJ8nFul8YSV/khyK68Lh19qY8ibXL/B0WqCZ4fH8bd NImmJpV4EtHlFUozGtIWTVP6qFzz9yrpVVD/j1qYAeZ4lGFA597yaGg2sVG94YdBnmRcda5PbAf r8dFDb6bf5aG09t1naJs= X-Received: by 2002:ab0:6950:: with SMTP id c16mr4669791uas.53.1594926730638; Thu, 16 Jul 2020 12:12:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8D48uDwoFbg8VSDXO2Y4qfExpqLsnT+EorGQ+Trt2YvEKBnJ/231twQIAA44/hSBuMGQ9Vup2Sfww1vqClcA= X-Received: by 2002:ab0:6950:: with SMTP id c16mr4669766uas.53.1594926730310; Thu, 16 Jul 2020 12:12:10 -0700 (PDT) MIME-Version: 1.0 References: <1594289442-18594-1-git-send-email-phil.yang@arm.com> <1594310331-23345-1-git-send-email-phil.yang@arm.com> <87h7u7k344.fsf@redhat.com> In-Reply-To: <87h7u7k344.fsf@redhat.com> From: David Marchand Date: Thu, 16 Jul 2020 21:11:59 +0200 Message-ID: To: Dodji Seketeli Cc: Phil Yang , Olivier Matz , Ray Kinsella , dev , Stephen Hemminger , David Christensen , Honnappa Nagarahalli , Ruifeng Wang , nd , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > Just for the sake of precision, I'd like to say that in the coming 1.8 > version of libabigail, this change won't be reported by the tooling as a > problem anymore. This is thanks to David filing the feature request > https://sourceware.org/bugzilla/show_bug.cgi?id=25661 a while ago. > > Until then, I understand that the current tooling needs to work with > libabigail 1.6. That's what we have in the CI with a 1.6 libabigail compiled in Ubuntu 18.04. I tested 20.04 in Travis (I can send a patch later), but it still has a 1.6 version. We will have to live with a "not that recent" version for some time. > > So maybe a more specific suppression rule (that you could still remove > for the 20.11 stable branch) could look like: > > [suppress_type] > name = rte_mbuf_ext_shared_info > has_data_member_inserted_between = {offset_of(refcnt_atomic), offset_of(refcnt_atomic)} > > > It's a "hack" that will only suppress change reports on the > rte_mbuf_ext_shared_info type if: > > 1/ it it has a data member inserted at the > offset of its data member 'refcnt_atomic', > > AND > > 2/ the size of rte_mbuf_ext_shared_info doesn't change. > > > There are cases where this won't work, though. But it might work for > this case. If it does, then great. I think it'd be a better solution > than a blanket suppression of all the changes on the type. Nice, thanks Dodji. -- David Marchand