From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A447DA32A2 for ; Thu, 24 Oct 2019 13:23:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A4391E955; Thu, 24 Oct 2019 13:23:29 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id EDA291E950 for ; Thu, 24 Oct 2019 13:23:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571916207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OA118ST+0udkkRwPH0EEQChUeF5okr0e0ZOBuhrNkYE=; b=hK4GGUq7Gi39m5KI3OEKc6ie4mIBq0CoyaqdiN0ijOUHQVAuyMkh9V2TnEdW2EMqeB4Vs2 PaJO4l8OfTNkmyxYNOqr+ZhOe4rBbu+mairrlQrog6OBj8HUz3wpoFA8n6EtIbc6PJivOn qskrO8XJ9fYO/AbI9kTiRdwS7JdTvD0= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-MKlInTRxOoSBLx_ap-l7uw-1; Thu, 24 Oct 2019 07:23:25 -0400 Received: by mail-vs1-f71.google.com with SMTP id c15so5223755vse.16 for ; Thu, 24 Oct 2019 04:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ULEJoS3OsBoI/Nb/k805wIay+lWN73MCSqrNvYAjTa0=; b=rMVRwYvPWCMKK6yznXmjOVn4pSW1Srx25BhLyI4SsoUzmtgsl6zdaHmByzTkW2cFuR GDaxOrhcHwduwQfiDcfBsp6POuRMS7QHOSDEyRsbvDSLEx8pBJH5ceMYdDxkJG9FUPb8 AqaO9f3rmoDQmG0m9SBQvz1kyhYrDBl2EqPOWbNYBx+hmUtaqcA22uH6yxbTDW5qOVuh PE28iAuChxFtiicRzZf5EF+EkeGTEKFngyVymB34ESSFh8IozB8dYxijDLPnGfYKI5A6 7376tKIdUhQgWftc4g5Ugz7Hzaoli7BJQj24KF2F45SBiGGKUvwp2Ht/HJJvNe9KFJ54 /gag== X-Gm-Message-State: APjAAAWOZmtceeR9JFZapmf7YetRgfLCqArgAouKlGD+OWjzJ+PwRVDU igr68fViT1lWKi9EbpEdRxhETuwQ9BD4lvudsrrtJj3DkX3Ebl1NJcxO1wE8jeygQODuFdYgSeS oXzHJIpyCD59t1wUd9ag= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1636237vsc.39.1571916205316; Thu, 24 Oct 2019 04:23:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbcXiH2iEl9rSZofQkG7uXkl3Hr9kJfLv6GzgrirWMqctJRVOIt2z+7lpCkmAwAJAFg1M8oEmARVyLEfqdkgs= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1636220vsc.39.1571916204957; Thu, 24 Oct 2019 04:23:24 -0700 (PDT) MIME-Version: 1.0 References: <1571827361-30578-1-git-send-email-han.li1@zte.com.cn> In-Reply-To: From: David Marchand Date: Thu, 24 Oct 2019 13:23:13 +0200 Message-ID: To: "Burakov, Anatoly" Cc: Li Han , Thomas Monjalon , dev X-MC-Unique: MKlInTRxOoSBLx_ap-l7uw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 24, 2019 at 1:14 PM Burakov, Anatoly wrote: > > On 24-Oct-19 8:37 AM, David Marchand wrote: > > On Wed, Oct 23, 2019 at 7:47 PM Burakov, Anatoly > > wrote: > >> > >> On 23-Oct-19 11:42 AM, Li Han wrote: > >>> In rte_eal_config_reattach(),the secondary mmap may fail > >>> due to the rte_mem_cfg_addr already be used by others.do > >>> the change just as the rte_fbarray_init() do.if no > >>> base_virtaddr,use the default 0x100000000. > >>> > >>> v2/v3: > >>> -fix code style issues > >>> > >>> Signed-off-by: Li Han > >>> --- > >> > >> Nack. There's a reason why we map it at the same address, and it's to > >> have all pointers working across processes. Remapping it at a differen= t > >> address has potential to break things. > > > > Marked as rejected. > > Thanks. > > > > Hi David, > > My apologies, I've misinterpreted the intent of the patch. I am > rescinding my NACK. Ok, I will put it back in my queue. No conflict with the work on http://patchwork.dpdk.org/project/dpdk/list/?series=3D5854 ? There was a comment by Stephen, btw. -- David Marchand