DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Neil Horman <nhorman@tuxdriver.com>, dev <dev@dpdk.org>,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	bingz@mellanox.com, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix check symbol change script
Date: Mon, 23 Mar 2020 14:19:35 +0100	[thread overview]
Message-ID: <CAJFAV8w_njadZhVpgOVNem9zkPgmLYQB8wn3sA2oPLwDp+2H2Q@mail.gmail.com> (raw)
In-Reply-To: <20200323115613.29677-1-ndabilpuram@marvell.com>

On Mon, Mar 23, 2020 at 12:56 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Fix check symbol change script to detect new diff file when
> it is in between  "--- /dev/null" to "b/lib/...".
> Current awk line expects line to start with "a/..."
> which is not always true for all diffs.
> As a result if in_map was '1' earlier, it will not be changed
> to '0' and we get check patch errors which are not true.
>
> Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Tested-by: Jerin Jacob <jerinj@marvell.com>

Thanks Nithin, applied.

-- 
David Marchand


      reply	other threads:[~2020-03-23 13:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 14:44 [dpdk-dev] [PATCH] " Nithin Dabilpuram
2020-03-19 14:56 ` David Marchand
2020-03-19 15:40   ` Neil Horman
2020-03-19 15:45     ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-03-19 18:59       ` Neil Horman
2020-03-19 15:49     ` [dpdk-dev] " Bing Zhao
2020-03-22 14:37 ` Jerin Jacob
2020-03-23  8:13 ` David Marchand
2020-03-23  9:28   ` [dpdk-dev] [EXT] " Nithin Dabilpuram
2020-03-23  9:30     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-03-23 11:56 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2020-03-23 13:19   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8w_njadZhVpgOVNem9zkPgmLYQB8wn3sA2oPLwDp+2H2Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bingz@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).