From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0839CA00E6 for ; Tue, 11 Jun 2019 11:44:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5DDF1C364; Tue, 11 Jun 2019 11:44:14 +0200 (CEST) Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by dpdk.org (Postfix) with ESMTP id DAFA71C362 for ; Tue, 11 Jun 2019 11:44:12 +0200 (CEST) Received: by mail-vs1-f49.google.com with SMTP id b10so7489652vsp.5 for ; Tue, 11 Jun 2019 02:44:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mqn3Zc0R6CF1eQ5CR4b40g6Z2jRDAGMo7SQnVGrOi5Q=; b=sjC1IBE4+i0jihCZdYOCGQYIhmXhCuhZqbdWm07Y8ziqqgs5geExguJYK9xrJHlLZi Bg70UkrgNUE95s4Gech8GyDokF1kVgMVqEHQvjD4xAe0FtRVMd6Ux/g1I/lJ6Et4+pbu jyGcROowqRTp38YGHzDk/rW5dKXPpOtk9Uy9gygkZU6RCfn3S69cXhDqxsx3ZEI92Dqz lWyHIKReOFAMxcHDq0111tIL6NTREzc4jmJLHKuOvIufEehOd0BEieYbM+fsAjDouW/6 jfY4bam/XTTVdpao5h6o15p95Z6aZ9CwLmI1ivwOVXlkD+etljmclJykdNEO+7kiULen 27zg== X-Gm-Message-State: APjAAAXN/hNkaJ/TR/wZ32wmvlSfNQMGfDWvBj/F0aVoiOZ3PmNinc1+ Hc2/OLTZHsVa/IBBjHOmCTIOJoHE01ZdIz/PqxeYcA== X-Google-Smtp-Source: APXvYqws0hGDsswsyUrDVKeCjcIYWjea0tSfhGjWqmXT935PHmZDHRwbIYU8MEBFwlpVGh54G/n3q5ma1pFb93mPaKI= X-Received: by 2002:a67:688f:: with SMTP id d137mr30566128vsc.198.1560246252182; Tue, 11 Jun 2019 02:44:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Tue, 11 Jun 2019 11:44:01 +0200 Message-ID: To: Ilya Maximets Cc: dev , Bruce Richardson , Ian Stokes , Aaron Conole , "ovs-dev@openvswitch.org" , "Yigit, Ferruh" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Forcing inlining for igb_uio and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 11, 2019 at 11:31 AM Ilya Maximets wrote: > On 11.06.2019 11:45, David Marchand wrote: > > I noticed that OVS CI [1] patches the dpdk sources to force some > inlining parameters and get kni and igb_uio to build fine. > > > > Looking at it in dpdk, meson support dropped this. > > In the makefiles, I can't find a reason in the git history (we go back > to 1.3.0rX version). > > > > [dmarchan@dmarchan dpdk]$ git grep max-inline-insns-single > > kernel/linux/igb_uio/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param > max-inline-insns-single=100 > > kernel/linux/kni/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param > max-inline-insns-single=50 > > [dmarchan@dmarchan dpdk]$ git blame origin/master -- > kernel/linux/igb_uio/Makefile |grep max-inline-insns-single > > 13dc56a6 lib/librte_eal/linuxapp/igb_uio/Makefile (Intel > 2012-12-20 00:00:00 +0100 15) MODULE_CFLAGS += -I$(SRCDIR) --param > max-inline-insns-single=100 > > [dmarchan@dmarchan dpdk]$ git blame origin/master -- > kernel/linux/kni/Makefile |grep max-inline-insns-single > > 3fc5ca2f lib/librte_eal/linuxapp/kni/Makefile (Intel > 2012-12-20 00:00:00 +0100 14) MODULE_CFLAGS += -I$(SRCDIR) --param > max-inline-insns-single=50 > > > > Is there a valid reason to keep this? > > 1: > https://github.com/openvswitch/ovs/blob/master/.travis/linux-build.sh#L81 > < > https://protect2.fireeye.com/url?k=b7de159c45b1fa79.b7df9ed3-c4806461f28ecaf5&u=https://github.com/openvswitch/ovs/blob/master/.travis/linux-build.sh#L81 > > > > Hi, David. > I don't know the reason for these in OVS travis config, But we don't > need to know them, actually. I have a patch to drop all the kernel > related stuff from the DPDK build in OVS Travis checks, just didn't > send it yet. Will send soon, probably. > I had this in mind since we don't need those kmods in the CI. Thanks Ilya. The question on dpdk side remains open :-). -- David Marchand