From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D76CA034F; Fri, 10 Sep 2021 09:18:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55C9C40041; Fri, 10 Sep 2021 09:18:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id B38614003E for ; Fri, 10 Sep 2021 09:18:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631258317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bVFZeUSUUQQbwG5fGd/07vTAzl3ZoduqBtIpT/uIqek=; b=U7VEmQ+l3H57qZTfJbR/UPJISDw1HdNuMWPNyoMRBmxPddZ1H62TUJFKy6+ZHyaRzwjdK3 la01h9UQqWy/IKHo/0RYL3AzLJSvGwbdQ7Yh1XgQ4w8gk0KHm4JzOWK/q2V9flekI3roY9 UWIPy9KEJuP/iUBQcgPn9tYqEJLsnCI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-cIswBEupNymiu3cwFTbLHw-1; Fri, 10 Sep 2021 03:18:36 -0400 X-MC-Unique: cIswBEupNymiu3cwFTbLHw-1 Received: by mail-lf1-f70.google.com with SMTP id q18-20020a05651232b200b003d9019c6ae4so398356lfe.22 for ; Fri, 10 Sep 2021 00:18:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bVFZeUSUUQQbwG5fGd/07vTAzl3ZoduqBtIpT/uIqek=; b=TWT2sSEGPjmI0v4X3fQaDW4EU4An2JvUWCywWauHNdVdLVSNq/AU0otjzrJOqI0LkX 6VeAHB1gHUP7j4V+6Otl7Y0swWLCkOTEYdpaGX2krFYc/x/Z1WRPDcmbPoeyGFfgz6ok aKQPYrr++pC1xJPsfuIwdHlsMo5+ph52LyCeASxHHB/zYrZv0ZBB/5LwJPYKH+mVk3Bq TEYTKc+yfV8zfE8kvPdIex+tv3nTsfaY5ryTe2CTQTIOel+NZW+olDCNPGSLrZdS85jO S5fcmAABL2u1ElTwhQ7sRAW/SK7eZNhU7nZUGtA3TzdrdL4upJObc/1fxAeBLpgM8PIy NbOA== X-Gm-Message-State: AOAM533WUws6ZTFZIkGboXPq9MxSWfxZVUsSE/S7wVZokChYeslPnZ9F trc8uYg/d366wXLeN4MDW50AYIMhdT9VszrUnDwAcosTK+LVmd8NYKcll4eDbWldgibC5paBvdc /4KaIKgAHBYeeRPkD2DQ= X-Received: by 2002:a2e:a230:: with SMTP id i16mr3005604ljm.333.1631258314954; Fri, 10 Sep 2021 00:18:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPm/Bpa8gE41TEgtWwpMVlLMZ14y9xSERjhNqu0wGHBbw5Arj1g+A+J5DndSjgnFilXiOTdB1mxf1jV+AUC+4= X-Received: by 2002:a2e:a230:: with SMTP id i16mr3005596ljm.333.1631258314790; Fri, 10 Sep 2021 00:18:34 -0700 (PDT) MIME-Version: 1.0 References: <20210910022402.26620-1-chenbo.xia@intel.com> <20210910022402.26620-7-chenbo.xia@intel.com> In-Reply-To: <20210910022402.26620-7-chenbo.xia@intel.com> From: David Marchand Date: Fri, 10 Sep 2021 09:18:23 +0200 Message-ID: To: Chenbo Xia Cc: dev , Cristian Dumitrescu , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 10, 2021 at 4:38 AM Chenbo Xia wrote: > > PCI ID and address in structure rte_kni_conf are never used and > will be removed in kni library. So remove the setting of them > first in the example. > > Signed-off-by: Chenbo Xia (forgot to Cc: Ferruh in previous comment) Ditto patch 5. I would tag with a Fixes: on ethtool removal. Plus, this is the same kind of cleanup wrt kni, you can squash those two patches together. Too bad we do not have a deprecation notice. lib/kni/rte_kni.h: struct rte_pci_addr addr; /* depreciated */ lib/kni/rte_kni.h: struct rte_pci_id id; /* depreciated */ Can we plan for this cleanup? -- David Marchand