From: David Marchand <david.marchand@redhat.com>
To: Amiya Ranjan Mohakud <amiya-ranjan.mohakud@broadcom.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org,
Jingjing Wu <jingjing.wu@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>
Subject: Re: [PATCH v2] net/iavf: remove error logs for vlan offloading
Date: Tue, 6 Feb 2024 13:47:57 +0100 [thread overview]
Message-ID: <CAJFAV8waG-HJbRjEq+hEWV_JOztMd3=SgMTUEkiPcorcp8105g@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zBSPq7dy6_LhDZN34oVNqofPkQDGA8PxHisK=gHRyAzQ@mail.gmail.com>
On Tue, Feb 6, 2024 at 1:46 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Tue, Feb 6, 2024 at 1:44 PM Amiya Ranjan Mohakud
> <amiya-ranjan.mohakud@broadcom.com> wrote:
> > I also see a similar error with iavf using dpdk-22.11.1. But in my case, I see 2 more additional error logs showing up during iavf_dev_configure(). It's with ESX-8.0U1 with an inbox driver. Firmware upgrade did not resolve the issue though.
> >
> > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_execute_vf_cmd(): Return failure -4 for cmd 27
> > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_enable_vlan_strip(): Failed to execute command of OP_ENABLE_VLAN_STRIPPING
> > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_dev_init_vlan(): Failed to update vlan offload
> > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 iavf_dev_configure(): configure VLAN failed: -5
> > 2023-12-08T09:58:01.156 |9322| MSG [NET] dpdk_log_write:107 iavf_execute_vf_cmd(): Return failure -5 for cmd 14
> >
> > I was currently following up with KaiwenX on this. Attached the mail thread for reference.
> >
> > Could you please let me know if this patch would fix the issue or any more additional fixes are needed?
>
> Those logs above are about actually requesting vlan offloading.
> While in my case, I was not requesting anything.
Ah sorry, I read too quickly and missed the iavf_dev_init_vlan().
Well, it may be related, though I can't produce the mailbox errors in
my case, which seems specific to the ESX PF driver.
And for this, I have no clue what is wrong.
--
David Marchand
next prev parent reply other threads:[~2024-02-06 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 9:56 [PATCH] " David Marchand
2024-02-06 10:03 ` Bruce Richardson
2024-02-06 10:20 ` David Marchand
2024-02-06 10:34 ` [PATCH v2] " David Marchand
2024-02-06 12:43 ` Amiya Ranjan Mohakud
2024-02-06 12:46 ` David Marchand
2024-02-06 12:47 ` David Marchand [this message]
2024-02-06 12:54 ` Amiya Ranjan Mohakud
2024-02-29 11:54 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8waG-HJbRjEq+hEWV_JOztMd3=SgMTUEkiPcorcp8105g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=amiya-ranjan.mohakud@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).