From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B07AA04B0; Wed, 6 Nov 2019 21:05:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFD671D15D; Wed, 6 Nov 2019 21:05:17 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9BD291D154 for ; Wed, 6 Nov 2019 21:05:15 +0100 (CET) Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09C9681F01 for ; Wed, 6 Nov 2019 20:05:15 +0000 (UTC) Received: by mail-vk1-f198.google.com with SMTP id l4so9693817vkn.6 for ; Wed, 06 Nov 2019 12:05:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZC7UbZB/SzYqPLK+7dlToyx8NbpsHZSbcWYNDpomlyc=; b=GTXiivogIheH88zNj9Uq5FH4vEj6bXTc3tetLuI52/lBwJhnJkUQ96WnLguOm9t+aM SsGHX05xe3MPTjk3CXxOi/MehfRq8zTzrvEygGQDcQsf/renqenjhtezNChEOOPqA/0o mRyaTwUhHhOKHkN3gaqvPZsjIQ0iPSOr21xS+5Y9wY+4b4dsSh+4yWvPdEpNayDdNTmY 2H8wuvKQH0d6mAfoWeLs4U5tqt8wPyNplXK/hsqq66Xb8wWcW3hEri2Dl8+NYtA/PVkU DOghUAZyKaKppc4/6pJpP/vA1apv1EcHjSX8WZlMV93qoNDF+FoqIAzJdBIAM2neLd3+ N2OQ== X-Gm-Message-State: APjAAAWPUH8dVdTU3kjgotNW84CNxTJBJYYJ/ijjdOpzIdCaYH7DamUA tAl+yJbFXL460jffnEDTR2Cbn5Rh4Qe0sOgJGHBbkNBiNM9BnFlGxKdJuMvho6ubu7UFJqLWV3R YDKGeqkkB7XVfmnZXdnE= X-Received: by 2002:a05:6102:75c:: with SMTP id v28mr2541646vsg.105.1573070714179; Wed, 06 Nov 2019 12:05:14 -0800 (PST) X-Google-Smtp-Source: APXvYqxlQA9q91bcrd6v7ku3/gIwuDnZEErqQeDj+8ymCjnb9/hiSq8XoVGX+8GOAQtwaqiPvzCYr/65FJWiq9vcSdA= X-Received: by 2002:a05:6102:75c:: with SMTP id v28mr2541608vsg.105.1573070713730; Wed, 06 Nov 2019 12:05:13 -0800 (PST) MIME-Version: 1.0 References: <20191028103443.42346-1-jin.yu@intel.com> <20191030094055.37889-1-jin.yu@intel.com> <6dae0e7b-08f5-a427-725b-604a86f87107@redhat.com> In-Reply-To: <6dae0e7b-08f5-a427-725b-604a86f87107@redhat.com> From: David Marchand Date: Wed, 6 Nov 2019 21:05:02 +0100 Message-ID: To: Maxime Coquelin Cc: Jin Yu , Tiwei Bie , dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Maxime, On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin wrote: > > Hi Jin, > > On 10/30/19 10:40 AM, Jin Yu wrote: > > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h > > So we need the librte_hash to be compiled before vhost. > > Add the DEPDIRs to make sure this. > > > > Bugzilla ID: 356 > > Fixes: 939066d96563 ("vhost/crypto: add public function implementation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jin Yu > > --- > > V2 - add the librte_crytodev > > --- > > lib/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/Makefile b/lib/Makefile > > index 41c463d92..b2a143d4f 100644 > > --- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev > > DEPDIRS-librte_rawdev := librte_eal librte_ethdev > > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost > > DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \ > > - librte_net > > + librte_net librte_hash librte_cryptodev > > DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash > > DEPDIRS-librte_hash := librte_eal librte_ring > > DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd > > > > http://mails.dpdk.org/archives/test-report/2019-October/105347.html > > The Intel compilation reports a breakage with this patch, and the > breakage happens in some crypto drivers. Could you please check it > is not a regression due to your patch? Should be fixed with: https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84 > > > *Make Build Failed #1: > OS: CENTOS76-64 > Target: x86_64-native-linuxapp-clang > CC zlib_pmd.o.pmd.o > LD qat_device.o > LD zlib_pmd.o > CC hw_atl_utils_fw2x.o > 1 error generated. > make[6]: *** [dpaa2_sec_dpseci.o] Error 1 > make[5]: *** [dpaa2_sec] Error 2 > make[5]: *** Waiting for unfinished jobs.... > CC hw_atl_b0.o > CC qat_logs.o > CC zlib_pmd_ops.o > CC rte_pmd_atlantic.o > -- > CC axgbe_rxtx_vec_sse.o > AR librte_pmd_octeontx_crypto.a > AR librte_pmd_bond.a > INSTALL-LIB librte_pmd_octeontx_crypto.a > INSTALL-LIB librte_pmd_bond.a > make[4]: *** [crypto] Error 2 > make[4]: *** Waiting for unfinished jobs.... > CC dpaa2_mux.o > == Build drivers/net/ena > CC dpaa2_sparser.o > CC mc/dpni.o > -- > CC hunt_nic.o > CC medford_nic.o > CC medford2_nic.o > AR librte_pmd_sfc_efx.a > INSTALL-LIB librte_pmd_sfc_efx.a > make[3]: *** [drivers] Error 2 > make[2]: *** [all] Error 2 > make[1]: *** [pre_install] Error 2 > make: *** [install] Error 2 > -- David Marchand