From: David Marchand <david.marchand@redhat.com>
To: Seth Howell <seth.howell@intel.com>
Cc: dev <dev@dpdk.org>,
dariusz.stojaszyk@intel.com,
"Gaëtan Rivet" <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency.
Date: Fri, 25 Oct 2019 10:43:11 +0200 [thread overview]
Message-ID: <CAJFAV8wap5yOafT-2EDZwcvN1XtA2n7jPvmSm_5Eu1ZcEB14pg@mail.gmail.com> (raw)
In-Reply-To: <20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com>
On Mon, Oct 14, 2019 at 5:16 PM Gaëtan Rivet <gaetan.rivet@6wind.com> wrote:
> On Mon, Oct 14, 2019 at 04:32:54PM +0200, David Marchand wrote:
> > On Fri, Oct 11, 2019 at 10:56 PM Seth Howell <seth.howell@intel.com> wrote:
> > >
> > > The makefile in drivers/bus/pci specified rte_ethdev as a dependency for
> > > the library. However there are no actual symbols from librte_ethdev used
> > > in librte_bus_pci.
> > >
> > > Including librte_ethdev as a dependency only becomes a problem in some
> > > niche cases like when attempting to build the rte_bus_pci library as a
> > > shared object without building the rte_ethdev library.
> > >
> > > I specifically ran into this when trying to build the DPDK included as
> > > an SPDK submodule on a FreeBSD machine. I figure that since there are no
> > > real dependencies between the two, we should enable building
> > > librte_bus_pci without librte_ethdev.
Fixes: c752998b5e2e ("pci: introduce library and driver")
Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Seth Howell <seth.howell@intel.com>
> Yes this is fine.
> I've checked, when this Makefile was introduced first in v17.11, this
> dependency was not needed either. This means the Fixes: can go back to c752998b5.
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-10-25 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 20:56 Seth Howell
2019-10-14 14:32 ` David Marchand
2019-10-14 15:16 ` Gaëtan Rivet
2019-10-25 8:43 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wap5yOafT-2EDZwcvN1XtA2n7jPvmSm_5Eu1ZcEB14pg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dariusz.stojaszyk@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=seth.howell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).