From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84900A32A2 for ; Fri, 25 Oct 2019 10:43:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18AFE1C10B; Fri, 25 Oct 2019 10:43:26 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0D4661C0CD for ; Fri, 25 Oct 2019 10:43:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571993004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfLEWbquExWT6/0sVjP1LniZgROJmtoJcKuFgeilWG8=; b=ORqujwZ50qqZ8JeiGVcW32urz6Q0TF7xpoHUuAkdWXzAj8kgdWe9IhUo+r3/ZE0tHNZXGQ AANjJ34IC/fkAWNQ36cK7RYPROoh08+BAF0ieAztZ/AsSbvx2bLF4qvquMVqZD8hcfUlFM 3dltegP4+Kl7U+7XqljjeKZLeGuAvys= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-Z1dr5nZ5OSSAVjFI_H9GMg-1; Fri, 25 Oct 2019 04:43:23 -0400 Received: by mail-vs1-f69.google.com with SMTP id p6so161153vsq.9 for ; Fri, 25 Oct 2019 01:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pfLEWbquExWT6/0sVjP1LniZgROJmtoJcKuFgeilWG8=; b=qU7Gfh/MPbGtYHqhUHrWtKN2t93nLrYNEFRyi7J0m7/0WgyX6HgY5tYZ5/F51WKpRZ Ol6YLWLBClnkQiobLr8bb5BHuthZ+htXpz/RVFsmKPX5ksC14t5bKQT90TomB+Pn/RmU BRFaySRFdLGe4oigMwFflj7BIIyj4fYm+EPlvafhLfk5zhqnrLhidrxyWFMSqwymsKTX lpUsRPbTCrNAPaw+y9vISkAbZepTIH6kKCeE7UpMSREdEU/PFfuvTj3YQFhP+U3mcYXH VDWbuEfNOyAozejlkJiC+kHSFkLMcPcOfsRgf5ciXoywpUTPnb+5zNC53v8KFGWBMM77 UmYQ== X-Gm-Message-State: APjAAAVq7iTPQCVEEPWCcGVOHgO/Zd8rZn4dN4VVnnZPoN9m8EopawXn taXEXQsHNbB0k4fDmSd4Wx91HPO4QZZHuOHsv0TSstIVlSdf+vG/tRIzpaKI6Xj6kE9glPQWpGp Kh6ZdgRnV3ve0Doolg5c= X-Received: by 2002:ab0:628f:: with SMTP id z15mr997514uao.126.1571993002613; Fri, 25 Oct 2019 01:43:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8RML5Co+I9wEOrTpkffWTogvwuBTQrDessuGa8X7lqyI5f5I9g0DNcNvTUETbcT3zzbbPEiYIF4Kw0RsXm5s= X-Received: by 2002:ab0:628f:: with SMTP id z15mr997503uao.126.1571993002362; Fri, 25 Oct 2019 01:43:22 -0700 (PDT) MIME-Version: 1.0 References: <20191011205607.1743460-1-seth.howell@intel.com> <20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com> In-Reply-To: <20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com> From: David Marchand Date: Fri, 25 Oct 2019 10:43:11 +0200 Message-ID: To: Seth Howell Cc: dev , dariusz.stojaszyk@intel.com, =?UTF-8?Q?Ga=C3=ABtan_Rivet?= X-MC-Unique: Z1dr5nZ5OSSAVjFI_H9GMg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 14, 2019 at 5:16 PM Ga=C3=ABtan Rivet = wrote: > On Mon, Oct 14, 2019 at 04:32:54PM +0200, David Marchand wrote: > > On Fri, Oct 11, 2019 at 10:56 PM Seth Howell wr= ote: > > > > > > The makefile in drivers/bus/pci specified rte_ethdev as a dependency = for > > > the library. However there are no actual symbols from librte_ethdev u= sed > > > in librte_bus_pci. > > > > > > Including librte_ethdev as a dependency only becomes a problem in som= e > > > niche cases like when attempting to build the rte_bus_pci library as = a > > > shared object without building the rte_ethdev library. > > > > > > I specifically ran into this when trying to build the DPDK included a= s > > > an SPDK submodule on a FreeBSD machine. I figure that since there are= no > > > real dependencies between the two, we should enable building > > > librte_bus_pci without librte_ethdev. Fixes: c752998b5e2e ("pci: introduce library and driver") Cc: stable@dpdk.org > > > > > > Signed-off-by: Seth Howell > Yes this is fine. > I've checked, when this Makefile was introduced first in v17.11, this > dependency was not needed either. This means the Fixes: can go back to c7= 52998b5. > > Acked-by: Gaetan Rivet Applied, thanks. -- David Marchand