From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A205043070; Tue, 15 Aug 2023 14:21:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E12C643036; Tue, 15 Aug 2023 14:21:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7C48C4114B for ; Tue, 15 Aug 2023 14:21:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692102097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4cDppMKeHt1/9OSTFtrYdK1O+rvhqB5GU96YhjKonv4=; b=QtKCKHGscQB3tRcAK8lWbjkH9UhT1g+aYojkehXpqbjhGmP2OyBoKqwF2UTGEcrWh79cXv KuTMOBCEaDA9FbPV+28X1xR700224b3cryiBoGCB/HMNHe1VhXjEgqpqUs/jkIFgbjUyZZ qcDejXtAF+xCZDp4gNYfnMB1+B3IDFo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-BlKJuOiqMt-b-x4s3-roRg-1; Tue, 15 Aug 2023 08:21:36 -0400 X-MC-Unique: BlKJuOiqMt-b-x4s3-roRg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fe0f0f6ec0so2958161e87.1 for ; Tue, 15 Aug 2023 05:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692102095; x=1692706895; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4cDppMKeHt1/9OSTFtrYdK1O+rvhqB5GU96YhjKonv4=; b=KU04ZbAzAw8S/rpvyAKFzc91CKKhg5SABUA+SYo0azAd9Gi92fRb1Wulc5rr+1E1YZ 57YpPxkW1L/rGcJ5Fwjd+vFIJ8venKXmSMjhN9BDrWjRpxGV2vL8QfIm5spwbenVQzVG 4mPe0HA3HyBFw07QHat3SD3UNMhrs8bhjaIHvVAkdRO/WvvWJd5U1h4M/WUugy6ARsdt vhcrhdzoBVuEJQ7QHFR1Ar8rVQcjOUBGqVZHZBZD2IFOF/cnHt7wI2TYPcovbt1WuaHa dEmAxsG/G31EyRJGMCEQQkD1UeLkNpkY9WogKRTSLLGZqwqTn2yBdwyr7rfBGgmym9JC K0PA== X-Gm-Message-State: AOJu0YwRfDNBVoEuUy9isVPG7IsmPFicdc6PpZ6Hl+HAteGWOUP8O+rj hDYaWVBpa6YxcHwH6coxVQ1rrZde06LsTTSk4oH0mvlTRCpUoCwNKRfnmUelTwzduUmK6SqOpSJ EUmFzlaLxnC2pfRiBeg0= X-Received: by 2002:a05:6512:3594:b0:4fe:17a8:bee5 with SMTP id m20-20020a056512359400b004fe17a8bee5mr390140lfr.31.1692102094889; Tue, 15 Aug 2023 05:21:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGLyt1XUhx8QhopHzeoNN/8NSwF8F54qfXlsMOCCx29d88AJVTT7GWwVY1oQOM3O+5GK/tPaMB/clM2UunxT0= X-Received: by 2002:a05:6512:3594:b0:4fe:17a8:bee5 with SMTP id m20-20020a056512359400b004fe17a8bee5mr390136lfr.31.1692102094522; Tue, 15 Aug 2023 05:21:34 -0700 (PDT) MIME-Version: 1.0 References: <20230812015738.1024-1-vipin.varghese@amd.com> <20230814162431.GA12422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230814162431.GA12422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 15 Aug 2023 14:21:22 +0200 Message-ID: Subject: Re: [PATCH] dma/skeleton: fix pthread set affinity To: Tyler Retzlaff , Vipin Varghese Cc: kevin.laatz@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, dev@dpdk.org, Ferruh.Yigit@amd.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 14, 2023 at 6:24=E2=80=AFPM Tyler Retzlaff wrote: > > On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote: > > In skeleton dma driver, the user can pin the dma thread to desired > > cpu core. The previous commit changed the api from set-affinity to > > get-affinity leading to thread to be pinned to first available lcore. > > > > Bugzilla ID: 1270 > > Fixes: 7fdf30d8b259 ("eal/windows: remove most pthread lifetime shim fu= nctions") This Fixes: looks wrong. I would blame (and blame the bad reviewers): Fixes: f241553b43ee ("dma/skeleton: drop some pthread API calls") Can you double check? --=20 David Marchand