From: David Marchand <david.marchand@redhat.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, stephen@networkplumber.org, sachin.saxena@nxp.com,
stable@dpdk.org, maxime@leroys.fr
Subject: Re: [PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close
Date: Sat, 8 Nov 2025 16:35:08 +0100 [thread overview]
Message-ID: <CAJFAV8wbS=+YVF_s9Y0H2fOTCtS8Ce1xa-3UR=fhQMoF5p=U4g@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8y4KCDG94OswHaYuk-0PaxdHKzO1_yG+rVVYTcBCJb1JQ@mail.gmail.com>
On Fri, 7 Nov 2025 at 09:32, David Marchand <david.marchand@redhat.com> wrote:
> > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> > index 7da32ce856..f3db7982a4 100644
> > --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> > @@ -3347,14 +3347,17 @@ static int
> > rte_dpaa2_remove(struct rte_dpaa2_device *dpaa2_dev)
> > {
> > struct rte_eth_dev *eth_dev;
> > - int ret;
> > + int ret = 0;
> >
> > eth_dev = dpaa2_dev->eth_dev;
>
> Having a back reference of the "class" object in a "device" object
> seems wrong to me (and there is a dev_priv->eth_dev too...).
> It breaks the separation that was introduced with rte_device years ago.
I went and had a try:
https://patchwork.dpdk.org/project/dpdk/list/?series=36627
No promise it works, but it is cleaner this way.
--
David Marchand
prev parent reply other threads:[~2025-11-08 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:38 Hemant Agrawal
2025-11-06 16:38 ` [PATCH 2/3] net/dpaa2: clear active VDQ state when freeing Rx queues Hemant Agrawal
2025-11-06 19:29 ` Stephen Hemminger
2025-11-07 9:51 ` Maxime Leroy
2025-11-07 10:38 ` Hemant Agrawal
2025-11-07 8:34 ` David Marchand
2025-11-06 16:38 ` [PATCH 3/3] bus/fslmc: add support for hotplug of dpni Hemant Agrawal
2025-11-07 8:32 ` [PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close David Marchand
2025-11-08 15:35 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wbS=+YVF_s9Y0H2fOTCtS8Ce1xa-3UR=fhQMoF5p=U4g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=maxime@leroys.fr \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).