From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95AA941BAE; Thu, 2 Feb 2023 14:48:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84AB34300A; Thu, 2 Feb 2023 14:48:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 35C8443008 for ; Thu, 2 Feb 2023 14:48:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675345728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XQJJBIk2egpUGvQc2x7+3uSOABahHYC832u+H5qiZXA=; b=WxQ4niiElqlKeiksb2B0WTeD+4EYNc3AXLnDqUJWwKHd0uuZV7v15MpT6aeZh/gY5xdb66 o2IPXHVigThl/+9nL2Ij2/I01OdXGuoMC/2Hkzht9FNSa5mfgDR8R3l3Jx0MAQY1wmcOGr qSIDNZTVWm0JXrHMm8E8b2z3ruQ0GM0= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-227-QcrEtszaNR2Q-Doobxp5AQ-1; Thu, 02 Feb 2023 08:48:47 -0500 X-MC-Unique: QcrEtszaNR2Q-Doobxp5AQ-1 Received: by mail-pg1-f200.google.com with SMTP id e11-20020a63d94b000000b0048988ed9a6cso1034695pgj.1 for ; Thu, 02 Feb 2023 05:48:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQJJBIk2egpUGvQc2x7+3uSOABahHYC832u+H5qiZXA=; b=pLJhk5UO5MjTxP/O/Y/aaFCkaoi7tGWVgOjbSrEBYwyWiNbgw82l15sNjLNwHWSAke zdaSLr/4tKV+tovhi6h+5bTeYxrzCGzb+Bf9aNRWMMejAPOeWxiFry12GWs7uePtbCYF 5i4BQKWyRaaS/IP1kD1CZBDsPfaGGl6raN5WmjO3aQ8eQU4dbYFPJIMX2tYj5Q2I1yAV SFLqVBUKx8AujSXX20upw8gGRF0EfJE64cm6m0MTF5jVwbfe348pDbOtJ2HevQZftlzX v/4yGI22FueecIEcPP8JMUON/DBBJ5CLvvYd4qCCi3VJTB5AVHtTCI6iz1/PeKny2PFq 7eGA== X-Gm-Message-State: AO0yUKXJRsO4EiKpz9ronPgkoCV9rNIuF5YFMTzvVdY+T0xaqyYRkRpR C7trpeMskixe2xf9Y5y6nooGQ530K5clnnTyGaeL4j+kHgmoSCp/VmN7cCqI5t4Y17LNC5aSrXW 3T4iWrzeD06hv7Je0X/g= X-Received: by 2002:a63:a25:0:b0:4f2:8007:5e1f with SMTP id 37-20020a630a25000000b004f280075e1fmr189988pgk.58.1675345726588; Thu, 02 Feb 2023 05:48:46 -0800 (PST) X-Google-Smtp-Source: AK7set+CGnYaJ7bQMbVcAZOUXQ81KEVdPDLGwyciGjJ6xxspXw0Ny3MCjWpIWlpA2ZJpgr5LFWxnd5NNO443P6pHbis= X-Received: by 2002:a63:a25:0:b0:4f2:8007:5e1f with SMTP id 37-20020a630a25000000b004f280075e1fmr189982pgk.58.1675345726313; Thu, 02 Feb 2023 05:48:46 -0800 (PST) MIME-Version: 1.0 References: <20230202123021.54416-1-simei.su@intel.com> <20230202123632.56730-1-simei.su@intel.com> In-Reply-To: From: David Marchand Date: Thu, 2 Feb 2023 14:48:35 +0100 Message-ID: Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration To: Simei Su , yuying.zhang@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 2, 2023 at 2:24 PM David Marchand wrote: > > On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > > "please call hierarchy_commit() " > > "before starting the port"); > > > > - max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD; > > - i40e_set_mac_max_frame(dev, max_frame_size); > > + max_frame_size = dev->data->mtu ? > > + dev->data->mtu + I40E_ETH_OVERHEAD : > > + I40E_FRAME_SIZE_MAX; > > + > > + /* Set the max frame size to HW*/ > > + ret = i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL); > > + if (ret) { > > + PMD_DRV_LOG(ERR, "Fail to set mac config"); > > + return ret; > > + } > > Reading this patch again. > > Returning here seems incorrect as we leave rx/tx queue in started state. > Don't we need to jump to tx_err label on error? There is probably an issue with interrupt handler still being registered too. Qi, i40e maintainers, please review this patch carefully, and ping me when it is ready so that we can test it at RH. Thanks. -- David Marchand