From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20C68A034C; Thu, 28 Apr 2022 14:08:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B42134281F; Thu, 28 Apr 2022 14:08:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 52E3042819 for ; Thu, 28 Apr 2022 14:08:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651147729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qritGy+fe8cofTLk+QkPeO33pPXRL5yQwR6xfdaaOdo=; b=gNjnjpSlBNhfOKX2qMDw0xmTDrl6RbxUKgCDi+yRpfPSLj/Cdb4XCTFPQkhb25ThkVxYvS EjT5zIg9sWkeAdzvxtOi76XbovE59SNkZQ815OqSvxyCDJiIJ26KDZISYp8yNkYK3FM1eN ICrZho8cacYVOzUS2+Q+FZRSxrdHQ90= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-gMZ7lAwqO1m4XDGsaB7UGg-1; Thu, 28 Apr 2022 08:08:48 -0400 X-MC-Unique: gMZ7lAwqO1m4XDGsaB7UGg-1 Received: by mail-lj1-f197.google.com with SMTP id x4-20020a05651c104400b0024f253d777fso1763348ljm.16 for ; Thu, 28 Apr 2022 05:08:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qritGy+fe8cofTLk+QkPeO33pPXRL5yQwR6xfdaaOdo=; b=VgWG9sQ0Jt92MkHD2QNYYQ5ATpXU7A011Hecu40B73hoQHA2IvhXFjoPNinJc4OAws DIwni7uJvKbhU02Y4STwjPpOig13uIHzsRZYEy9OdoV2BCwNApmFMFqbaqnRxsRpsNEx M5rS7Dvzw1KoMWe7pI6c33b2vJRUcr6SfTq8PvcUhSSBQWSUB8b2vXBFfu31diiFbKan OJ+Vt/0tZ6AgjwrpACYiu1Oyvl2/yMNT3/920Z/YpJAWkGQiBaIgm48uWhJPFIMSHM0a zNSjtxRsfuRFfJtrGAZmHQNDEBLRL/OEKOldLAsokAmSjYcxi3FK7A+OQienNYjNBap1 AsGw== X-Gm-Message-State: AOAM533dWZv3xZ0eVSwLZhaAy+qe5Imi6dZgj2+eWjsqWf0DvjOsq7/b MNwV8oq7VGHaE+6mOKH2hASnjhBkmeFxGIsnWnvye39lwnVc6l+C3a2A4wcHEFja2Y9lKOyGd9g FQL9HF1srUe8WiXs48GE= X-Received: by 2002:a05:6512:250d:b0:472:816:f613 with SMTP id be13-20020a056512250d00b004720816f613mr13921155lfb.265.1651147727418; Thu, 28 Apr 2022 05:08:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLW+5r6wCczCOIRT8HSiQNox9QFBZprmN8bqejxFJHPqnkg+bm0KNO60XQCe1RoKFYjcU4zUxwy23LawADaiE= X-Received: by 2002:a05:6512:250d:b0:472:816:f613 with SMTP id be13-20020a056512250d00b004720816f613mr13921133lfb.265.1651147727136; Thu, 28 Apr 2022 05:08:47 -0700 (PDT) MIME-Version: 1.0 References: <1649075577-67300-1-git-send-email-deepak.khandelwal@intel.com> <1650532281-193591-1-git-send-email-deepak.khandelwal@intel.com> In-Reply-To: <1650532281-193591-1-git-send-email-deepak.khandelwal@intel.com> From: David Marchand Date: Thu, 28 Apr 2022 14:08:35 +0200 Message-ID: Subject: Re: [PATCH v2] eal/linux: skip attaching to external memory chunk To: Deepak Khandelwal Cc: "Burakov, Anatoly" , dev , dpdk stable , balaji.chintalapalle@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 21, 2022 at 11:36 AM Deepak Khandelwal wrote: > > Currently, EAL init in secondary processes will attach all fbarrays > in the memconfig to have access to primary process' page tables. > However, fbarrays corresponding to external memory segments should > not be attached at initialization, because this will happen as part > of `rte_extmem_attach` or `rte_malloc_heap_memory_attach` calls. > > Both external memory API's document this: > > rte_malloc: > http://doc.dpdk.org/api/rte__malloc_8h.html#af6360dea35bdf162feeb2b62cf149fd3 > > rte_extmem: > http://doc.dpdk.org/api/rte__memory_8h.html#a2796da68de6825f8edf53759f8e4d230 > > Fixes: ff3619d6244b ("malloc: allow attaching to external memory chunks") > Cc: stable@dpdk.org > > Signed-off-by: Deepak Khandelwal > Suggested-by: Anatoly Burakov > Acked-by: Anatoly Burakov Applied, thanks Deepak. -- David Marchand