From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA93CA034F; Wed, 6 May 2020 11:42:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E71811D736; Wed, 6 May 2020 11:42:07 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 22E381D72C for ; Wed, 6 May 2020 11:42:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588758125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWBU8V4FFHPOVooCECI9cJ3Z09+BCXsiWtpbeUg3M8s=; b=GUkH9fRgX/VSDL3uKRY9C9kbwd3SdjdeM8asKrzpi1t0DBTCJlp0MC27sYGPmjovKykW+o rfbkCBTWr7LjwzvCQ3EpRAmK1Rcwz/bOBPGNkRJsa+RcwLkpmUDqpJsVklWdz6pSZ+aipl THOfJAuHLVGx+xMY6fe7UfbzZUyYe/4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-JgwNdnAnPb6DmUkGh6rhwQ-1; Wed, 06 May 2020 05:42:02 -0400 X-MC-Unique: JgwNdnAnPb6DmUkGh6rhwQ-1 Received: by mail-vs1-f71.google.com with SMTP id a22so199877vsl.18 for ; Wed, 06 May 2020 02:42:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7o9DF06Z3YgB1VzMrSIfJGRkXzClo+jg9hQtGx0yqZg=; b=UTRaLWjxjEm4O51MngqVcUJyTN7WmcvScxHc6gqCpqF2RcDCfm+Q2HQK9rlXEt2w6d R/uETZWh8uhEsxEArkRATRPtTHbSBmtPUlCQVw0+X4WSuAd+edsENJ00Q2uKf+gJf2RF uLG9SFKoGM5av7N5CRT412OnZMapxBTdjPzUeJ2KbeJDeUhgBfZr6TE3h7bsIKRCweJS sKGyvAnWO1fEq+xucTrHzufr4iRi1JckMU5otWvHPBLtla420EASg9kzb7+RXgzLKl5x MG3JdVfJ7q6UknhP8Fu7z3p0Mh7M3lSuJ1ioy6JVcvyDHGENP2gBUXMSr9CwdH3Mpuoi azIA== X-Gm-Message-State: AGi0PubqS+fXptjego3GTXvYGbjSDxnMDLsoAhzGSEYrJ+7L50tlix6m tXEJWrtVjWZ+EHrpEUKERkmVRHsVoAlAAnOD2E70pxBo/fH43sTZA/C/A9iZRSIZrY8TH/GUyWf ESdNCmvacmD2suXAv298= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr7181054vsq.141.1588758121907; Wed, 06 May 2020 02:42:01 -0700 (PDT) X-Google-Smtp-Source: APiQypLu16aRbxinl/NdtVGVyeKtZEBRrXYJwMH1sLvqbE5WtTe3P84PzQo0WoAJcbbmKHgdA6QYrIO+dn31DJ5PTt0= X-Received: by 2002:a05:6102:382:: with SMTP id m2mr7181034vsq.141.1588758121699; Wed, 06 May 2020 02:42:01 -0700 (PDT) MIME-Version: 1.0 References: <1588060706-27316-1-git-send-email-orika@mellanox.com> <1588256535-55626-1-git-send-email-orika@mellanox.com> In-Reply-To: <1588256535-55626-1-git-send-email-orika@mellanox.com> From: David Marchand Date: Wed, 6 May 2020 11:41:50 +0200 Message-ID: To: Ori Kam Cc: Thomas Monjalon , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , David Christensen , Beilei Xing , Qi Zhang , Maxime Coquelin , Zhihong Wang , Xiaolong Ye , Raslan , dev , "Yigit, Ferruh" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] eal/ppc: fix redefine bool type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 30, 2020 at 4:22 PM Ori Kam wrote: > > The AltiVec header file breaks boolean type. [1] [2] > > Currently the workaround was located only in mlx5 device. > Adding the trace module caused this issue to appear again, due to > order of includes, it keeps overriding the local fix. > > This patch solves this issue by resetting the bool type, immediately > after it is being changed. > > [1] https://mails.dpdk.org/archives/dev/2018-August/110281.html > > [2] > In file included from > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h:18:0, > from > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool.h:54, > from > dpdk/drivers/common/mlx5/mlx5_common_mr.c:7: > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h: In > function '__rte_trace_point_fp_is_enabled': > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:226:2: > error: incompatible types when returning type 'int' but '__vector __bool > int' was expected > return false; > ^ > In file included from > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:281:0, > from > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h:18, > from > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool.h:54, > from > dpdk/drivers/common/mlx5/mlx5_common_mr.c:7: > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h: > In function 'rte_mempool_trace_ops_dequeue_bulk': > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point_provider.h:104:6: > error: wrong type argument to unary exclamation mark > if (!__rte_trace_point_fp_is_enabled()) \ > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:49:2: > note: in expansion of macro '__rte_trace_point_emit_header_fp' > __rte_trace_point_emit_header_##_mode(&__##_tp); \ > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:99:2: > note: in expansion of macro '__RTE_TRACE_POINT' > __RTE_TRACE_POINT(fp, tp, args, __VA_ARGS__) > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h:20:1: > note: in expansion of macro 'RTE_TRACE_POINT_FP' > RTE_TRACE_POINT_FP( > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h: > In function 'rte_mempool_trace_ops_dequeue_contig_blocks': > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point_provider.h:104:6: > error: wrong type argument to unary exclamation mark > if (!__rte_trace_point_fp_is_enabled()) \ > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:49:2: > note: in expansion of macro '__rte_trace_point_emit_header_fp' > __rte_trace_point_emit_header_##_mode(&__##_tp); \ > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point.h:99:2: > note: in expansion of macro '__RTE_TRACE_POINT' > __RTE_TRACE_POINT(fp, tp, args, __VA_ARGS__) > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h:29:1: > note: in expansion of macro 'RTE_TRACE_POINT_FP' > RTE_TRACE_POINT_FP( > ^ > dpdk/ppc_64-power8-linux-gcc/include/rte_mempool_trace_fp.h: > In function 'rte_mempool_trace_ops_enqueue_bulk': > dpdk/ppc_64-power8-linux-gcc/include/rte_trace_point_provider.h:104:6: > error: wrong type argument to unary exclamation mark > if (!__rte_trace_point_fp_is_enabled()) \ > > Fixes: 725f5dd0bfb5 ("net/mlx5: fix build on PPC64") > > Signed-off-by: Ori Kam > Signed-off-by: David Christensen Tested-by: David Christensen Tested-by: Raslan Darawsheh Acked-by: Matan Azrad Applied, thanks. --=20 David Marchand