From: David Marchand <david.marchand@redhat.com>
To: jia.guo@intel.com
Cc: bernard.iremonger@intel.com, Wenzhuo Lu <wenzhuo.lu@intel.com>,
shahafs@mellanox.com, thomas@monjalon.net, matan@mellanox.com,
ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
dev@dpdk.org, stephen@networkplumber.org,
gaetan.rivet@6wind.com, qi.z.zhang@intel.com,
arybchenko@solarflare.com, bruce.richardson@intel.com,
shaopeng.he@intel.com, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option
Date: Mon, 17 Dec 2018 11:15:45 +0100 [thread overview]
Message-ID: <CAJFAV8wcOh7eeo-8nDPg_EpPVxjXNCavTXJ8EhvZ30G8Jpmf-Q@mail.gmail.com> (raw)
In-Reply-To: <1544773540-89825-2-git-send-email-jia.guo@intel.com>
On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo <jia.guo@intel.com> wrote:
> This command-line option will enable hotplug event detecting and enable
> hotplug handling for device hotplug.
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>
Is there a reason why we would want this disabled by default and enabled
via option ?
diff --git a/lib/librte_eal/common/eal_options.h
> b/lib/librte_eal/common/eal_options.h
> index 5271f94..4d8a12e 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -65,7 +65,9 @@ enum {
> OPT_SINGLE_FILE_SEGMENTS_NUM,
> #define OPT_IOVA_MODE "iova-mode"
> OPT_IOVA_MODE_NUM,
> - OPT_LONG_MAX_NUM
> + OPT_LONG_MAX_NUM,
> +#define OPT_DEV_HOTPLUG "dev-hotplug"
> + OPT_DEV_HOTPLUG_NUM,
> };
>
> extern const char eal_short_options[];
>
OPT_LONG_MAX_NUM is supposed to be the last enum.
--
David Marchand
next prev parent reply other threads:[~2018-12-17 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 7:45 [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug Jeff Guo
2018-12-14 7:45 ` [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option Jeff Guo
2018-12-17 10:15 ` David Marchand [this message]
2018-12-29 4:06 ` Jeff Guo
2019-01-02 14:46 ` David Marchand
2018-12-14 7:45 ` [dpdk-dev] [PATCH 2/3] ethdev: remove ethdev rmv interrupt Jeff Guo
2018-12-14 7:45 ` [dpdk-dev] [PATCH 3/3] testpmd: remove device detach into eal Jeff Guo
2019-04-08 14:10 ` [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug Iremonger, Bernard
2019-04-08 14:10 ` Iremonger, Bernard
2023-06-09 17:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wcOh7eeo-8nDPg_EpPVxjXNCavTXJ8EhvZ30G8Jpmf-Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=shaopeng.he@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).